[INFO] cloning repository https://github.com/ahcodedthat/sitemap-from-files [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ahcodedthat/sitemap-from-files" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahcodedthat%2Fsitemap-from-files", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahcodedthat%2Fsitemap-from-files'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1ddcc5799286cc4c15f68c3573dfedef19abd5a6 [INFO] checking ahcodedthat/sitemap-from-files/1ddcc5799286cc4c15f68c3573dfedef19abd5a6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fahcodedthat%2Fsitemap-from-files" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ahcodedthat/sitemap-from-files on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ahcodedthat/sitemap-from-files [INFO] finished tweaking git repo https://github.com/ahcodedthat/sitemap-from-files [INFO] tweaked toml for git repo https://github.com/ahcodedthat/sitemap-from-files written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ahcodedthat/sitemap-from-files already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57a6a3c5b85e003cad10642f2d0aa4c382aca7de80bfcba7916a19cd0dff56c2 [INFO] running `Command { std: "docker" "start" "-a" "57a6a3c5b85e003cad10642f2d0aa4c382aca7de80bfcba7916a19cd0dff56c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57a6a3c5b85e003cad10642f2d0aa4c382aca7de80bfcba7916a19cd0dff56c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57a6a3c5b85e003cad10642f2d0aa4c382aca7de80bfcba7916a19cd0dff56c2", kill_on_drop: false }` [INFO] [stdout] 57a6a3c5b85e003cad10642f2d0aa4c382aca7de80bfcba7916a19cd0dff56c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d90fcc0c99adfcd6000b3f6b26d2d84ec2bb50dc802f86bf973a93b051b9824b [INFO] running `Command { std: "docker" "start" "-a" "d90fcc0c99adfcd6000b3f6b26d2d84ec2bb50dc802f86bf973a93b051b9824b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling libc v0.2.124 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling getrandom v0.2.6 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking clap_lex v0.1.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking chrono_utils v0.1.3 [INFO] [stderr] Checking concolor-query v0.0.5 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking concolor v0.0.8 [INFO] [stderr] Checking filetime v0.2.16 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking dunce v1.0.2 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking snapbox-macros v0.2.1 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking similar v2.1.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking snapbox v0.2.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.1.11 [INFO] [stderr] Checking string_cache v0.8.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking texting_robots v0.2.1 [INFO] [stderr] Checking sitemap v0.4.1 [INFO] [stderr] Checking sitemap-from-files v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `cfg_path` is never read [INFO] [stdout] --> src/scan.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Scan<'c, W: Write> { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub cfg_path: &'c Path, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 67 | let mut stdout = stdout.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | stdout.write_all(sitemap.as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:61:11 [INFO] [stdout] | [INFO] [stdout] 60 | fn new(kind: NodeKind) -> Rc { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Rc::new(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 62 | | parent: RefCell::new(None), [INFO] [stdout] 63 | | kind, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:129:15 [INFO] [stdout] | [INFO] [stdout] 125 | let document = Node::new(NodeKind::Document); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | all_nodes: Vec::from([ [INFO] [stdout] | ________________________^ [INFO] [stdout] 130 | | Rc::downgrade(&document), [INFO] [stdout] 131 | | ]), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 125 | let document = Node::new(NodeKind::Document); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | meta_elements: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:228:17 [INFO] [stdout] | [INFO] [stdout] 227 | fn create_comment(&mut self, _text: html5ever::tendril::StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | self.new_node(Node::new(NodeKind::Comment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 231 | fn create_pi(&mut self, _target: html5ever::tendril::StrTendril, _data: html5ever::tendril::StrTendril) -> Self::Handle { [INFO] [stdout] | --------------------------------------- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | self.new_node(Node::new(NodeKind::Pi)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sitemap-from-files` (bin "sitemap-from-files") due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `cfg_path` is never read [INFO] [stdout] --> src/scan.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Scan<'c, W: Write> { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | pub cfg_path: &'c Path, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 67 | let mut stdout = stdout.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | stdout.write_all(sitemap.as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:61:11 [INFO] [stdout] | [INFO] [stdout] 60 | fn new(kind: NodeKind) -> Rc { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Rc::new(Self { [INFO] [stdout] | _________________^ [INFO] [stdout] 62 | | parent: RefCell::new(None), [INFO] [stdout] 63 | | kind, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:129:15 [INFO] [stdout] | [INFO] [stdout] 125 | let document = Node::new(NodeKind::Document); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | all_nodes: Vec::from([ [INFO] [stdout] | ________________________^ [INFO] [stdout] 130 | | Rc::downgrade(&document), [INFO] [stdout] 131 | | ]), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:133:19 [INFO] [stdout] | [INFO] [stdout] 125 | let document = Node::new(NodeKind::Document); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | meta_elements: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:228:17 [INFO] [stdout] | [INFO] [stdout] 227 | fn create_comment(&mut self, _text: html5ever::tendril::StrTendril) -> Self::Handle { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | self.new_node(Node::new(NodeKind::Comment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scan/check_html_meta.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 231 | fn create_pi(&mut self, _target: html5ever::tendril::StrTendril, _data: html5ever::tendril::StrTendril) -> Self::Handle { [INFO] [stdout] | --------------------------------------- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | self.new_node(Node::new(NodeKind::Pi)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sitemap-from-files` (bin "sitemap-from-files" test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d90fcc0c99adfcd6000b3f6b26d2d84ec2bb50dc802f86bf973a93b051b9824b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d90fcc0c99adfcd6000b3f6b26d2d84ec2bb50dc802f86bf973a93b051b9824b", kill_on_drop: false }` [INFO] [stdout] d90fcc0c99adfcd6000b3f6b26d2d84ec2bb50dc802f86bf973a93b051b9824b