[INFO] cloning repository https://github.com/aharisu/navi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aharisu/navi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faharisu%2Fnavi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faharisu%2Fnavi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 38558dc0bb326124e273ff73d87f43f970dc4f62 [INFO] checking aharisu/navi/38558dc0bb326124e273ff73d87f43f970dc4f62 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faharisu%2Fnavi" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aharisu/navi on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aharisu/navi [INFO] finished tweaking git repo https://github.com/aharisu/navi [INFO] tweaked toml for git repo https://github.com/aharisu/navi written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aharisu/navi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c02fd20d8976b9a6182b4d186f38d4a0876c8c557c07d6a6a9834c581a3d17dd [INFO] running `Command { std: "docker" "start" "-a" "c02fd20d8976b9a6182b4d186f38d4a0876c8c557c07d6a6a9834c581a3d17dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c02fd20d8976b9a6182b4d186f38d4a0876c8c557c07d6a6a9834c581a3d17dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c02fd20d8976b9a6182b4d186f38d4a0876c8c557c07d6a6a9834c581a3d17dd", kill_on_drop: false }` [INFO] [stdout] c02fd20d8976b9a6182b4d186f38d4a0876c8c557c07d6a6a9834c581a3d17dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae8aa13f6491b086e87e2f97289b466ad17225719e40733e12d41bc7f41f9a07 [INFO] running `Command { std: "docker" "start" "-a" "ae8aa13f6491b086e87e2f97289b466ad17225719e40733e12d41bc7f41f9a07", kill_on_drop: false }` [INFO] [stderr] Checking navi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/value.rs:277:24 [INFO] [stdout] | [INFO] [stdout] 277 | pub struct ExtraTypeId(usize); [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ExtraTypeId` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:431:39 [INFO] [stdout] | [INFO] [stdout] 407 | let mut builder = array::ArrayBuilder::new(size, obj)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | alloc_into_iform(IFormSeq::alloc(&builder.get().reach(obj), obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:623:41 [INFO] [stdout] | [INFO] [stdout] 599 | let mut builder = array::ArrayBuilder::new(size, obj)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 623 | alloc_into_iform(IFormAndOr::alloc(&builder.get().reach(obj), AndOrKind::MatchSuccess, obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:893:14 [INFO] [stdout] | [INFO] [stdout] 891 | pub fn return_object_switch(mut cur_object: StandaloneObject) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 892 | cur_object.object.take_prev_object() [INFO] [stdout] 893 | .map(|target_object| { [INFO] [stdout] | ______________^ [INFO] [stdout] 894 | | //オブジェクトの確保を行わないため、例外は発生しない [INFO] [stdout] 895 | | object_switch_inner(cur_object, target_object.as_ref(), false).unwrap() [INFO] [stdout] 896 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:895:13 [INFO] [stdout] | [INFO] [stdout] 891 | pub fn return_object_switch(mut cur_object: StandaloneObject) -> Option { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 895 | object_switch_inner(cur_object, target_object.as_ref(), false).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/value/syntax/match.rs:261:32 [INFO] [stdout] | [INFO] [stdout] 261 | for (pat, body) in patterns.clone().into_iter() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec<(Vec>, ptr::Reachable)>` does not implement `Clone`, so calling `clone` on `&Vec<(Vec>, ptr::Reachable)>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 261 - for (pat, body) in patterns.clone().into_iter() { [INFO] [stdout] 261 + for (pat, body) in patterns.into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/syntax/match.rs:520:23 [INFO] [stdout] | [INFO] [stdout] 519 | let body = body.clone(obj); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | list::List::alloc(compile::literal::begin().cast_value(), &body, obj) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn app_call(app: &Reachable, args_iter: impl Iterator> [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | code_execute(&literal::code_call(), limit, obj) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `navi` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/value.rs:277:24 [INFO] [stdout] | [INFO] [stdout] 277 | pub struct ExtraTypeId(usize); [INFO] [stdout] | ----------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ExtraTypeId` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:431:39 [INFO] [stdout] | [INFO] [stdout] 407 | let mut builder = array::ArrayBuilder::new(size, obj)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 431 | alloc_into_iform(IFormSeq::alloc(&builder.get().reach(obj), obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:623:41 [INFO] [stdout] | [INFO] [stdout] 599 | let mut builder = array::ArrayBuilder::new(size, obj)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 623 | alloc_into_iform(IFormAndOr::alloc(&builder.get().reach(obj), AndOrKind::MatchSuccess, obj)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:893:14 [INFO] [stdout] | [INFO] [stdout] 891 | pub fn return_object_switch(mut cur_object: StandaloneObject) -> Option { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 892 | cur_object.object.take_prev_object() [INFO] [stdout] 893 | .map(|target_object| { [INFO] [stdout] | ______________^ [INFO] [stdout] 894 | | //オブジェクトの確保を行わないため、例外は発生しない [INFO] [stdout] 895 | | object_switch_inner(cur_object, target_object.as_ref(), false).unwrap() [INFO] [stdout] 896 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:895:13 [INFO] [stdout] | [INFO] [stdout] 891 | pub fn return_object_switch(mut cur_object: StandaloneObject) -> Option { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 895 | object_switch_inner(cur_object, target_object.as_ref(), false).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/value/syntax/match.rs:261:32 [INFO] [stdout] | [INFO] [stdout] 261 | for (pat, body) in patterns.clone().into_iter() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec<(Vec>, ptr::Reachable)>` does not implement `Clone`, so calling `clone` on `&Vec<(Vec>, ptr::Reachable)>` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 261 - for (pat, body) in patterns.clone().into_iter() { [INFO] [stdout] 261 + for (pat, body) in patterns.into_iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/syntax/match.rs:520:23 [INFO] [stdout] | [INFO] [stdout] 519 | let body = body.clone(obj); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 520 | list::List::alloc(compile::literal::begin().cast_value(), &body, obj) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:345:19 [INFO] [stdout] | [INFO] [stdout] 297 | pub fn app_call(app: &Reachable, args_iter: impl Iterator> [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | code_execute(&literal::code_call(), limit, obj) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `navi` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ae8aa13f6491b086e87e2f97289b466ad17225719e40733e12d41bc7f41f9a07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae8aa13f6491b086e87e2f97289b466ad17225719e40733e12d41bc7f41f9a07", kill_on_drop: false }` [INFO] [stdout] ae8aa13f6491b086e87e2f97289b466ad17225719e40733e12d41bc7f41f9a07