[INFO] cloning repository https://github.com/agourlay/ray-tracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/agourlay/ray-tracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagourlay%2Fray-tracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagourlay%2Fray-tracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 00bbd59c33434618922654cdb1016497186a9cba [INFO] checking agourlay/ray-tracer/00bbd59c33434618922654cdb1016497186a9cba against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fagourlay%2Fray-tracer" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/agourlay/ray-tracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/agourlay/ray-tracer [INFO] finished tweaking git repo https://github.com/agourlay/ray-tracer [INFO] tweaked toml for git repo https://github.com/agourlay/ray-tracer written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/agourlay/ray-tracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ab1f59d97e531857014311f7595f4196b44bad2f4ae155bac2451c57dbdecbd [INFO] running `Command { std: "docker" "start" "-a" "3ab1f59d97e531857014311f7595f4196b44bad2f4ae155bac2451c57dbdecbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ab1f59d97e531857014311f7595f4196b44bad2f4ae155bac2451c57dbdecbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ab1f59d97e531857014311f7595f4196b44bad2f4ae155bac2451c57dbdecbd", kill_on_drop: false }` [INFO] [stdout] 3ab1f59d97e531857014311f7595f4196b44bad2f4ae155bac2451c57dbdecbd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3daf265ae5a9b15495ed28aa569b024e74309080987ef0766cccb239f4a2e7ee [INFO] running `Command { std: "docker" "start" "-a" "3daf265ae5a9b15495ed28aa569b024e74309080987ef0766cccb239f4a2e7ee", kill_on_drop: false }` [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `local_point` [INFO] [stdout] --> src/plane.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 57 | fn local_normal_at(&self, local_point: &(f64, f64, f64, f64)) -> (f64, f64, f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_point` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `field_of_view` and `transform` are never read [INFO] [stdout] --> src/camera.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | field_of_view: f64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 11 | transform: Matrix, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `make_with_color` and `color_at` are never used [INFO] [stdout] --> src/canvas.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Canvas { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn make_with_color(width: usize, height: usize, color: Color) -> Canvas { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn color_at(self, x: usize, y: usize) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `intersection_distance`, `point`, and `inside` are never read [INFO] [stdout] --> src/intersection.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PreparedComputations { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 13 | pub object_id: usize, [INFO] [stdout] 14 | pub intersection_distance: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 15 | pub point: Tuple, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub inside: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/material.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl Material { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn new(color: Color, diffuse: f64, specular: f64) -> Material { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `make_matrix_2`, `make_matrix_3`, and `shearing` are never used [INFO] [stdout] --> src/matrix.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl Matrix { [INFO] [stdout] | ----------- associated functions in this implementation [INFO] [stdout] 10 | pub fn make_matrix_2(aa: f64, ab: f64, ba: f64, bb: f64) -> Matrix { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | pub fn make_matrix_3( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 257 | pub fn shearing(xy: f64, xz: f64, yx: f64, yz: f64, zx: f64, zy: f64) -> Matrix { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Projectile` is never constructed [INFO] [stdout] --> src/projectile.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Projectile { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Projectile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Env` is never constructed [INFO] [stdout] --> src/projectile.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct Env { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `tick` and `simulation` are never used [INFO] [stdout] --> src/projectile.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Projectile { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 18 | fn tick(self: Projectile, env: &Env) -> Projectile { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn simulation() -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_radius` is never used [INFO] [stdout] --> src/sphere.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Sphere { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn set_radius(self, radius: f64) -> Sphere { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tuples_are_equal` is never used [INFO] [stdout] --> src/tuple.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn tuples_are_equal(t1: &Tuple, t2: &Tuple) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tuple_is_vector` is never used [INFO] [stdout] --> src/tuple.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn tuple_is_vector(t: &Tuple) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tuple_is_point` is never used [INFO] [stdout] --> src/tuple.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn tuple_is_point(t: &Tuple) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `scale_tuple_division` is never used [INFO] [stdout] --> src/tuple.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn scale_tuple_division(v: &Tuple, scale: f64) -> Tuple { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `set_lights` and `default` are never used [INFO] [stdout] --> src/world.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl World { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn set_lights(self, lights: Vec) -> World { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | pub fn default() -> World { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | let mut output = File::create(filename)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let ppm = self.to_ppm(); [INFO] [stdout] 79 | output.write(ppm.as_bytes()).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer") due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `local_point` [INFO] [stdout] --> src/plane.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 57 | fn local_normal_at(&self, local_point: &(f64, f64, f64, f64)) -> (f64, f64, f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_point` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `local_ray` [INFO] [stdout] --> src/shape.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 86 | fn local_intersect(&self, local_ray: &Ray) -> Vec { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_ray` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `local_point` [INFO] [stdout] --> src/shape.rs:90:35 [INFO] [stdout] | [INFO] [stdout] 90 | fn local_normal_at(&self, local_point: &(f64, f64, f64, f64)) -> (f64, f64, f64, f64) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_point` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `intersection_distance` is never read [INFO] [stdout] --> src/intersection.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct PreparedComputations { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] 13 | pub object_id: usize, [INFO] [stdout] 14 | pub intersection_distance: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Projectile` is never constructed [INFO] [stdout] --> src/projectile.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Projectile { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Projectile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Env` is never constructed [INFO] [stdout] --> src/projectile.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct Env { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `tick` and `simulation` are never used [INFO] [stdout] --> src/projectile.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Projectile { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 18 | fn tick(self: Projectile, env: &Env) -> Projectile { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn simulation() -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `tuples_are_equal` is never used [INFO] [stdout] --> src/tuple.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn tuples_are_equal(t1: &Tuple, t2: &Tuple) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_lights` is never used [INFO] [stdout] --> src/world.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl World { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn set_lights(self, lights: Vec) -> World { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 77 | let mut output = File::create(filename)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let ppm = self.to_ppm(); [INFO] [stdout] 79 | output.write(ppm.as_bytes()).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ray-tracer` (bin "ray-tracer" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3daf265ae5a9b15495ed28aa569b024e74309080987ef0766cccb239f4a2e7ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3daf265ae5a9b15495ed28aa569b024e74309080987ef0766cccb239f4a2e7ee", kill_on_drop: false }` [INFO] [stdout] 3daf265ae5a9b15495ed28aa569b024e74309080987ef0766cccb239f4a2e7ee