[INFO] cloning repository https://github.com/aegroto/rust-example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aegroto/rust-example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faegroto%2Frust-example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faegroto%2Frust-example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 29716a91b273035c7b3ed983770a1ccc42265178 [INFO] checking aegroto/rust-example/29716a91b273035c7b3ed983770a1ccc42265178 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faegroto%2Frust-example" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aegroto/rust-example on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aegroto/rust-example [INFO] finished tweaking git repo https://github.com/aegroto/rust-example [INFO] tweaked toml for git repo https://github.com/aegroto/rust-example written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aegroto/rust-example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec8aad2b012937d82dc4f765538b6f09bdde4b6fb525506acac59b98bf4cb11b [INFO] running `Command { std: "docker" "start" "-a" "ec8aad2b012937d82dc4f765538b6f09bdde4b6fb525506acac59b98bf4cb11b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec8aad2b012937d82dc4f765538b6f09bdde4b6fb525506acac59b98bf4cb11b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec8aad2b012937d82dc4f765538b6f09bdde4b6fb525506acac59b98bf4cb11b", kill_on_drop: false }` [INFO] [stdout] ec8aad2b012937d82dc4f765538b6f09bdde4b6fb525506acac59b98bf4cb11b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85f6b84bf8834cac4f6119c8ac0fb77c0f4ce33e9cb4a069adadb998943cfec0 [INFO] running `Command { std: "docker" "start" "-a" "85f6b84bf8834cac4f6119c8ac0fb77c0f4ce33e9cb4a069adadb998943cfec0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking rust-example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::types::Alterable` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::types::Alterable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::types::Alterable` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use crate::types::Alterable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_alterations_using_trait` is never used [INFO] [stdout] --> src/analytics.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn calculate_alterations_using_trait(alterables: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_altered` is never used [INFO] [stdout] --> src/types.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Alterable { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 10 | fn is_altered(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 71 | entries: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | sender: Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> JoinHandle<()> { [INFO] [stdout] 74 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | let hvf = analytics::calculate_hidden_values_frequencies(&entries); [INFO] [stdout] 76 | | sender [INFO] [stdout] 77 | | .send(AnalyticsMessageData::HiddenValuesFrequencies(hvf)) [INFO] [stdout] 78 | | .expect("[HVF] Unable to send hidden values frequencies"); [INFO] [stdout] 79 | | println!("[HVF] Calculated hidden values frequencies."); [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 84 | entries: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | sender: Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ) -> JoinHandle<()> { [INFO] [stdout] 87 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | let alterations = analytics::calculate_alterations(&entries); [INFO] [stdout] 89 | | sender [INFO] [stdout] 90 | | .send(AnalyticsMessageData::Alterations(alterations)) [INFO] [stdout] 91 | | .expect("[Alterations] Unable to send alterations"); [INFO] [stdout] 92 | | println!("[Alterations] Calculated alterations."); [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:19 [INFO] [stdout] | [INFO] [stdout] 96 | fn spawn_display_thread(receiver: Receiver) -> JoinHandle<()> { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 98 | | match receiver.recv().unwrap() { [INFO] [stdout] 99 | | AnalyticsMessageData::HiddenValuesFrequencies(v) => { [INFO] [stdout] 100 | | println!("[Display] Hidden values frequencies: {:?}", v) [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-example` (bin "rust-example") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `calculate_alterations_using_trait` is never used [INFO] [stdout] --> src/analytics.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn calculate_alterations_using_trait(alterables: &Vec>) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_altered` is never used [INFO] [stdout] --> src/types.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait Alterable { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 10 | fn is_altered(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 71 | entries: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | sender: Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> JoinHandle<()> { [INFO] [stdout] 74 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 75 | | let hvf = analytics::calculate_hidden_values_frequencies(&entries); [INFO] [stdout] 76 | | sender [INFO] [stdout] 77 | | .send(AnalyticsMessageData::HiddenValuesFrequencies(hvf)) [INFO] [stdout] 78 | | .expect("[HVF] Unable to send hidden values frequencies"); [INFO] [stdout] 79 | | println!("[HVF] Calculated hidden values frequencies."); [INFO] [stdout] 80 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 84 | entries: Arc>, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | sender: Sender, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ) -> JoinHandle<()> { [INFO] [stdout] 87 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | let alterations = analytics::calculate_alterations(&entries); [INFO] [stdout] 89 | | sender [INFO] [stdout] 90 | | .send(AnalyticsMessageData::Alterations(alterations)) [INFO] [stdout] 91 | | .expect("[Alterations] Unable to send alterations"); [INFO] [stdout] 92 | | println!("[Alterations] Calculated alterations."); [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:19 [INFO] [stdout] | [INFO] [stdout] 96 | fn spawn_display_thread(receiver: Receiver) -> JoinHandle<()> { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 98 | | match receiver.recv().unwrap() { [INFO] [stdout] 99 | | AnalyticsMessageData::HiddenValuesFrequencies(v) => { [INFO] [stdout] 100 | | println!("[Display] Hidden values frequencies: {:?}", v) [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-example` (bin "rust-example" test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "85f6b84bf8834cac4f6119c8ac0fb77c0f4ce33e9cb4a069adadb998943cfec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85f6b84bf8834cac4f6119c8ac0fb77c0f4ce33e9cb4a069adadb998943cfec0", kill_on_drop: false }` [INFO] [stdout] 85f6b84bf8834cac4f6119c8ac0fb77c0f4ce33e9cb4a069adadb998943cfec0