[INFO] cloning repository https://github.com/adrianncovaci/stm32client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adrianncovaci/stm32client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianncovaci%2Fstm32client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianncovaci%2Fstm32client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b06686d7634050472aa26993a4aa12da19fc5c8 [INFO] checking adrianncovaci/stm32client/5b06686d7634050472aa26993a4aa12da19fc5c8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianncovaci%2Fstm32client" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adrianncovaci/stm32client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adrianncovaci/stm32client [INFO] finished tweaking git repo https://github.com/adrianncovaci/stm32client [INFO] tweaked toml for git repo https://github.com/adrianncovaci/stm32client written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adrianncovaci/stm32client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d64ced600b73047a4073f43ccd41493ad8131e0890bed107e1d42d012dcd94e [INFO] running `Command { std: "docker" "start" "-a" "1d64ced600b73047a4073f43ccd41493ad8131e0890bed107e1d42d012dcd94e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d64ced600b73047a4073f43ccd41493ad8131e0890bed107e1d42d012dcd94e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d64ced600b73047a4073f43ccd41493ad8131e0890bed107e1d42d012dcd94e", kill_on_drop: false }` [INFO] [stdout] 1d64ced600b73047a4073f43ccd41493ad8131e0890bed107e1d42d012dcd94e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 619a600aa912550988f67c21ad710d78bc14cd5e567414671d971fa8e58e7aa0 [INFO] running `Command { std: "docker" "start" "-a" "619a600aa912550988f67c21ad710d78bc14cd5e567414671d971fa8e58e7aa0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking embedded-io v0.4.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking postcard v1.0.8 [INFO] [stderr] Checking stm-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `lma` [INFO] [stdout] --> src/main.rs:140:40 [INFO] [stdout] | [INFO] [stdout] 140 | fn send_program_request(&mut self, lma: u64, binfile: PathBuf) -> Result<(), std::io::Error> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_lma` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | let mut segments = binfile.chunks(self.chunk_size as usize); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lma` [INFO] [stdout] --> src/main.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | lma, [INFO] [stdout] | ^^^ help: try ignoring the field: `lma: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mac_address` [INFO] [stdout] --> src/main.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | mac_address, [INFO] [stdout] | ^^^^^^^^^^^ help: try ignoring the field: `mac_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ip_address` [INFO] [stdout] --> src/main.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | ip_address, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `ip_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gateway_address` [INFO] [stdout] --> src/main.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | gateway_address, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try ignoring the field: `gateway_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prefix_length` [INFO] [stdout] --> src/main.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | prefix_length, [INFO] [stdout] | ^^^^^^^^^^^^^ help: try ignoring the field: `prefix_length: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 131 | let socket = TcpStream::connect((hostname, port))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Self { socket, chunk_size }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lma` [INFO] [stdout] --> src/main.rs:140:40 [INFO] [stdout] | [INFO] [stdout] 140 | fn send_program_request(&mut self, lma: u64, binfile: PathBuf) -> Result<(), std::io::Error> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_lma` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | let mut segments = binfile.chunks(self.chunk_size as usize); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lma` [INFO] [stdout] --> src/main.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | lma, [INFO] [stdout] | ^^^ help: try ignoring the field: `lma: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mac_address` [INFO] [stdout] --> src/main.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | mac_address, [INFO] [stdout] | ^^^^^^^^^^^ help: try ignoring the field: `mac_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ip_address` [INFO] [stdout] --> src/main.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | ip_address, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `ip_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `gateway_address` [INFO] [stdout] --> src/main.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | gateway_address, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try ignoring the field: `gateway_address: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prefix_length` [INFO] [stdout] --> src/main.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | prefix_length, [INFO] [stdout] | ^^^^^^^^^^^^^ help: try ignoring the field: `prefix_length: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stm-client` (bin "stm-client" test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 131 | let socket = TcpStream::connect((hostname, port))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Self { socket, chunk_size }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stm-client` (bin "stm-client") due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "619a600aa912550988f67c21ad710d78bc14cd5e567414671d971fa8e58e7aa0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "619a600aa912550988f67c21ad710d78bc14cd5e567414671d971fa8e58e7aa0", kill_on_drop: false }` [INFO] [stdout] 619a600aa912550988f67c21ad710d78bc14cd5e567414671d971fa8e58e7aa0