[INFO] cloning repository https://github.com/adrianbrink/arcade-game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adrianbrink/arcade-game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianbrink%2Farcade-game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianbrink%2Farcade-game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be86a3553f45bb6f726a4c76997b34c17556aff2 [INFO] checking adrianbrink/arcade-game/be86a3553f45bb6f726a4c76997b34c17556aff2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadrianbrink%2Farcade-game" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adrianbrink/arcade-game on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adrianbrink/arcade-game [INFO] finished tweaking git repo https://github.com/adrianbrink/arcade-game [INFO] tweaked toml for git repo https://github.com/adrianbrink/arcade-game written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adrianbrink/arcade-game already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c4a7abb27cddce5404ce7deec9ad26848dc75a59ed03050ed710112b2d31420 [INFO] running `Command { std: "docker" "start" "-a" "1c4a7abb27cddce5404ce7deec9ad26848dc75a59ed03050ed710112b2d31420", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c4a7abb27cddce5404ce7deec9ad26848dc75a59ed03050ed710112b2d31420", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c4a7abb27cddce5404ce7deec9ad26848dc75a59ed03050ed710112b2d31420", kill_on_drop: false }` [INFO] [stdout] 1c4a7abb27cddce5404ce7deec9ad26848dc75a59ed03050ed710112b2d31420 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c18e95ae704568a47445ef258c432907e63afbb10abf12b2841fe5ba5bcd72c7 [INFO] running `Command { std: "docker" "start" "-a" "c18e95ae704568a47445ef258c432907e63afbb10abf12b2841fe5ba5bcd72c7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Compiling sdl2-sys v0.27.2 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking lazy_static v0.2.5 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num-integer v0.1.33 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking sdl2 v0.29.0 [INFO] [stderr] Checking arcade-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/views/game.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Renderer`, `TextureQuery`, and `Texture` [INFO] [stdout] --> src/views/game.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use sdl2::render::{Renderer, Texture, TextureQuery}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::image::LoadTexture` [INFO] [stdout] --> src/views/game.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use sdl2::image::LoadTexture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Events`, `Phi`, `ViewAction`, and `View` [INFO] [stdout] --> src/main.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use phi::{Events, Phi, View, ViewAction}; [INFO] [stdout] | ^^^^^^ ^^^ ^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/phi/mod.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 62 | ChangeView(Box), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | ChangeView(Box), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/views/main_menu.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | func: Box ViewAction>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | func: Box ViewAction>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/phi/mod.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | where F: Fn(&mut Phi) -> Box [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | where F: Fn(&mut Phi) -> Box [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/views/game.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Renderer`, `TextureQuery`, and `Texture` [INFO] [stdout] --> src/views/game.rs:7:20 [INFO] [stdout] | [INFO] [stdout] 7 | use sdl2::render::{Renderer, Texture, TextureQuery}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::image::LoadTexture` [INFO] [stdout] --> src/views/game.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use sdl2::image::LoadTexture; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Events`, `Phi`, `ViewAction`, and `View` [INFO] [stdout] --> src/main.rs:7:11 [INFO] [stdout] | [INFO] [stdout] 7 | use phi::{Events, Phi, View, ViewAction}; [INFO] [stdout] | ^^^^^^ ^^^ ^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/phi/mod.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 62 | ChangeView(Box), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | ChangeView(Box), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/views/main_menu.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | func: Box ViewAction>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | func: Box ViewAction>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/phi/mod.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | where F: Fn(&mut Phi) -> Box [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | where F: Fn(&mut Phi) -> Box [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/views/main_menu.rs:18:58 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/views/main_menu.rs:18:58 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Resized` [INFO] [stdout] --> src/phi/events.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Window { win_event: Resized, .. } => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_Resized` [INFO] [stdout] | [INFO] [stdout] ::: src/phi/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / struct_events! { [INFO] [stdout] 14 | | keyboard: { [INFO] [stdout] 15 | | key_escape: Escape, [INFO] [stdout] 16 | | key_up: Up, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] = note: this warning originates in the macro `struct_events` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Resized` [INFO] [stdout] --> src/phi/events.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Window { win_event: Resized, .. } => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_Resized` [INFO] [stdout] | [INFO] [stdout] ::: src/phi/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / struct_events! { [INFO] [stdout] 14 | | keyboard: { [INFO] [stdout] 15 | | key_escape: Escape, [INFO] [stdout] 16 | | key_up: Up, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] = note: this warning originates in the macro `struct_events` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `win_h` [INFO] [stdout] --> src/views/main_menu.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | let (win_w, win_h) = phi.output_size(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_win_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elapsed` [INFO] [stdout] --> src/views/main_menu.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | fn render(&mut self, phi: &mut Phi, elapsed: f64) -> ViewAction { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elapsed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cached_fonts` is never read [INFO] [stdout] --> src/phi/mod.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct Phi<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | cached_fonts: HashMap<(&'static str, u16), ::sdl2::ttf::Font<'static, 'static>>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `overlaps` is never used [INFO] [stdout] --> src/phi/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Rectangle { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn overlaps(&self, other: Rectangle) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `render` is never used [INFO] [stdout] --> src/phi/gfx.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 50 | impl AnimatedSprite { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn render(&self, renderer: &mut Renderer, dest: Rectangle) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rect` is never used [INFO] [stdout] --> src/views/game.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 88 | impl RectBullet { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 105 | fn rect(&self) -> Rectangle { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | |phi| Box::new(::views::main_menu::MainMenuView::new(phi))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Resized` should have a snake case name [INFO] [stdout] --> src/phi/events.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Window { win_event: Resized, .. } => { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `resized` [INFO] [stdout] | [INFO] [stdout] ::: src/phi/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / struct_events! { [INFO] [stdout] 14 | | keyboard: { [INFO] [stdout] 15 | | key_escape: Escape, [INFO] [stdout] 16 | | key_up: Up, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = note: this warning originates in the macro `struct_events` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(events: Events, renderer: Renderer<'a>, font_context: Sdl2TtfContext) -> Phi<'a> { [INFO] [stdout] | -------------- ---------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | cached_fonts: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `win_h` [INFO] [stdout] --> src/views/main_menu.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | let (win_w, win_h) = phi.output_size(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_win_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | .and_then(|font| font [INFO] [stdout] | ________________________----__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | .render(text) [INFO] [stdout] 53 | | .blended(color).ok() [INFO] [stdout] 54 | | .and_then(|surface| self.renderer.create_texture_from_surface(&surface).ok()) [INFO] [stdout] | |___________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elapsed` [INFO] [stdout] --> src/views/main_menu.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | fn render(&mut self, phi: &mut Phi, elapsed: f64) -> ViewAction { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elapsed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | .and_then(|surface| self.renderer.create_texture_from_surface(&surface).ok()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cached_fonts` is never read [INFO] [stdout] --> src/phi/mod.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct Phi<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | cached_fonts: HashMap<(&'static str, u16), ::sdl2::ttf::Font<'static, 'static>>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `overlaps` is never used [INFO] [stdout] --> src/phi/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Rectangle { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn overlaps(&self, other: Rectangle) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `render` is never used [INFO] [stdout] --> src/phi/gfx.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 50 | impl AnimatedSprite { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 91 | fn render(&self, renderer: &mut Renderer, dest: Rectangle) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `rect` is never used [INFO] [stdout] --> src/views/game.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 88 | impl RectBullet { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 105 | fn rect(&self) -> Rectangle { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | |phi| Box::new(::views::main_menu::MainMenuView::new(phi))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Resized` should have a snake case name [INFO] [stdout] --> src/phi/events.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Window { win_event: Resized, .. } => { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `resized` [INFO] [stdout] | [INFO] [stdout] ::: src/phi/mod.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / struct_events! { [INFO] [stdout] 14 | | keyboard: { [INFO] [stdout] 15 | | key_escape: Escape, [INFO] [stdout] 16 | | key_up: Up, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = note: this warning originates in the macro `struct_events` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(events: Events, renderer: Renderer<'a>, font_context: Sdl2TtfContext) -> Phi<'a> { [INFO] [stdout] | -------------- ---------------------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | cached_fonts: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | .and_then(|font| font [INFO] [stdout] | ________________________----__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | .render(text) [INFO] [stdout] 53 | | .blended(color).ok() [INFO] [stdout] 54 | | .and_then(|surface| self.renderer.create_texture_from_surface(&surface).ok()) [INFO] [stdout] | |___________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/mod.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | .and_then(|surface| self.renderer.create_texture_from_surface(&surface).ok()) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/phi/gfx.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | renderer.copy(&mut self.tex.borrow_mut(), Option::from(self.src.to_sdl()), Option::from(dest.to_sdl())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = renderer.copy(&mut self.tex.borrow_mut(), Option::from(self.src.to_sdl()), Option::from(dest.to_sdl())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/gfx.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(sprites: Vec, frame_delay: f64) -> AnimatedSprite { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | AnimatedSprite { [INFO] [stdout] 53 | sprites: Rc::new(sprites), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/gfx.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(texture: Texture) -> Sprite { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | tex: Rc::new(RefCell::new(texture)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/phi/gfx.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / renderer.copy(&mut self.tex.borrow_mut(), [INFO] [stdout] 144 | | Option::from(self.src.to_sdl()), [INFO] [stdout] 145 | | Option::from(dest.to_sdl())); [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 143 | let _ = renderer.copy(&mut self.tex.borrow_mut(), [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/views/game.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | phi.renderer.fill_rect(self.rect.to_sdl()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 102 | let _ = phi.renderer.fill_rect(self.rect.to_sdl()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/game.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn with_background(phi: &mut Phi, bg: BgSet) -> ShipView { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | // Get the spaceship's sprites [INFO] [stdout] 187 | let spritesheet = Sprite::load(&mut phi.renderer, "assets/spaceship.png").unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let mut sprites = Vec::with_capacity(9); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | player: Ship { [INFO] [stdout] | _____________________^ [INFO] [stdout] 203 | | rect: Rectangle { [INFO] [stdout] 204 | | x: 64.0, [INFO] [stdout] 205 | | y: 64.0, [INFO] [stdout] ... | [INFO] [stdout] 210 | | current: ShipFrame::MidNorm, [INFO] [stdout] 211 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/game.rs:215:23 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn with_background(phi: &mut Phi, bg: BgSet) -> ShipView { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | // Get the spaceship's sprites [INFO] [stdout] 187 | let spritesheet = Sprite::load(&mut phi.renderer, "assets/spaceship.png").unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let mut sprites = Vec::with_capacity(9); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | asteroid: Asteroid::new(phi), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/views/game.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | phi.renderer.fill_rect(self.player.rect.to_sdl()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 298 | let _ = phi.renderer.fill_rect(self.player.rect.to_sdl()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/main_menu.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | idle_sprite: phi.ttf_str_sprite(label, "assets/belligerent.ttf", 32, Color::RGB(220, 220, 220)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/main_menu.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | hover_sprite: phi.ttf_str_sprite(label, "assets/belligerent.ttf", 38, Color::RGB(255, 255, 0)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/phi/gfx.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | renderer.copy(&mut self.tex.borrow_mut(), Option::from(self.src.to_sdl()), Option::from(dest.to_sdl())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = renderer.copy(&mut self.tex.borrow_mut(), Option::from(self.src.to_sdl()), Option::from(dest.to_sdl())); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/gfx.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(sprites: Vec, frame_delay: f64) -> AnimatedSprite { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | AnimatedSprite { [INFO] [stdout] 53 | sprites: Rc::new(sprites), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phi/gfx.rs:104:18 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new(texture: Texture) -> Sprite { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | tex: Rc::new(RefCell::new(texture)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/phi/gfx.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / renderer.copy(&mut self.tex.borrow_mut(), [INFO] [stdout] 144 | | Option::from(self.src.to_sdl()), [INFO] [stdout] 145 | | Option::from(dest.to_sdl())); [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 143 | let _ = renderer.copy(&mut self.tex.borrow_mut(), [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/views/game.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | phi.renderer.fill_rect(self.rect.to_sdl()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 102 | let _ = phi.renderer.fill_rect(self.rect.to_sdl()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/game.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn with_background(phi: &mut Phi, bg: BgSet) -> ShipView { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | // Get the spaceship's sprites [INFO] [stdout] 187 | let spritesheet = Sprite::load(&mut phi.renderer, "assets/spaceship.png").unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let mut sprites = Vec::with_capacity(9); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | player: Ship { [INFO] [stdout] | _____________________^ [INFO] [stdout] 203 | | rect: Rectangle { [INFO] [stdout] 204 | | x: 64.0, [INFO] [stdout] 205 | | y: 64.0, [INFO] [stdout] ... | [INFO] [stdout] 210 | | current: ShipFrame::MidNorm, [INFO] [stdout] 211 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/game.rs:215:23 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn with_background(phi: &mut Phi, bg: BgSet) -> ShipView { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | // Get the spaceship's sprites [INFO] [stdout] 187 | let spritesheet = Sprite::load(&mut phi.renderer, "assets/spaceship.png").unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let mut sprites = Vec::with_capacity(9); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | asteroid: Asteroid::new(phi), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/views/game.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | phi.renderer.fill_rect(self.player.rect.to_sdl()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 298 | let _ = phi.renderer.fill_rect(self.player.rect.to_sdl()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/main_menu.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | idle_sprite: phi.ttf_str_sprite(label, "assets/belligerent.ttf", 32, Color::RGB(220, 220, 220)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/views/main_menu.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(phi: &mut Phi, label: &'static str, func: Box ViewAction>) -> Action { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | hover_sprite: phi.ttf_str_sprite(label, "assets/belligerent.ttf", 38, Color::RGB(255, 255, 0)).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arcade-rs` (bin "arcade-rs" test) due to 11 previous errors; 20 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `arcade-rs` (bin "arcade-rs") due to 11 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c18e95ae704568a47445ef258c432907e63afbb10abf12b2841fe5ba5bcd72c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c18e95ae704568a47445ef258c432907e63afbb10abf12b2841fe5ba5bcd72c7", kill_on_drop: false }` [INFO] [stdout] c18e95ae704568a47445ef258c432907e63afbb10abf12b2841fe5ba5bcd72c7