[INFO] updating cached repository https://github.com/adrianN/marc21 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4a1126c382f7baec0dd67ad35d0fc53c9edfa724 [INFO] checking adrianN/marc21/4a1126c382f7baec0dd67ad35d0fc53c9edfa724 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FadrianN%2Fmarc21" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adrianN/marc21 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adrianN/marc21 [INFO] finished tweaking git repo https://github.com/adrianN/marc21 [INFO] tweaked toml for git repo https://github.com/adrianN/marc21 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adrianN/marc21 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 921cdaa53e1f7b636d393d885e51aabd83b525219e61f9729b5bdf2bd873e198 [INFO] running `Command { std: "docker" "start" "-a" "921cdaa53e1f7b636d393d885e51aabd83b525219e61f9729b5bdf2bd873e198", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "921cdaa53e1f7b636d393d885e51aabd83b525219e61f9729b5bdf2bd873e198", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "921cdaa53e1f7b636d393d885e51aabd83b525219e61f9729b5bdf2bd873e198", kill_on_drop: false }` [INFO] [stdout] 921cdaa53e1f7b636d393d885e51aabd83b525219e61f9729b5bdf2bd873e198 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 118a958248ece93bb320103405564f81dee30054c54fa474b7083f802e2456eb [INFO] running `Command { std: "docker" "start" "-a" "118a958248ece93bb320103405564f81dee30054c54fa474b7083f802e2456eb", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking marc21 v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `filter` should have an upper camel case name [INFO] [stdout] --> src/filter.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | filter(Box), [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Filter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `field_ref` should have an upper camel case name [INFO] [stdout] --> src/filter.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | field_ref(Box), [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `FieldRef` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lexer::*` [INFO] [stdout] --> src/lexer.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | use crate::lexer::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::parser::*` [INFO] [stdout] --> src/exprparse.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | use crate::parser::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `filter` should have an upper camel case name [INFO] [stdout] --> src/filter.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | filter(Box), [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Filter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `field_ref` should have an upper camel case name [INFO] [stdout] --> src/filter.rs:220:5 [INFO] [stdout] | [INFO] [stdout] 220 | field_ref(Box), [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `FieldRef` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::record::*` [INFO] [stdout] --> src/ownedrecord.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | use crate::record::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `print_record` [INFO] [stdout] --> src/main.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | use crate::{print_record, run_sql}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `field_type` [INFO] [stdout] --> src/parsedrecord.rs:218:30 [INFO] [stdout] | [INFO] [stdout] 218 | fn field_iter_vec(&self, field_type: &[usize]) -> Box + '_> { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_field_type` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | Some((context, LexItem::Punctuation(Punctuation::Comma))) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:103:31 [INFO] [stdout] | [INFO] [stdout] 103 | Some((context, LexItem::KW(Keyword::FromKW))) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:125:26 [INFO] [stdout] | [INFO] [stdout] 125 | if let Some((context, LexItem::KW(Keyword::Where))) = input.get(next_offset) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut compile_result = compiler::compile(sql_text)?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 39 | let reader = File::open(format!("{}.mrc", table_name))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(MarcReader::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler.rs:193:8 [INFO] [stdout] | [INFO] [stdout] 189 | let mut visitor = TranslationVisitor::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(CompilationResult { [INFO] [stdout] | ________^ [INFO] [stdout] 194 | | projection: Projection::new(visitor.projection_exprs), [INFO] [stdout] 195 | | filter_expr: visitor.filter_exprs.pop(), [INFO] [stdout] 196 | | table_name: visitor.table_name, [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_NOT` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn parse_NOT<'a>( [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `parse_not` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_TERM` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:132:4 [INFO] [stdout] | [INFO] [stdout] 132 | fn parse_TERM<'a>( [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `parse_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_COLUMN_EXPR` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:172:4 [INFO] [stdout] | [INFO] [stdout] 172 | fn parse_COLUMN_EXPR<'a>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_column_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_OR` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:191:8 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn parse_OR<'a>( [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `parse_or` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(field_expr: Box, regex: &str) -> RegexFilter { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | regex: Regex::new(regex).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_SELECT` should have a snake case name [INFO] [stdout] --> src/parser.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | fn parse_SELECT<'a>( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_select` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `marc21` (bin "marc21") due to 7 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filter.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | let mut filter = TestFilter { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `field_type` [INFO] [stdout] --> src/parsedrecord.rs:218:30 [INFO] [stdout] | [INFO] [stdout] 218 | fn field_iter_vec(&self, field_type: &[usize]) -> Box + '_> { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_field_type` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:100:31 [INFO] [stdout] | [INFO] [stdout] 100 | Some((context, LexItem::Punctuation(Punctuation::Comma))) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:103:31 [INFO] [stdout] | [INFO] [stdout] 103 | Some((context, LexItem::KW(Keyword::FromKW))) => { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `context` [INFO] [stdout] --> src/parser.rs:125:26 [INFO] [stdout] | [INFO] [stdout] 125 | if let Some((context, LexItem::KW(Keyword::Where))) = input.get(next_offset) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_context` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut compile_result = compiler::compile(sql_text)?; [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 39 | let reader = File::open(format!("{}.mrc", table_name))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(MarcReader::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler.rs:193:8 [INFO] [stdout] | [INFO] [stdout] 189 | let mut visitor = TranslationVisitor::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(CompilationResult { [INFO] [stdout] | ________^ [INFO] [stdout] 194 | | projection: Projection::new(visitor.projection_exprs), [INFO] [stdout] 195 | | filter_expr: visitor.filter_exprs.pop(), [INFO] [stdout] 196 | | table_name: visitor.table_name, [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_NOT` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn parse_NOT<'a>( [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `parse_not` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_TERM` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:132:4 [INFO] [stdout] | [INFO] [stdout] 132 | fn parse_TERM<'a>( [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `parse_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_COLUMN_EXPR` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:172:4 [INFO] [stdout] | [INFO] [stdout] 172 | fn parse_COLUMN_EXPR<'a>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_column_expr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_OR` should have a snake case name [INFO] [stdout] --> src/exprparse.rs:191:8 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn parse_OR<'a>( [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `parse_or` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(field_expr: Box, regex: &str) -> RegexFilter { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | regex: Regex::new(regex).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | .map(|x| Regex::new(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `str` should have an upper case name [INFO] [stdout] --> src/parsedrecord.rs:266:12 [INFO] [stdout] | [INFO] [stdout] 266 | static str : &[u8]= "00827nz a2200241nc 4500\ [INFO] [stdout] | ^^^ help: convert the identifier to upper case: `STR` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_SELECT` should have a snake case name [INFO] [stdout] --> src/parser.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | fn parse_SELECT<'a>( [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `parse_select` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | let breader = BufReader::new(c); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(MarcReader::new(breader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:318:55 [INFO] [stdout] | [INFO] [stdout] 318 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:332:55 [INFO] [stdout] | [INFO] [stdout] 332 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:346:55 [INFO] [stdout] | [INFO] [stdout] 346 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:364:55 [INFO] [stdout] | [INFO] [stdout] 364 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:382:55 [INFO] [stdout] | [INFO] [stdout] 382 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:400:55 [INFO] [stdout] | [INFO] [stdout] 400 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:418:55 [INFO] [stdout] | [INFO] [stdout] 418 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:436:55 [INFO] [stdout] | [INFO] [stdout] 436 | let num_fields: Vec = v.iter().map(|x| x.field_iter(None).count()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `marc21` (bin "marc21" test) due to 16 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "118a958248ece93bb320103405564f81dee30054c54fa474b7083f802e2456eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "118a958248ece93bb320103405564f81dee30054c54fa474b7083f802e2456eb", kill_on_drop: false }` [INFO] [stdout] 118a958248ece93bb320103405564f81dee30054c54fa474b7083f802e2456eb