[INFO] cloning repository https://github.com/adihodos/rust-opengl-particle-simulation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adihodos/rust-opengl-particle-simulation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9334b43e04aeb3eb7ae8d4598e393f521830ce14 [INFO] checking adihodos/rust-opengl-particle-simulation/9334b43e04aeb3eb7ae8d4598e393f521830ce14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadihodos%2Frust-opengl-particle-simulation" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adihodos/rust-opengl-particle-simulation on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adihodos/rust-opengl-particle-simulation [INFO] finished tweaking git repo https://github.com/adihodos/rust-opengl-particle-simulation [INFO] tweaked toml for git repo https://github.com/adihodos/rust-opengl-particle-simulation written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adihodos/rust-opengl-particle-simulation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5dd3e3d31e5039011e408e47aca41bd131cec7333afae6b145d52ab80121d85 [INFO] running `Command { std: "docker" "start" "-a" "b5dd3e3d31e5039011e408e47aca41bd131cec7333afae6b145d52ab80121d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5dd3e3d31e5039011e408e47aca41bd131cec7333afae6b145d52ab80121d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5dd3e3d31e5039011e408e47aca41bd131cec7333afae6b145d52ab80121d85", kill_on_drop: false }` [INFO] [stdout] b5dd3e3d31e5039011e408e47aca41bd131cec7333afae6b145d52ab80121d85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e4b361698a1eb5f7da0a72a0c097eeb975b047c6093887580c4ace0cb57dbf2 [INFO] running `Command { std: "docker" "start" "-a" "6e4b361698a1eb5f7da0a72a0c097eeb975b047c6093887580c4ace0cb57dbf2", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling x11 v2.18.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking deflate v0.8.3 [INFO] [stderr] Compiling gl_loader v0.1.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking png v0.16.0 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking math v0.1.0 (/opt/rustwide/workdir/math) [INFO] [stderr] Checking sys v0.1.0 (/opt/rustwide/workdir/sys) [INFO] [stdout] warning: unused import: `GLXDrawable` [INFO] [stdout] --> sys/src/window_x11.rs:15:50 [INFO] [stdout] | [INFO] [stdout] 15 | glXQueryVersion, glXSwapBuffers, GLXContext, GLXDrawable, GLXFBConfig, GLX_BUFFER_SIZE, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AlreadyGrabbed`, `Button5`, `FocusIn`, `FocusOut`, `GrabFrozen`, `GrabInvalidTime`, `GrabModeAsync`, `GrabNotViewable`, `PropModeReplace`, `Screen`, `XA_ATOM`, `XChangeProperty`, `XFocusChangeEvent`, `XGrabKeyboard`, `XQueryPointer`, `XSync`, `XUngrabKeyboard`, and `XWarpPointer` [INFO] [stdout] --> sys/src/window_x11.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | AllocNone, AlreadyGrabbed, Atom, Bool, Button1, Button1Mask, Button2, Button2Mask, Button3, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | Button3Mask, Button4, Button4Mask, Button5, Button5Mask, ButtonPress, ButtonPressMask, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | ExposureMask, False, FocusChangeMask, FocusIn, FocusOut, GrabFrozen, GrabInvalidTime, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | GrabModeAsync, GrabNotViewable, InputHint, InputOutput, KeyPress, KeyPressMask, KeyRelease, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 29 | KeyReleaseMask, KeySym, LeaveWindowMask, MotionNotify, NoSymbol, PBaseSize, PMinSize, [INFO] [stdout] 30 | PointerMotionMask, PropModeReplace, RevertToNone, Screen, ShiftMask, StateHint, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | XAllocWMHints, XButtonEvent, XChangeProperty, XClearWindow, XClientMessageEvent, XCloseDisplay, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 34 | XConfigureEvent, XCreateColormap, XCreateWindow, XDefaultRootWindow, XDefaultScreen, [INFO] [stdout] 35 | XDestroyWindow, XEvent, XEventsQueued, XFlush, XFocusChangeEvent, XFree, XGetGeometry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | XGrabKeyboard, XInternAtom, XKeyEvent, XLookupString, XMapRaised, XMotionEvent, XMoveWindow, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | XNextEvent, XOpenDisplay, XQueryPointer, XRootWindow, XSendEvent, XSetInputFocus, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 38 | XSetWMProperties, XSetWMProtocols, XSetWindowAttributes, XSizeHints, XSync, XUngrabKeyboard, [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | XVisibilityEvent, XVisualInfo, XWMHints, XWarpPointer, XWhitePixel, XA_ATOM, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GLXDrawable` [INFO] [stdout] --> sys/src/window_x11.rs:15:50 [INFO] [stdout] | [INFO] [stdout] 15 | glXQueryVersion, glXSwapBuffers, GLXContext, GLXDrawable, GLXFBConfig, GLX_BUFFER_SIZE, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AlreadyGrabbed`, `Button5`, `FocusIn`, `FocusOut`, `GrabFrozen`, `GrabInvalidTime`, `GrabModeAsync`, `GrabNotViewable`, `PropModeReplace`, `Screen`, `XA_ATOM`, `XChangeProperty`, `XFocusChangeEvent`, `XGrabKeyboard`, `XQueryPointer`, `XSync`, `XUngrabKeyboard`, and `XWarpPointer` [INFO] [stdout] --> sys/src/window_x11.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | AllocNone, AlreadyGrabbed, Atom, Bool, Button1, Button1Mask, Button2, Button2Mask, Button3, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | Button3Mask, Button4, Button4Mask, Button5, Button5Mask, ButtonPress, ButtonPressMask, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | ExposureMask, False, FocusChangeMask, FocusIn, FocusOut, GrabFrozen, GrabInvalidTime, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | GrabModeAsync, GrabNotViewable, InputHint, InputOutput, KeyPress, KeyPressMask, KeyRelease, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 29 | KeyReleaseMask, KeySym, LeaveWindowMask, MotionNotify, NoSymbol, PBaseSize, PMinSize, [INFO] [stdout] 30 | PointerMotionMask, PropModeReplace, RevertToNone, Screen, ShiftMask, StateHint, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | XAllocWMHints, XButtonEvent, XChangeProperty, XClearWindow, XClientMessageEvent, XCloseDisplay, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 34 | XConfigureEvent, XCreateColormap, XCreateWindow, XDefaultRootWindow, XDefaultScreen, [INFO] [stdout] 35 | XDestroyWindow, XEvent, XEventsQueued, XFlush, XFocusChangeEvent, XFree, XGetGeometry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 36 | XGrabKeyboard, XInternAtom, XKeyEvent, XLookupString, XMapRaised, XMotionEvent, XMoveWindow, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | XNextEvent, XOpenDisplay, XQueryPointer, XRootWindow, XSendEvent, XSetInputFocus, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 38 | XSetWMProperties, XSetWMProtocols, XSetWindowAttributes, XSizeHints, XSync, XUngrabKeyboard, [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | XVisibilityEvent, XVisualInfo, XWMHints, XWarpPointer, XWhitePixel, XA_ATOM, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/window_x11.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 135 | let (xvisual, fbcfg) = platform_utils::get_suitable_xvisual(dpy)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(SimpleWindow { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | event_receiver: None, [INFO] [stdout] 201 | | glcontext, [INFO] [stdout] 202 | | window, [INFO] [stdout] ... | [INFO] [stdout] 206 | | win_size: std::cell::Cell::new(size), [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/window_x11.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 563 | let supported_cfgs = ScopedGLXFBConfig::new(unsafe { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | / (0..supported_cfgs_count) [INFO] [stdout] 574 | | .find_map(|idx| { [INFO] [stdout] 575 | | let cfg = unsafe { *(*supported_cfgs).offset(idx as isize) }; [INFO] [stdout] 576 | | ScopedXVisualInfo::new(unsafe { glXGetVisualFromFBConfig(dpy, cfg) }) [INFO] [stdout] 577 | | .map(|vi| (vi, cfg)) [INFO] [stdout] 578 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | / path.as_ref() [INFO] [stdout] 156 | | .to_str() [INFO] [stdout] 157 | | .ok_or(Error::new( [INFO] [stdout] 158 | | ErrorKind::InvalidData, [INFO] [stdout] 159 | | "failed to convert path to string", [INFO] [stdout] 160 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 168 | .and_then(|cstr_path| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | / UniqueOSFileDescriptor::new(unsafe { [INFO] [stdout] 172 | | open(cstr_path.as_c_str().as_ptr(), O_RDONLY) [INFO] [stdout] 173 | | }) [INFO] [stdout] 174 | | .ok_or(Error::last_os_error()) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:178:29 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | / UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 | | unsafe { [INFO] [stdout] 180 | | mmap( [INFO] [stdout] 181 | | null_mut(), [INFO] [stdout] ... | [INFO] [stdout] 190 | | ) [INFO] [stdout] 191 | | .ok_or(Error::last_os_error()) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:192:39 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | .and_then(|ummap| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 193 | | Ok(MemoryMappedFile { [INFO] [stdout] 194 | | memory: ummap, [INFO] [stdout] 195 | | file_handle: ufd, [INFO] [stdout] 196 | | bytes: metadata.len() as usize, [INFO] [stdout] 197 | | }) [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:193:36 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | .and_then(|ummap| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(MemoryMappedFile { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 194 | | memory: ummap, [INFO] [stdout] 195 | | file_handle: ufd, [INFO] [stdout] 196 | | bytes: metadata.len() as usize, [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sys` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/window_x11.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 135 | let (xvisual, fbcfg) = platform_utils::get_suitable_xvisual(dpy)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Ok(SimpleWindow { [INFO] [stdout] | ____________^ [INFO] [stdout] 200 | | event_receiver: None, [INFO] [stdout] 201 | | glcontext, [INFO] [stdout] 202 | | window, [INFO] [stdout] ... | [INFO] [stdout] 206 | | win_size: std::cell::Cell::new(size), [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/window_x11.rs:573:9 [INFO] [stdout] | [INFO] [stdout] 563 | let supported_cfgs = ScopedGLXFBConfig::new(unsafe { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 573 | / (0..supported_cfgs_count) [INFO] [stdout] 574 | | .find_map(|idx| { [INFO] [stdout] 575 | | let cfg = unsafe { *(*supported_cfgs).offset(idx as isize) }; [INFO] [stdout] 576 | | ScopedXVisualInfo::new(unsafe { glXGetVisualFromFBConfig(dpy, cfg) }) [INFO] [stdout] 577 | | .map(|vi| (vi, cfg)) [INFO] [stdout] 578 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | / path.as_ref() [INFO] [stdout] 156 | | .to_str() [INFO] [stdout] 157 | | .ok_or(Error::new( [INFO] [stdout] 158 | | ErrorKind::InvalidData, [INFO] [stdout] 159 | | "failed to convert path to string", [INFO] [stdout] 160 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:171:25 [INFO] [stdout] | [INFO] [stdout] 168 | .and_then(|cstr_path| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | / UniqueOSFileDescriptor::new(unsafe { [INFO] [stdout] 172 | | open(cstr_path.as_c_str().as_ptr(), O_RDONLY) [INFO] [stdout] 173 | | }) [INFO] [stdout] 174 | | .ok_or(Error::last_os_error()) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:178:29 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | / UniqueMappedMemoryHandle::new_with_deleter( [INFO] [stdout] 179 | | unsafe { [INFO] [stdout] 180 | | mmap( [INFO] [stdout] 181 | | null_mut(), [INFO] [stdout] ... | [INFO] [stdout] 190 | | ) [INFO] [stdout] 191 | | .ok_or(Error::last_os_error()) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:192:39 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | .and_then(|ummap| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 193 | | Ok(MemoryMappedFile { [INFO] [stdout] 194 | | memory: ummap, [INFO] [stdout] 195 | | file_handle: ufd, [INFO] [stdout] 196 | | bytes: metadata.len() as usize, [INFO] [stdout] 197 | | }) [INFO] [stdout] 198 | | }) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sys/src/memory_mapped_file.rs:193:36 [INFO] [stdout] | [INFO] [stdout] 175 | .and_then(|ufd| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | .and_then(|ummap| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(MemoryMappedFile { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 194 | | memory: ummap, [INFO] [stdout] 195 | | file_handle: ufd, [INFO] [stdout] 196 | | bytes: metadata.len() as usize, [INFO] [stdout] 197 | | }) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sys` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6e4b361698a1eb5f7da0a72a0c097eeb975b047c6093887580c4ace0cb57dbf2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e4b361698a1eb5f7da0a72a0c097eeb975b047c6093887580c4ace0cb57dbf2", kill_on_drop: false }` [INFO] [stdout] 6e4b361698a1eb5f7da0a72a0c097eeb975b047c6093887580c4ace0cb57dbf2