[INFO] cloning repository https://github.com/adamsoutar/ass [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamsoutar/ass" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamsoutar%2Fass", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamsoutar%2Fass'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9547e412845227d0e2ba31e3f48e4c0e4c7490bd [INFO] checking adamsoutar/ass/9547e412845227d0e2ba31e3f48e4c0e4c7490bd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadamsoutar%2Fass" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adamsoutar/ass on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adamsoutar/ass [INFO] finished tweaking git repo https://github.com/adamsoutar/ass [INFO] tweaked toml for git repo https://github.com/adamsoutar/ass written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adamsoutar/ass already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbc17b3fc1073d3295cda08574115bcf49a4bb2bbd0b76a34dd1c051019d581c [INFO] running `Command { std: "docker" "start" "-a" "cbc17b3fc1073d3295cda08574115bcf49a4bb2bbd0b76a34dd1c051019d581c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbc17b3fc1073d3295cda08574115bcf49a4bb2bbd0b76a34dd1c051019d581c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbc17b3fc1073d3295cda08574115bcf49a4bb2bbd0b76a34dd1c051019d581c", kill_on_drop: false }` [INFO] [stdout] cbc17b3fc1073d3295cda08574115bcf49a4bb2bbd0b76a34dd1c051019d581c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11af99cfd49e45ca146b84070b0d3b79e7665f12c77fbd35ae55fab8d55f4e4d [INFO] running `Command { std: "docker" "start" "-a" "11af99cfd49e45ca146b84070b0d3b79e7665f12c77fbd35ae55fab8d55f4e4d", kill_on_drop: false }` [INFO] [stderr] Checking ass v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `is_builtin_type_modifier` is never used [INFO] [stdout] --> src/parser/tokens.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn is_builtin_type_modifier(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `size_in_bytes` is never used [INFO] [stdout] --> src/parser/types.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn size_in_bytes (the_type: &Type) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block_depth` is never read [INFO] [stdout] --> src/codegen/codegen.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Codegen { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | pub block_depth: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 61 | fn maybe_call (&mut self, me: ASTNode) -> (bool, ASTNode) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let mut args = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | (true, ASTNode::FunctionCall(ASTFunctionCall { [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | name: func_name, [INFO] [stdout] 89 | | args [INFO] [stdout] 90 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:170:33 [INFO] [stdout] | [INFO] [stdout] 169 | let operand = self.parse_atom(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ASTNode::UnaryOperation(ASTUnaryOperation { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 171 | | operator: oper, [INFO] [stdout] 172 | | operand: Box::new(operand) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 196 | let condition = Box::new(self.parse_component(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let mut else_stmt = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | ASTNode::IfStatement(ASTIfStatement { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 210 | | condition, [INFO] [stdout] 211 | | body, [INFO] [stdout] 212 | | else_stmt [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:223:28 [INFO] [stdout] | [INFO] [stdout] 219 | let condition = Box::new(self.parse_component(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | self.expect_punctuation(')'); [INFO] [stdout] 221 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | [INFO] [stdout] 223 | ASTNode::WhileLoop(ASTWhileLoop { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 224 | | condition, [INFO] [stdout] 225 | | body [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:252:26 [INFO] [stdout] | [INFO] [stdout] 233 | let mut declaration = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let mut condition = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let mut modification = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | [INFO] [stdout] 252 | ASTNode::ForLoop(ASTForLoop { [INFO] [stdout] | __________________________^ [INFO] [stdout] 253 | | declaration, [INFO] [stdout] 254 | | condition, [INFO] [stdout] 255 | | modification, [INFO] [stdout] 256 | | body [INFO] [stdout] 257 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:263:34 [INFO] [stdout] | [INFO] [stdout] 261 | let ret_val = self.parse_component(0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | // self.expect_punctuation(';'); [INFO] [stdout] 263 | ASTNode::ReturnStatement(Box::new(ret_val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ass` (bin "ass") due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `is_builtin_type_modifier` is never used [INFO] [stdout] --> src/parser/tokens.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn is_builtin_type_modifier(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `size_in_bytes` is never used [INFO] [stdout] --> src/parser/types.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn size_in_bytes (the_type: &Type) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `block_depth` is never read [INFO] [stdout] --> src/codegen/codegen.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Codegen { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | pub block_depth: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 61 | fn maybe_call (&mut self, me: ASTNode) -> (bool, ASTNode) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let mut args = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | (true, ASTNode::FunctionCall(ASTFunctionCall { [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | name: func_name, [INFO] [stdout] 89 | | args [INFO] [stdout] 90 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:170:33 [INFO] [stdout] | [INFO] [stdout] 169 | let operand = self.parse_atom(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ASTNode::UnaryOperation(ASTUnaryOperation { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 171 | | operator: oper, [INFO] [stdout] 172 | | operand: Box::new(operand) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 196 | let condition = Box::new(self.parse_component(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | [INFO] [stdout] 201 | let mut else_stmt = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | ASTNode::IfStatement(ASTIfStatement { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 210 | | condition, [INFO] [stdout] 211 | | body, [INFO] [stdout] 212 | | else_stmt [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:223:28 [INFO] [stdout] | [INFO] [stdout] 219 | let condition = Box::new(self.parse_component(0)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | self.expect_punctuation(')'); [INFO] [stdout] 221 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | [INFO] [stdout] 223 | ASTNode::WhileLoop(ASTWhileLoop { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 224 | | condition, [INFO] [stdout] 225 | | body [INFO] [stdout] 226 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:252:26 [INFO] [stdout] | [INFO] [stdout] 233 | let mut declaration = None; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let mut condition = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | let mut modification = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let body = Box::new(self.parse_component(0)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | [INFO] [stdout] 252 | ASTNode::ForLoop(ASTForLoop { [INFO] [stdout] | __________________________^ [INFO] [stdout] 253 | | declaration, [INFO] [stdout] 254 | | condition, [INFO] [stdout] 255 | | modification, [INFO] [stdout] 256 | | body [INFO] [stdout] 257 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/parser.rs:263:34 [INFO] [stdout] | [INFO] [stdout] 261 | let ret_val = self.parse_component(0); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | // self.expect_punctuation(';'); [INFO] [stdout] 263 | ASTNode::ReturnStatement(Box::new(ret_val)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ass` (bin "ass" test) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "11af99cfd49e45ca146b84070b0d3b79e7665f12c77fbd35ae55fab8d55f4e4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11af99cfd49e45ca146b84070b0d3b79e7665f12c77fbd35ae55fab8d55f4e4d", kill_on_drop: false }` [INFO] [stdout] 11af99cfd49e45ca146b84070b0d3b79e7665f12c77fbd35ae55fab8d55f4e4d