[INFO] cloning repository https://github.com/adamAndMath/traitlit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adamAndMath/traitlit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FadamAndMath%2Ftraitlit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FadamAndMath%2Ftraitlit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce4e93da4e58b7a3238d648fe3ac0732c2b4c94d [INFO] checking adamAndMath/traitlit/ce4e93da4e58b7a3238d648fe3ac0732c2b4c94d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FadamAndMath%2Ftraitlit" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adamAndMath/traitlit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adamAndMath/traitlit [INFO] finished tweaking git repo https://github.com/adamAndMath/traitlit [INFO] tweaked toml for git repo https://github.com/adamAndMath/traitlit written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adamAndMath/traitlit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.maintenance [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19f2b0811b1d4e20abbb01c7f9a95fb273dd33b793cc6016cbbb9c2432962516 [INFO] running `Command { std: "docker" "start" "-a" "19f2b0811b1d4e20abbb01c7f9a95fb273dd33b793cc6016cbbb9c2432962516", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19f2b0811b1d4e20abbb01c7f9a95fb273dd33b793cc6016cbbb9c2432962516", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19f2b0811b1d4e20abbb01c7f9a95fb273dd33b793cc6016cbbb9c2432962516", kill_on_drop: false }` [INFO] [stdout] 19f2b0811b1d4e20abbb01c7f9a95fb273dd33b793cc6016cbbb9c2432962516 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d422ecc619a62f52ade9bbe9af073be1d6e4f9fd28c0730e6768e5ee42022f7d [INFO] running `Command { std: "docker" "start" "-a" "d422ecc619a62f52ade9bbe9af073be1d6e4f9fd28c0730e6768e5ee42022f7d", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.maintenance [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling syn v0.15.37 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Checking quote v0.6.12 [INFO] [stderr] Checking traitlit v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/args.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | Set(Bracket, Punctuated, Token!(,)>) [INFO] [stdout] | --- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Set((), Punctuated, Token!(,)>) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:84 [INFO] [stdout] | [INFO] [stdout] 116 | params: gen.params.pairs_mut().map(Pair::into_tuple).map(|(t, p)|Pair::new(split_gen_par(t, v), p.cloned())).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:87:89 [INFO] [stdout] | [INFO] [stdout] 87 | ....map(|WithAttr(a, t)|WithAttr({let mut attrs = attrs.clone(); attrs.extend(a); attrs}, t)), [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:89:26 [INFO] [stdout] | [INFO] [stdout] 89 | WithAttr(attrs.clone(), Type::Path(TypePath { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | WithAttr(attrs.clone(), Type::Path(TypePath { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 90 | | qself: None, [INFO] [stdout] 91 | | path: Path { [INFO] [stdout] 92 | | leading_colon: None, [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:94:50 [INFO] [stdout] | [INFO] [stdout] 94 | ... .map(|name|Pair::new(PathSegment { ident: Ident::new(name, *span), arguments: PathArguments::None }, Some(Token!(::)(*span)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/args.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | Set(Bracket, Punctuated, Token!(,)>) [INFO] [stdout] | --- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | Set((), Punctuated, Token!(,)>) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:84 [INFO] [stdout] | [INFO] [stdout] 116 | params: gen.params.pairs_mut().map(Pair::into_tuple).map(|(t, p)|Pair::new(split_gen_par(t, v), p.cloned())).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:87:89 [INFO] [stdout] | [INFO] [stdout] 87 | ....map(|WithAttr(a, t)|WithAttr({let mut attrs = attrs.clone(); attrs.extend(a); attrs}, t)), [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:89:26 [INFO] [stdout] | [INFO] [stdout] 89 | WithAttr(attrs.clone(), Type::Path(TypePath { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | WithAttr(attrs.clone(), Type::Path(TypePath { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 90 | | qself: None, [INFO] [stdout] 91 | | path: Path { [INFO] [stdout] 92 | | leading_colon: None, [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | })) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:94:50 [INFO] [stdout] | [INFO] [stdout] 94 | ... .map(|name|Pair::new(PathSegment { ident: Ident::new(name, *span), arguments: PathArguments::None }, Some(Token!(::)(*span)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `traitlit` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `traitlit` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d422ecc619a62f52ade9bbe9af073be1d6e4f9fd28c0730e6768e5ee42022f7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d422ecc619a62f52ade9bbe9af073be1d6e4f9fd28c0730e6768e5ee42022f7d", kill_on_drop: false }` [INFO] [stdout] d422ecc619a62f52ade9bbe9af073be1d6e4f9fd28c0730e6768e5ee42022f7d