[INFO] cloning repository https://github.com/adam-jw-casey/sniper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/adam-jw-casey/sniper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadam-jw-casey%2Fsniper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadam-jw-casey%2Fsniper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2adce67ff5f89cb24de69c2a02012b3a8a99e973 [INFO] checking adam-jw-casey/sniper/2adce67ff5f89cb24de69c2a02012b3a8a99e973 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fadam-jw-casey%2Fsniper" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/adam-jw-casey/sniper on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/adam-jw-casey/sniper [INFO] finished tweaking git repo https://github.com/adam-jw-casey/sniper [INFO] tweaked toml for git repo https://github.com/adam-jw-casey/sniper written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/adam-jw-casey/sniper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c774433187eeac18a229f5c2547c17d17b7e7af21ceb616fc1cf2f9c9ce6b37e [INFO] running `Command { std: "docker" "start" "-a" "c774433187eeac18a229f5c2547c17d17b7e7af21ceb616fc1cf2f9c9ce6b37e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c774433187eeac18a229f5c2547c17d17b7e7af21ceb616fc1cf2f9c9ce6b37e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c774433187eeac18a229f5c2547c17d17b7e7af21ceb616fc1cf2f9c9ce6b37e", kill_on_drop: false }` [INFO] [stdout] c774433187eeac18a229f5c2547c17d17b7e7af21ceb616fc1cf2f9c9ce6b37e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 36362f351906a5e761795d36f808d7ad1a907530ec8b58e0623726ae27b1b4f9 [INFO] running `Command { std: "docker" "start" "-a" "36362f351906a5e761795d36f808d7ad1a907530ec8b58e0623726ae27b1b4f9", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking lru v0.12.2 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Checking opener v0.6.1 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ratatui v0.26.0 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking ratatelm v0.1.0 (/opt/rustwide/workdir/ratatelm) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/lib.rs:116:46 [INFO] [stdout] | [INFO] [stdout] 116 | .unwrap_or_else(|e| Some(Self::on_err(e.to_string()))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/widgets/list.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | || Some(EventOrMessage::Message(on_err("No item selected".into()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/widgets/list.rs:97:38 [INFO] [stdout] | [INFO] [stdout] 97 | |index| Some(EventOrMessage::Message(select(self.elems[index].clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratatelm` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/lib.rs:116:46 [INFO] [stdout] | [INFO] [stdout] 116 | .unwrap_or_else(|e| Some(Self::on_err(e.to_string()))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/widgets/list.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | || Some(EventOrMessage::Message(on_err("No item selected".into()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ratatelm/src/widgets/list.rs:97:38 [INFO] [stdout] | [INFO] [stdout] 97 | |index| Some(EventOrMessage::Message(select(self.elems[index].clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratatelm` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "36362f351906a5e761795d36f808d7ad1a907530ec8b58e0623726ae27b1b4f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36362f351906a5e761795d36f808d7ad1a907530ec8b58e0623726ae27b1b4f9", kill_on_drop: false }` [INFO] [stdout] 36362f351906a5e761795d36f808d7ad1a907530ec8b58e0623726ae27b1b4f9