[INFO] cloning repository https://github.com/ackintosh/pbft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ackintosh/pbft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fackintosh%2Fpbft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fackintosh%2Fpbft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 709d5280cc8d820959a89995da1077702e5cdda1 [INFO] checking ackintosh/pbft/709d5280cc8d820959a89995da1077702e5cdda1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fackintosh%2Fpbft" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ackintosh/pbft on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ackintosh/pbft [INFO] finished tweaking git repo https://github.com/ackintosh/pbft [INFO] tweaked toml for git repo https://github.com/ackintosh/pbft written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ackintosh/pbft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f23e51fa4a5a64a2ac518c7314a2e538c9fbcd6ad3beae08c33ccf73fbae29db [INFO] running `Command { std: "docker" "start" "-a" "f23e51fa4a5a64a2ac518c7314a2e538c9fbcd6ad3beae08c33ccf73fbae29db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f23e51fa4a5a64a2ac518c7314a2e538c9fbcd6ad3beae08c33ccf73fbae29db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f23e51fa4a5a64a2ac518c7314a2e538c9fbcd6ad3beae08c33ccf73fbae29db", kill_on_drop: false }` [INFO] [stdout] f23e51fa4a5a64a2ac518c7314a2e538c9fbcd6ad3beae08c33ccf73fbae29db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ce9a46177b19b6340379e876152c220044ae7a3b905a15210841ef2916b4edd [INFO] running `Command { std: "docker" "start" "-a" "1ce9a46177b19b6340379e876152c220044ae7a3b905a15210841ef2916b4edd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.0 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking subtle v2.2.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling serde v1.0.103 [INFO] [stderr] Checking smallvec v1.0.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking unicode-normalization v0.1.11 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Compiling protobuf v2.8.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking bs58 v0.3.0 [INFO] [stderr] Checking data-encoding v2.1.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling ring v0.16.9 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking tokio-executor v0.1.9 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.55 [INFO] [stderr] Checking tokio-timer v0.2.12 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking curve25519-dalek v2.0.0 [INFO] [stderr] Compiling bumpalo v2.6.0 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking blake2 v0.8.1 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking sha3 v0.8.2 [INFO] [stderr] Checking hmac-drbg v0.2.0 [INFO] [stderr] Checking wasm-timer v0.1.3 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking libsecp256k1 v0.3.2 [INFO] [stderr] Checking rw-stream-sink v0.1.2 [INFO] [stderr] Checking tokio-reactor v0.1.11 [INFO] [stderr] Checking unsigned-varint v0.2.3 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking parity-multihash v0.2.0 [INFO] [stderr] Checking multistream-select v0.6.1 [INFO] [stderr] Checking url v2.1.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking ed25519-dalek v1.0.0-pre.3 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling wasm-bindgen v0.2.55 [INFO] [stderr] Checking backtrace v0.3.40 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Checking miniz_oxide v0.3.5 [INFO] [stderr] Checking tokio-udp v0.1.5 [INFO] [stderr] Checking tokio-threadpool v0.1.17 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Compiling parking_lot_core v0.5.0 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling curve25519-dalek v1.2.3 [INFO] [stderr] Checking stream-cipher v0.3.2 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling parking_lot v0.8.0 [INFO] [stderr] Compiling snow v0.6.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking ctr v0.3.2 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking aes-soft v0.3.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-fs v0.1.6 [INFO] [stderr] Checking lock_api v0.2.0 [INFO] [stderr] Checking flate2 v1.0.13 [INFO] [stderr] Checking rustc-hex v2.0.1 [INFO] [stderr] Checking nohash-hasher v0.1.2 [INFO] [stderr] Checking c_linked_list v1.1.1 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking uint v0.8.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking yamux v0.2.2 [INFO] [stderr] Checking aes-ctr v0.3.0 [INFO] [stderr] Checking cuckoofilter v0.3.2 [INFO] [stderr] Checking twofish v0.2.0 [INFO] [stderr] Checking tokio-dns-unofficial v0.4.0 [INFO] [stderr] Checking dns-parser v0.8.0 [INFO] [stderr] Checking ipnet v2.1.0 [INFO] [stderr] Checking parity-send-wrapper v0.1.0 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking x25519-dalek v0.5.2 [INFO] [stderr] Checking webpki v0.21.0 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking soketto v0.2.3 [INFO] [stderr] Checking rustls v0.16.0 [INFO] [stderr] Checking webpki-roots v0.18.0 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.55 [INFO] [stderr] Compiling libp2p-core-derive v0.13.0 [INFO] [stderr] Compiling serde_derive v1.0.103 [INFO] [stderr] Compiling asn1_der_derive v0.1.2 [INFO] [stderr] Checking asn1_der v0.6.3 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking tokio-rustls v0.10.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.55 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.55 [INFO] [stderr] Checking js-sys v0.3.32 [INFO] [stderr] Checking wasm-bindgen-futures v0.3.27 [INFO] [stderr] Checking parity-multiaddr v0.6.0 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking libp2p-core v0.13.1 [INFO] [stderr] Checking libp2p-swarm v0.3.0 [INFO] [stderr] Checking libp2p-uds v0.13.0 [INFO] [stderr] Checking libp2p-dns v0.13.0 [INFO] [stderr] Checking libp2p-secio v0.13.0 [INFO] [stderr] Checking libp2p-mplex v0.13.0 [INFO] [stderr] Checking libp2p-deflate v0.5.0 [INFO] [stderr] Checking libp2p-noise v0.11.0 [INFO] [stderr] Checking libp2p-yamux v0.13.0 [INFO] [stderr] Checking libp2p-tcp v0.13.0 [INFO] [stderr] Checking libp2p-websocket v0.13.0 [INFO] [stderr] Checking libp2p-plaintext v0.13.0 [INFO] [stderr] Checking libp2p-wasm-ext v0.6.0 [INFO] [stderr] Checking libp2p-kad v0.13.1 [INFO] [stderr] Checking libp2p-mdns v0.13.1 [INFO] [stderr] Checking libp2p-ping v0.13.1 [INFO] [stderr] Checking libp2p-floodsub v0.13.0 [INFO] [stderr] Checking libp2p-identify v0.13.1 [INFO] [stderr] Checking libp2p v0.13.1 [INFO] [stderr] Checking pbft v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | panic!(format!("[main::determine_node_type] Invalid node_type: {:?}", node_type)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 86 - panic!(format!("[main::determine_node_type] Invalid node_type: {:?}", node_type)); [INFO] [stdout] 86 + panic!("[main::determine_node_type] Invalid node_type: {:?}", node_type); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 19 | client_requests: Arc>>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let listener = TcpListener::bind(address).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | stream_states: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 103 | fn read_client_stream(&self, mut tcp_stream: TcpStream) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let mut buffer = [0u8; 512]; [INFO] [stdout] 105 | match tcp_stream.read(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | addresses: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | connected_peers: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | queued_events: VecDeque::with_capacity(100), // FIXME [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | state: State::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_config.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 44 | socket: Negotiated, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | / Framed::new(socket, codec) [INFO] [stdout] 53 | | .from_err() [INFO] [stdout] 54 | | .with::<_, fn(_) -> _, _>(|response| { [INFO] [stdout] 55 | | println!("[PbftProtocolConfig::upgrade_inbound] [with] response: {:?}", response); [INFO] [stdout] ... | [INFO] [stdout] 60 | | Ok(bytes_to_message(&bytes)) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_config.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 76 | socket: Negotiated, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / Framed::new(socket, codec) [INFO] [stdout] 85 | | .from_err() [INFO] [stdout] 86 | | .with::<_, fn(_) -> _, _>(|outbound_message| { [INFO] [stdout] 87 | | println!("[PbftProtocolConfig::upgrade_outbound] [with] outbound_message : {:?}", outbound_message); [INFO] [stdout] ... | [INFO] [stdout] 92 | | Ok(bytes.to_vec()) [INFO] [stdout] 93 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbft` (bin "pbft" test) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | panic!(format!("[main::determine_node_type] Invalid node_type: {:?}", node_type)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 86 - panic!(format!("[main::determine_node_type] Invalid node_type: {:?}", node_type)); [INFO] [stdout] 86 + panic!("[main::determine_node_type] Invalid node_type: {:?}", node_type); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:37:28 [INFO] [stdout] | [INFO] [stdout] 19 | client_requests: Arc>>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let listener = TcpListener::bind(address).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | stream_states: VecDeque::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_handler.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 103 | fn read_client_stream(&self, mut tcp_stream: TcpStream) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let mut buffer = [0u8; 512]; [INFO] [stdout] 105 | match tcp_stream.read(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | addresses: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | connected_peers: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | queued_events: VecDeque::with_capacity(100), // FIXME [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/behavior.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 27 | keypair: Keypair, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | client_replies: Arc>>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | state: State::new(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_config.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 44 | socket: Negotiated, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | / Framed::new(socket, codec) [INFO] [stdout] 53 | | .from_err() [INFO] [stdout] 54 | | .with::<_, fn(_) -> _, _>(|response| { [INFO] [stdout] 55 | | println!("[PbftProtocolConfig::upgrade_inbound] [with] response: {:?}", response); [INFO] [stdout] ... | [INFO] [stdout] 60 | | Ok(bytes_to_message(&bytes)) [INFO] [stdout] 61 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol_config.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 76 | socket: Negotiated, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / Framed::new(socket, codec) [INFO] [stdout] 85 | | .from_err() [INFO] [stdout] 86 | | .with::<_, fn(_) -> _, _>(|outbound_message| { [INFO] [stdout] 87 | | println!("[PbftProtocolConfig::upgrade_outbound] [with] outbound_message : {:?}", outbound_message); [INFO] [stdout] ... | [INFO] [stdout] 92 | | Ok(bytes.to_vec()) [INFO] [stdout] 93 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbft` (bin "pbft") due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1ce9a46177b19b6340379e876152c220044ae7a3b905a15210841ef2916b4edd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ce9a46177b19b6340379e876152c220044ae7a3b905a15210841ef2916b4edd", kill_on_drop: false }` [INFO] [stdout] 1ce9a46177b19b6340379e876152c220044ae7a3b905a15210841ef2916b4edd