[INFO] cloning repository https://github.com/abusch/xld-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abusch/xld-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fxld-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fxld-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7f791d1865f62b51ae140c844ca1e25c7180c9a [INFO] checking abusch/xld-rs/c7f791d1865f62b51ae140c844ca1e25c7180c9a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fxld-rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/abusch/xld-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/abusch/xld-rs [INFO] finished tweaking git repo https://github.com/abusch/xld-rs [INFO] tweaked toml for git repo https://github.com/abusch/xld-rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/abusch/xld-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a7242774c3cf3669e1778484ce5634ad3fac79122d9da8bfa5b8dafbf28dd8c [INFO] running `Command { std: "docker" "start" "-a" "7a7242774c3cf3669e1778484ce5634ad3fac79122d9da8bfa5b8dafbf28dd8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a7242774c3cf3669e1778484ce5634ad3fac79122d9da8bfa5b8dafbf28dd8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a7242774c3cf3669e1778484ce5634ad3fac79122d9da8bfa5b8dafbf28dd8c", kill_on_drop: false }` [INFO] [stdout] 7a7242774c3cf3669e1778484ce5634ad3fac79122d9da8bfa5b8dafbf28dd8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5bd9925b41388bd0a6a107b927ac9e01c379232f60eb9745d8b50b14d1db1dc1 [INFO] running `Command { std: "docker" "start" "-a" "5bd9925b41388bd0a6a107b927ac9e01c379232f60eb9745d8b50b14d1db1dc1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling pkg-config v0.3.11 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling x11 v2.18.0 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking xld-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `dpi` [INFO] [stdout] --> src/xrandrutils.rs:15:68 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn render_xrandr_command(outputs: &[Output], primary: &Output, dpi: u32) -> Command { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dpi` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/edid.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / format!( [INFO] [stdout] 15 | | "{} has edid size {}, expected at least {}", [INFO] [stdout] 16 | | name, [INFO] [stdout] 17 | | edid.len(), [INFO] [stdout] 18 | | EDID_MIN_LENGTH [INFO] [stdout] 19 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 | "{} has edid size {}, expected at least {}", [INFO] [stdout] ... [INFO] [stdout] 18 | EDID_MIN_LENGTH [INFO] [stdout] 19 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 53 | edid: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Output { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | name, [INFO] [stdout] 86 | | state, [INFO] [stdout] 87 | | modes, [INFO] [stdout] ... | [INFO] [stdout] 92 | | desired_active: false, [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dpi` [INFO] [stdout] --> src/xrandrutils.rs:15:68 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn render_xrandr_command(outputs: &[Output], primary: &Output, dpi: u32) -> Command { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dpi` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xld-rs` (bin "xld-rs") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/edid.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | / format!( [INFO] [stdout] 15 | | "{} has edid size {}, expected at least {}", [INFO] [stdout] 16 | | name, [INFO] [stdout] 17 | | edid.len(), [INFO] [stdout] 18 | | EDID_MIN_LENGTH [INFO] [stdout] 19 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 | "{} has edid size {}, expected at least {}", [INFO] [stdout] ... [INFO] [stdout] 18 | EDID_MIN_LENGTH [INFO] [stdout] 19 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 53 | edid: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Output { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | name, [INFO] [stdout] 86 | | state, [INFO] [stdout] 87 | | modes, [INFO] [stdout] ... | [INFO] [stdout] 92 | | desired_active: false, [INFO] [stdout] 93 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xld-rs` (bin "xld-rs" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5bd9925b41388bd0a6a107b927ac9e01c379232f60eb9745d8b50b14d1db1dc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bd9925b41388bd0a6a107b927ac9e01c379232f60eb9745d8b50b14d1db1dc1", kill_on_drop: false }` [INFO] [stdout] 5bd9925b41388bd0a6a107b927ac9e01c379232f60eb9745d8b50b14d1db1dc1