[INFO] cloning repository https://github.com/abusch/st-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abusch/st-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fst-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fst-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 57547ba230137acd8e890547e26c69002a3e308c [INFO] checking abusch/st-rust/57547ba230137acd8e890547e26c69002a3e308c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabusch%2Fst-rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/abusch/st-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/abusch/st-rust [INFO] finished tweaking git repo https://github.com/abusch/st-rust [INFO] tweaked toml for git repo https://github.com/abusch/st-rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/abusch/st-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c01b6d57186058fb2d77333405b69ac5719f26424a24f63e881455f807ab815a [INFO] running `Command { std: "docker" "start" "-a" "c01b6d57186058fb2d77333405b69ac5719f26424a24f63e881455f807ab815a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c01b6d57186058fb2d77333405b69ac5719f26424a24f63e881455f807ab815a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c01b6d57186058fb2d77333405b69ac5719f26424a24f63e881455f807ab815a", kill_on_drop: false }` [INFO] [stdout] c01b6d57186058fb2d77333405b69ac5719f26424a24f63e881455f807ab815a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8948e058e2dee6292a336f914072ebe3cd9830a416a8f8a3203692c9c88cd40c [INFO] running `Command { std: "docker" "start" "-a" "8948e058e2dee6292a336f914072ebe3cd9830a416a8f8a3203692c9c88cd40c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking tracing-core v0.1.24 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling fixedbitset v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling cmake v0.1.48 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking twox-hash v1.6.2 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking pem v1.0.2 [INFO] [stderr] Checking rustls-pemfile v0.3.0 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking lz4_flex v0.9.2 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling which v4.2.5 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Compiling petgraph v0.6.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling prost-build v0.10.0 [INFO] [stderr] Checking tracing-subscriber v0.3.10 [INFO] [stderr] Compiling regex v1.5.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Compiling prost-derive v0.10.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Compiling prost v0.10.0 [INFO] [stderr] Compiling prost-types v0.10.0 [INFO] [stderr] Compiling st-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-rustls v0.23.3 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stdout] warning: method `device` is never used [INFO] [stdout] --> src/config.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 35 | impl Configuration { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 36 | pub fn device(&self, id: &DeviceId) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `model` is never read [INFO] [stdout] --> src/protocol/connection/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct ConnectionHandle { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 28 | model: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `config_cluster` is never used [INFO] [stdout] --> src/protocol/connection/mod.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 34 | impl ConnectionHandle { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 127 | pub async fn config_cluster(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `client_name`, and `client_version` are never read [INFO] [stdout] --> src/model.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Model { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | id: DeviceId, [INFO] [stdout] | ^^ [INFO] [stdout] 14 | cfg: Configuration, [INFO] [stdout] 15 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 16 | client_version: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:49:56 [INFO] [stdout] | [INFO] [stdout] 49 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:56 [INFO] [stdout] | [INFO] [stdout] 73 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connections/tcp.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(listener: TcpListener, conn_tx: Sender, config: ServerConfig, shutdown_rx: watch::Receiver) -> Self { [INFO] [stdout] | --------------------- ----------------------------- -------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 57 | let mut connection_reader = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 59 | let mut connection_writer = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 61 | let mut connection_dispatcher = ConnectionDispatcher::new(remote_id, model.clone(), inbox_rx, shutdown_rx.clone()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 62 | let connection_ping_receiver: ConnectionPingReceiver = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 64 | let connection_ping_sender: ConnectionPingSender = [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/ping.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 105 | let (done_tx, done_rx) = oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ( [INFO] [stdout] 107 | / AsyncTypedMessage { [INFO] [stdout] 108 | | msg: TypedMessage::Ping(Ping::default()), [INFO] [stdout] 109 | | done: done_tx, [INFO] [stdout] 110 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/reader.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 26 | conn: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | inbox: mpsc::Sender, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | last_msg_received: watch::Sender, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | shutdown_rx: watch::Receiver, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | buffer: BytesMut::with_capacity(1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/writer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 30 | conn: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | outbox: mpsc::Receiver, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | last_msg_sent_tx: watch::Sender, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | shutdown_rx: watch::Receiver, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | buf: BytesMut::with_capacity(1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn load_certs>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let path = path.as_ref(); [INFO] [stdout] 10 | / certs(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] 11 | | .map(|cert_bytes| cert_bytes.into_iter().map(Certificate).collect()) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn load_keys>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let path = path.as_ref(); [INFO] [stdout] 18 | / pkcs8_private_keys(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] 19 | | .map(|keys_bytes| keys_bytes.into_iter().map(PrivateKey).collect()) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `st-rust` (bin "st-rust") due to 15 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `device` is never used [INFO] [stdout] --> src/config.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 35 | impl Configuration { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 36 | pub fn device(&self, id: &DeviceId) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `model` is never read [INFO] [stdout] --> src/protocol/connection/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct ConnectionHandle { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 28 | model: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `config_cluster` is never used [INFO] [stdout] --> src/protocol/connection/mod.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 34 | impl ConnectionHandle { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 127 | pub async fn config_cluster(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `client_name`, and `client_version` are never read [INFO] [stdout] --> src/model.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Model { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | id: DeviceId, [INFO] [stdout] | ^^ [INFO] [stdout] 14 | cfg: Configuration, [INFO] [stdout] 15 | client_name: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 16 | client_version: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:49:56 [INFO] [stdout] | [INFO] [stdout] 49 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:73:56 [INFO] [stdout] | [INFO] [stdout] 73 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connections/tcp.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(listener: TcpListener, conn_tx: Sender, config: ServerConfig, shutdown_rx: watch::Receiver) -> Self { [INFO] [stdout] | --------------------- ----------------------------- -------------------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 57 | let mut connection_reader = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:81:18 [INFO] [stdout] | [INFO] [stdout] 59 | let mut connection_writer = [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 61 | let mut connection_dispatcher = ConnectionDispatcher::new(remote_id, model.clone(), inbox_rx, shutdown_rx.clone()); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 62 | let connection_ping_receiver: ConnectionPingReceiver = [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/mod.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 64 | let connection_ping_sender: ConnectionPingSender = [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let barrier_clone = start.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/ping.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 105 | let (done_tx, done_rx) = oneshot::channel(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ( [INFO] [stdout] 107 | / AsyncTypedMessage { [INFO] [stdout] 108 | | msg: TypedMessage::Ping(Ping::default()), [INFO] [stdout] 109 | | done: done_tx, [INFO] [stdout] 110 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/reader.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 26 | conn: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | inbox: mpsc::Sender, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | last_msg_received: watch::Sender, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | shutdown_rx: watch::Receiver, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | buffer: BytesMut::with_capacity(1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/connection/writer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 30 | conn: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | outbox: mpsc::Receiver, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | last_msg_sent_tx: watch::Sender, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | shutdown_rx: watch::Receiver, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | buf: BytesMut::with_capacity(1024), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn load_certs>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let path = path.as_ref(); [INFO] [stdout] 10 | / certs(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] 11 | | .map(|cert_bytes| cert_bytes.into_iter().map(Certificate).collect()) [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn load_keys>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let path = path.as_ref(); [INFO] [stdout] 18 | / pkcs8_private_keys(&mut BufReader::new(File::open(path)?)) [INFO] [stdout] 19 | | .map(|keys_bytes| keys_bytes.into_iter().map(PrivateKey).collect()) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `st-rust` (bin "st-rust" test) due to 15 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8948e058e2dee6292a336f914072ebe3cd9830a416a8f8a3203692c9c88cd40c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8948e058e2dee6292a336f914072ebe3cd9830a416a8f8a3203692c9c88cd40c", kill_on_drop: false }` [INFO] [stdout] 8948e058e2dee6292a336f914072ebe3cd9830a416a8f8a3203692c9c88cd40c