[INFO] cloning repository https://github.com/abel465/abelscreensaver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abel465/abelscreensaver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabel465%2Fabelscreensaver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabel465%2Fabelscreensaver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ef49f68620fe0f1a04c7df986f36031ef61ce7da [INFO] checking abel465/abelscreensaver/ef49f68620fe0f1a04c7df986f36031ef61ce7da against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabel465%2Fabelscreensaver" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/abel465/abelscreensaver on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/abel465/abelscreensaver [INFO] finished tweaking git repo https://github.com/abel465/abelscreensaver [INFO] tweaked toml for git repo https://github.com/abel465/abelscreensaver written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/abel465/abelscreensaver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e96cee45f4c903f66b07e9a8fe7d31231c25f0028256400c2f189d1a5d75bf6f [INFO] running `Command { std: "docker" "start" "-a" "e96cee45f4c903f66b07e9a8fe7d31231c25f0028256400c2f189d1a5d75bf6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e96cee45f4c903f66b07e9a8fe7d31231c25f0028256400c2f189d1a5d75bf6f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e96cee45f4c903f66b07e9a8fe7d31231c25f0028256400c2f189d1a5d75bf6f", kill_on_drop: false }` [INFO] [stdout] e96cee45f4c903f66b07e9a8fe7d31231c25f0028256400c2f189d1a5d75bf6f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd0bda92cade652dea119f85b83f31d23647ead1690558b3037c88361546506f [INFO] running `Command { std: "docker" "start" "-a" "fd0bda92cade652dea119f85b83f31d23647ead1690558b3037c88361546506f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling xml-rs v0.8.20 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling crossfont v0.5.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling unicode-general-category v0.4.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking ttf-parser v0.17.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking fontconfig-parser v0.5.6 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking data-url v0.1.1 [INFO] [stderr] Checking svgtypes v0.8.2 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking kurbo v0.8.3 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking simplecss v0.2.1 [INFO] [stderr] Checking freetype-rs v0.26.0 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking owned_ttf_parser v0.21.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking rctree v0.4.0 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking ab_glyph v0.2.26 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling libmpv2-sys v4.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling libmpv2 v4.0.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking jpeg-decoder v0.2.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking fontdb v0.9.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking bisection v0.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling derive_utils v0.14.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling auto_enums v0.8.5 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking wayland-egl v0.29.5 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking bytemuck v1.16.0 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Checking ecolor v0.20.0 [INFO] [stderr] Checking emath v0.20.0 [INFO] [stderr] Checking rgb v0.8.45 [INFO] [stderr] Checking rustybuzz v0.5.1 [INFO] [stderr] Checking epaint v0.20.0 [INFO] [stderr] Checking svgfilters v0.4.0 [INFO] [stderr] Checking tiny-skia v0.6.6 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Checking egui v0.20.1 [INFO] [stderr] Checking usvg v0.23.0 [INFO] [stderr] Checking resvg v0.23.0 [INFO] [stderr] Checking egui_extras v0.20.0 [INFO] [stderr] Checking ffprobe v0.4.0 [INFO] [stderr] Checking sctk-adwaita v0.4.3 [INFO] [stderr] Checking winit v0.27.5 [INFO] [stderr] Checking egui-winit v0.20.1 [INFO] [stderr] Checking glutin v0.29.1 [INFO] [stderr] Checking egui_glow v0.20.1 [INFO] [stderr] Checking abelscreensaver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn new(image_on: RetainedImage, image_off: RetainedImage, on: bool) -> Self { [INFO] [stdout] | ----------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self { [INFO] [stdout] 16 | images: [image_on, image_off], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:204:27 [INFO] [stdout] | [INFO] [stdout] 146 | let mute_toggle_button = ImageToggleButton::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let pause_toggle_button = ImageToggleButton::new( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let center_images = [ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | settings_gui: SettingsGui::new(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 246 | event_proxy: EventLoopProxy, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | / ui.horizontal_centered(|ui| { [INFO] [stdout] 251 | | if self.pause_toggle_button.ui(ctx, ui).clicked() { [INFO] [stdout] 252 | | mpv_client.set_pause(self.pause_toggle_button.toggle()); [INFO] [stdout] 253 | | } [INFO] [stdout] ... | [INFO] [stdout] 264 | | .inner [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:257:21 [INFO] [stdout] | [INFO] [stdout] 246 | event_proxy: EventLoopProxy, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | / ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| { [INFO] [stdout] 258 | | let resp = self.settings_gui.show(ctx, ui, event_proxy); [INFO] [stdout] 259 | | if self.has_media { [INFO] [stdout] 260 | | self.path_label(ctx, ui) [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | resp [INFO] [stdout] 263 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:102:20 [INFO] [stdout] | [INFO] [stdout] 66 | let event_loop = EventLoopBuilder::::with_user_event().build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let (gl, window) = unsafe { [INFO] [stdout] | -- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let window_builder = glutin::window::WindowBuilder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let window = glutin::ContextBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let gl = glow::Context::from_loader_function(|name| window.get_proc_address(name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let (mpv, render_context) = setup_mpv(&event_loop, window.clone(), &opts); [INFO] [stdout] | --- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut egui_glow = egui_glow::winit::EguiGlow::new(&event_loop, gl, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | let mut it = media_iterator(opts.clone()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let mut overlay = Overlay::new(size, opts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let mut mpv_client = MpvClient::new(mpv); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let event_proxy = event_loop.create_proxy(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | event_loop.run(move |event, _, ctrl_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 103 | | ctrl_flow.set_wait(); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 207 | | } [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | .or_else(|| std::env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:135:37 [INFO] [stdout] | [INFO] [stdout] 123 | ... let text_edit = ui.add( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | ... remove_button(ui).clicked().then_some(i).or(remove_index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `abelscreensaver` (bin "abelscreensaver" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn new(image_on: RetainedImage, image_off: RetainedImage, on: bool) -> Self { [INFO] [stdout] | ----------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self { [INFO] [stdout] 16 | images: [image_on, image_off], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:204:27 [INFO] [stdout] | [INFO] [stdout] 146 | let mute_toggle_button = ImageToggleButton::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let pause_toggle_button = ImageToggleButton::new( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let center_images = [ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | settings_gui: SettingsGui::new(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 246 | event_proxy: EventLoopProxy, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | / ui.horizontal_centered(|ui| { [INFO] [stdout] 251 | | if self.pause_toggle_button.ui(ctx, ui).clicked() { [INFO] [stdout] 252 | | mpv_client.set_pause(self.pause_toggle_button.toggle()); [INFO] [stdout] 253 | | } [INFO] [stdout] ... | [INFO] [stdout] 264 | | .inner [INFO] [stdout] 265 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/overlay.rs:257:21 [INFO] [stdout] | [INFO] [stdout] 246 | event_proxy: EventLoopProxy, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | / ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| { [INFO] [stdout] 258 | | let resp = self.settings_gui.show(ctx, ui, event_proxy); [INFO] [stdout] 259 | | if self.has_media { [INFO] [stdout] 260 | | self.path_label(ctx, ui) [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | resp [INFO] [stdout] 263 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:102:20 [INFO] [stdout] | [INFO] [stdout] 66 | let event_loop = EventLoopBuilder::::with_user_event().build(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let (gl, window) = unsafe { [INFO] [stdout] | -- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let window_builder = glutin::window::WindowBuilder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let window = glutin::ContextBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let gl = glow::Context::from_loader_function(|name| window.get_proc_address(name)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let (mpv, render_context) = setup_mpv(&event_loop, window.clone(), &opts); [INFO] [stdout] | --- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let mut egui_glow = egui_glow::winit::EguiGlow::new(&event_loop, gl, None); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | let mut it = media_iterator(opts.clone()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let mut overlay = Overlay::new(size, opts); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let mut mpv_client = MpvClient::new(mpv); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let event_proxy = event_loop.create_proxy(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | [INFO] [stdout] 102 | event_loop.run(move |event, _, ctrl_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 103 | | ctrl_flow.set_wait(); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | match event { [INFO] [stdout] ... | [INFO] [stdout] 207 | | } [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:31:25 [INFO] [stdout] | [INFO] [stdout] 31 | .or_else(|| std::env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:135:37 [INFO] [stdout] | [INFO] [stdout] 123 | ... let text_edit = ui.add( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | ... remove_button(ui).clicked().then_some(i).or(remove_index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `abelscreensaver` (bin "abelscreensaver") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "fd0bda92cade652dea119f85b83f31d23647ead1690558b3037c88361546506f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd0bda92cade652dea119f85b83f31d23647ead1690558b3037c88361546506f", kill_on_drop: false }` [INFO] [stdout] fd0bda92cade652dea119f85b83f31d23647ead1690558b3037c88361546506f