[INFO] cloning repository https://github.com/abe-bb/AdventOfCode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/abe-bb/AdventOfCode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabe-bb%2FAdventOfCode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabe-bb%2FAdventOfCode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b8d174127dca126e4393ced4883070c6cbb109d1 [INFO] checking abe-bb/AdventOfCode/b8d174127dca126e4393ced4883070c6cbb109d1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fabe-bb%2FAdventOfCode" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/abe-bb/AdventOfCode on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/abe-bb/AdventOfCode [INFO] finished tweaking git repo https://github.com/abe-bb/AdventOfCode [INFO] tweaked toml for git repo https://github.com/abe-bb/AdventOfCode written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/abe-bb/AdventOfCode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d87194c8829e440e52816bbba318e7b5c8a1788f20fe43348d66eb8fd89878bd [INFO] running `Command { std: "docker" "start" "-a" "d87194c8829e440e52816bbba318e7b5c8a1788f20fe43348d66eb8fd89878bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d87194c8829e440e52816bbba318e7b5c8a1788f20fe43348d66eb8fd89878bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d87194c8829e440e52816bbba318e7b5c8a1788f20fe43348d66eb8fd89878bd", kill_on_drop: false }` [INFO] [stdout] d87194c8829e440e52816bbba318e7b5c8a1788f20fe43348d66eb8fd89878bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84adb7058d443bdd4d2c867c32d72298722271ac7164dd3bbdf42148287edb11 [INFO] running `Command { std: "docker" "start" "-a" "84adb7058d443bdd4d2c867c32d72298722271ac7164dd3bbdf42148287edb11", kill_on_drop: false }` [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2022.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 7 | let days: Vec> = vec![ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | Box::new(Year { [INFO] [stdout] | ______________^ [INFO] [stdout] 13 | | year: 2022, [INFO] [stdout] 14 | | days, [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2022.rs:670:20 [INFO] [stdout] | [INFO] [stdout] 667 | let item_set = HashSet::from_iter(inventory.chars()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | total: Box::new(inventory), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 14 | let days: Vec> = vec![ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Box::new(Year { year: 2023, days }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:556:5 [INFO] [stdout] | [INFO] [stdout] 555 | fn day9_parse(reader: impl BufRead) -> Vec> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | / reader [INFO] [stdout] 557 | | .lines() [INFO] [stdout] 558 | | .map(|x| x.unwrap()) [INFO] [stdout] 559 | | .map(|line| { [INFO] [stdout] ... | [INFO] [stdout] 562 | | .collect_vec() [INFO] [stdout] 563 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:711:5 [INFO] [stdout] | [INFO] [stdout] 708 | fn day7_parse(reader: impl BufRead) -> Vec<(Hand, u64)> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 711 | / reader [INFO] [stdout] 712 | | .lines() [INFO] [stdout] 713 | | .map(|x| x.unwrap()) [INFO] [stdout] 714 | | .flat_map(|x| x.split_whitespace().map(|x| x.to_owned()).collect_vec()) [INFO] [stdout] 715 | | .tuples() [INFO] [stdout] 716 | | .map(|(hand, bid)| (Hand::try_from(hand.as_str()).unwrap(), bid.parse().unwrap())) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:1207:5 [INFO] [stdout] | [INFO] [stdout] 1199 | fn day4p2_logic(mut cards: Vec) -> usize { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1207 | cards.into_iter().map(|card| card.copies).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:1628:5 [INFO] [stdout] | [INFO] [stdout] 1627 | fn day1_logic(reader: impl BufRead) -> u64 { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1628 | / reader [INFO] [stdout] 1629 | | .lines() [INFO] [stdout] 1630 | | .map(|x| x.unwrap()) [INFO] [stdout] 1631 | | .map(|x| insert_digits_from_text(x)) [INFO] [stdout] 1632 | | .map(|x| recover_calibration_value(x)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2022.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 7 | let days: Vec> = vec![ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | Box::new(Year { [INFO] [stdout] | ______________^ [INFO] [stdout] 13 | | year: 2022, [INFO] [stdout] 14 | | days, [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2022.rs:670:20 [INFO] [stdout] | [INFO] [stdout] 667 | let item_set = HashSet::from_iter(inventory.chars()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | total: Box::new(inventory), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 14 | let days: Vec> = vec![ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Box::new(Year { year: 2023, days }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:556:5 [INFO] [stdout] | [INFO] [stdout] 555 | fn day9_parse(reader: impl BufRead) -> Vec> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 556 | / reader [INFO] [stdout] 557 | | .lines() [INFO] [stdout] 558 | | .map(|x| x.unwrap()) [INFO] [stdout] 559 | | .map(|line| { [INFO] [stdout] ... | [INFO] [stdout] 562 | | .collect_vec() [INFO] [stdout] 563 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:711:5 [INFO] [stdout] | [INFO] [stdout] 708 | fn day7_parse(reader: impl BufRead) -> Vec<(Hand, u64)> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 711 | / reader [INFO] [stdout] 712 | | .lines() [INFO] [stdout] 713 | | .map(|x| x.unwrap()) [INFO] [stdout] 714 | | .flat_map(|x| x.split_whitespace().map(|x| x.to_owned()).collect_vec()) [INFO] [stdout] 715 | | .tuples() [INFO] [stdout] 716 | | .map(|(hand, bid)| (Hand::try_from(hand.as_str()).unwrap(), bid.parse().unwrap())) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:1207:5 [INFO] [stdout] | [INFO] [stdout] 1199 | fn day4p2_logic(mut cards: Vec) -> usize { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1207 | cards.into_iter().map(|card| card.copies).sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/years/year2023.rs:1628:5 [INFO] [stdout] | [INFO] [stdout] 1627 | fn day1_logic(reader: impl BufRead) -> u64 { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1628 | / reader [INFO] [stdout] 1629 | | .lines() [INFO] [stdout] 1630 | | .map(|x| x.unwrap()) [INFO] [stdout] 1631 | | .map(|x| insert_digits_from_text(x)) [INFO] [stdout] 1632 | | .map(|x| recover_calibration_value(x)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "84adb7058d443bdd4d2c867c32d72298722271ac7164dd3bbdf42148287edb11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84adb7058d443bdd4d2c867c32d72298722271ac7164dd3bbdf42148287edb11", kill_on_drop: false }` [INFO] [stdout] 84adb7058d443bdd4d2c867c32d72298722271ac7164dd3bbdf42148287edb11