[INFO] cloning repository https://github.com/aatifsyed/stackstack [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aatifsyed/stackstack" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fstackstack", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fstackstack'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35fdc35d75ebac65e977d930f11c0f91f81b2e59 [INFO] checking aatifsyed/stackstack/35fdc35d75ebac65e977d930f11c0f91f81b2e59 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fstackstack" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aatifsyed/stackstack on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aatifsyed/stackstack [INFO] finished tweaking git repo https://github.com/aatifsyed/stackstack [INFO] tweaked toml for git repo https://github.com/aatifsyed/stackstack written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aatifsyed/stackstack already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4fde8caca277417157d484ff072a75f635aabea4e54461ca116017d6ac42f0d [INFO] running `Command { std: "docker" "start" "-a" "f4fde8caca277417157d484ff072a75f635aabea4e54461ca116017d6ac42f0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4fde8caca277417157d484ff072a75f635aabea4e54461ca116017d6ac42f0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4fde8caca277417157d484ff072a75f635aabea4e54461ca116017d6ac42f0d", kill_on_drop: false }` [INFO] [stdout] f4fde8caca277417157d484ff072a75f635aabea4e54461ca116017d6ac42f0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e627f5a5d79482355b1f7ae148bf0505f315966d4f3fbf706ef8a275b5d8f66 [INFO] running `Command { std: "docker" "start" "-a" "5e627f5a5d79482355b1f7ae148bf0505f315966d4f3fbf706ef8a275b5d8f66", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking stackstack v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 188 | pub const fn of(item: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | Self { [INFO] [stdout] 190 | inner: _Stack::Top { [INFO] [stdout] | ____________________^ [INFO] [stdout] 191 | | head: item, [INFO] [stdout] 192 | | tail: Self::EMPTY_REF, [INFO] [stdout] 193 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 206 | pub const fn pushed(&'a self, item: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Self { [INFO] [stdout] 208 | inner: _Stack::Top { [INFO] [stdout] | ____________________^ [INFO] [stdout] 209 | | head: item, [INFO] [stdout] 210 | | tail: self, [INFO] [stdout] 211 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 344 | pub fn with(&self, item: T, f: impl FnOnce(&Stack<'_, T>) -> R) -> R { [INFO] [stdout] | ------- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | f(&self.pushed(item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:366:15 [INFO] [stdout] | [INFO] [stdout] 362 | items: impl IntoIterator, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 363 | f: impl FnOnce(&Stack<'_, T>) -> R, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | ) -> R { [INFO] [stdout] 365 | let mut chain = items.into_iter(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | match chain.next() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stackstack` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5e627f5a5d79482355b1f7ae148bf0505f315966d4f3fbf706ef8a275b5d8f66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e627f5a5d79482355b1f7ae148bf0505f315966d4f3fbf706ef8a275b5d8f66", kill_on_drop: false }` [INFO] [stdout] 5e627f5a5d79482355b1f7ae148bf0505f315966d4f3fbf706ef8a275b5d8f66