[INFO] cloning repository https://github.com/aatifsyed/most-recently [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aatifsyed/most-recently" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fmost-recently", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fmost-recently'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e89fff518da5a51515a3da728585cfebba980902 [INFO] checking aatifsyed/most-recently/e89fff518da5a51515a3da728585cfebba980902 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faatifsyed%2Fmost-recently" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aatifsyed/most-recently on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aatifsyed/most-recently [INFO] finished tweaking git repo https://github.com/aatifsyed/most-recently [INFO] tweaked toml for git repo https://github.com/aatifsyed/most-recently written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aatifsyed/most-recently already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67dbc587de35c425de10bb0ac698c11e3fc2834d32f75bb6742a081e5e4b5f40 [INFO] running `Command { std: "docker" "start" "-a" "67dbc587de35c425de10bb0ac698c11e3fc2834d32f75bb6742a081e5e4b5f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67dbc587de35c425de10bb0ac698c11e3fc2834d32f75bb6742a081e5e4b5f40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67dbc587de35c425de10bb0ac698c11e3fc2834d32f75bb6742a081e5e4b5f40", kill_on_drop: false }` [INFO] [stdout] 67dbc587de35c425de10bb0ac698c11e3fc2834d32f75bb6742a081e5e4b5f40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31b9d9c2988971122463a86a3a1381bb549bfd29e5fd4ac002e68295cf9983dc [INFO] running `Command { std: "docker" "start" "-a" "31b9d9c2988971122463a86a3a1381bb549bfd29e5fd4ac002e68295cf9983dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking sharded-slab v0.1.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking tracing-serde v0.1.2 [INFO] [stderr] Compiling tracing-attributes v0.1.15 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Checking tracing-subscriber v0.2.19 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking most-recently v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|path| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let key = key_fn(&path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Some((path, key)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:50 [INFO] [stdout] | [INFO] [stdout] 39 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.accessed().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:50 [INFO] [stdout] | [INFO] [stdout] 42 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.created().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:50 [INFO] [stdout] | [INFO] [stdout] 45 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:22 [INFO] [stdout] | [INFO] [stdout] 13 | .filter_map(|path| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let key = key_fn(&path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Some((path, key)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `most-recently` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:50 [INFO] [stdout] | [INFO] [stdout] 39 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.accessed().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:50 [INFO] [stdout] | [INFO] [stdout] 42 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.created().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:50 [INFO] [stdout] | [INFO] [stdout] 45 | self.max_by_maybe_key(|path_buf| path_buf.metadata().ok()?.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `most-recently` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "31b9d9c2988971122463a86a3a1381bb549bfd29e5fd4ac002e68295cf9983dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31b9d9c2988971122463a86a3a1381bb549bfd29e5fd4ac002e68295cf9983dc", kill_on_drop: false }` [INFO] [stdout] 31b9d9c2988971122463a86a3a1381bb549bfd29e5fd4ac002e68295cf9983dc