[INFO] cloning repository https://github.com/aarongpower/nix-concierge [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aarongpower/nix-concierge" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarongpower%2Fnix-concierge", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarongpower%2Fnix-concierge'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d4bd2ea1301d2a12759114c69ebfcf26b7409c0e [INFO] checking aarongpower/nix-concierge/d4bd2ea1301d2a12759114c69ebfcf26b7409c0e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faarongpower%2Fnix-concierge" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aarongpower/nix-concierge on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aarongpower/nix-concierge [INFO] finished tweaking git repo https://github.com/aarongpower/nix-concierge [INFO] tweaked toml for git repo https://github.com/aarongpower/nix-concierge written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aarongpower/nix-concierge already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f60d998889b7bcb7a93bda09e2462e8469cb3e2c9be31b060d1ce7fefcfd951 [INFO] running `Command { std: "docker" "start" "-a" "8f60d998889b7bcb7a93bda09e2462e8469cb3e2c9be31b060d1ce7fefcfd951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f60d998889b7bcb7a93bda09e2462e8469cb3e2c9be31b060d1ce7fefcfd951", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f60d998889b7bcb7a93bda09e2462e8469cb3e2c9be31b060d1ce7fefcfd951", kill_on_drop: false }` [INFO] [stdout] 8f60d998889b7bcb7a93bda09e2462e8469cb3e2c9be31b060d1ce7fefcfd951 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52182b23230e6c31ab05f7a5a10efcf6f72941b1a0bd0e98a556d9bf86dfae71 [INFO] running `Command { std: "docker" "start" "-a" "52182b23230e6c31ab05f7a5a10efcf6f72941b1a0bd0e98a556d9bf86dfae71", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling jobserver v0.1.29 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking os-version v0.2.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking lipsum v0.9.1 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking git-url-parse v0.4.4 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking concierge v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn is_directory_empty>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 5 | let mut entries = fs::read_dir(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Ok(entries.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn is_git_repo>(path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Repository::discover(path).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | .filter_map(|n| repo.find_remote(n).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concierge` (bin "concierge") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn is_directory_empty>(path: P) -> std::io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 5 | let mut entries = fs::read_dir(path)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | Ok(entries.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn is_git_repo>(path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Repository::discover(path).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | .filter_map(|n| repo.find_remote(n).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `concierge` (bin "concierge" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "52182b23230e6c31ab05f7a5a10efcf6f72941b1a0bd0e98a556d9bf86dfae71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52182b23230e6c31ab05f7a5a10efcf6f72941b1a0bd0e98a556d9bf86dfae71", kill_on_drop: false }` [INFO] [stdout] 52182b23230e6c31ab05f7a5a10efcf6f72941b1a0bd0e98a556d9bf86dfae71