[INFO] cloning repository https://github.com/aaamourao/carnaval-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aaamourao/carnaval-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faaamourao%2Fcarnaval-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faaamourao%2Fcarnaval-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 27519004e0342638670f38f7757e27d045944ee5 [INFO] checking aaamourao/carnaval-rust/27519004e0342638670f38f7757e27d045944ee5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Faaamourao%2Fcarnaval-rust" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aaamourao/carnaval-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aaamourao/carnaval-rust [INFO] finished tweaking git repo https://github.com/aaamourao/carnaval-rust [INFO] tweaked toml for git repo https://github.com/aaamourao/carnaval-rust written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aaamourao/carnaval-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 853e1d920d4163bc8afe84d98d5c0d9bcfa8c383e1343ef76447db41a78aa77f [INFO] running `Command { std: "docker" "start" "-a" "853e1d920d4163bc8afe84d98d5c0d9bcfa8c383e1343ef76447db41a78aa77f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "853e1d920d4163bc8afe84d98d5c0d9bcfa8c383e1343ef76447db41a78aa77f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "853e1d920d4163bc8afe84d98d5c0d9bcfa8c383e1343ef76447db41a78aa77f", kill_on_drop: false }` [INFO] [stdout] 853e1d920d4163bc8afe84d98d5c0d9bcfa8c383e1343ef76447db41a78aa77f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ddc591d705a6a93f0fbe048137d86af0864f44899aafd3f1c8d31b130c1825b9 [INFO] running `Command { std: "docker" "start" "-a" "ddc591d705a6a93f0fbe048137d86af0864f44899aafd3f1c8d31b130c1825b9", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking more-asserts v0.3.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking plotpy v0.5.1 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking noisy_float v0.2.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stderr] Checking ndarray-stats v0.5.1 [INFO] [stderr] Checking carnaval_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Zip` [INFO] [stdout] --> src/layer/dense.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use ndarray::{Array, Axis, Ix3, Zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `softmax` [INFO] [stdout] --> src/layer/conv2d.rs:6:76 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::activation::{ActivationFunctionType, leaky_relu, relu, sigmoid, softmax, tanh}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Axis`, `IntoDimension`, and `array` [INFO] [stdout] --> src/layer/flatten.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use ndarray::{Array, array, Axis, IntoDimension, Ix3}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::iter::ParallelIterator` [INFO] [stdout] --> src/layer/dense.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rayon::iter::ParallelIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::iter::ParallelIterator` [INFO] [stdout] --> src/layer/conv2d.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use rayon::iter::ParallelIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Zip` [INFO] [stdout] --> src/layer/dense.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use ndarray::{Array, Axis, Ix3, Zip}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `softmax` [INFO] [stdout] --> src/layer/conv2d.rs:6:76 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::activation::{ActivationFunctionType, leaky_relu, relu, sigmoid, softmax, tanh}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Axis`, `IntoDimension`, and `array` [INFO] [stdout] --> src/layer/flatten.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use ndarray::{Array, array, Axis, IntoDimension, Ix3}; [INFO] [stdout] | ^^^^^ ^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Array` [INFO] [stdout] --> src/lib.rs:8:26 [INFO] [stdout] | [INFO] [stdout] 8 | use ndarray::{array, Array}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ndarray_rand::RandomExt` [INFO] [stdout] --> src/lib.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | use ndarray_rand::RandomExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::distributions::Uniform` [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | use rand::distributions::Uniform; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/layer/flatten.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let mut flatten_input = Array::from_iter(input.iter().cloned()); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `filters`, `input_dim`, `strides`, and `dilatation_rate` are never read [INFO] [stdout] --> src/layer/conv2d.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Conv2D { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | filters: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | input_dim: (usize, usize, usize), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 16 | pub output_dim: (usize, usize, usize), [INFO] [stdout] 17 | strides: (usize, usize), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 18 | dilatation_rate: (usize, usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let exp_scores = x.clone().map(|x| x.exp()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | exp_scores.clone() / exp_scores.sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/flatten.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 24 | let mut flatten_input = Array::from_iter(input.iter().cloned()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let flatten_input_size = flatten_input.shape()[0]; [INFO] [stdout] 26 | Ok(flatten_input.to_shape((1, flatten_input_size, 1)).unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carnaval_rust` (lib) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `rayon::iter::ParallelIterator` [INFO] [stdout] --> src/layer/dense.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rayon::iter::ParallelIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::iter::ParallelIterator` [INFO] [stdout] --> src/layer/conv2d.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use rayon::iter::ParallelIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/layer/flatten.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | let mut flatten_input = Array::from_iter(input.iter().cloned()); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/lib.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | let result = plot.save("plots/test.svg"); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | let x = array![[[-0.4], [-0.2], [0.0], [0.2], [0.4]]]; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let result = plot.save("plots/test_sequential.svg"); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | let mut nn = Conv2D::new(1, 3, (input_shape[0], input_shape[1], input_shape[2]), None, None, [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | let mut nn = MaxPool2D::new((2, 2), None, None); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 171 | let mut nn = Flatten::new(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `filters`, `input_dim`, `strides`, and `dilatation_rate` are never read [INFO] [stdout] --> src/layer/conv2d.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Conv2D { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | filters: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | input_dim: (usize, usize, usize), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 16 | pub output_dim: (usize, usize, usize), [INFO] [stdout] 17 | strides: (usize, usize), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 18 | dilatation_rate: (usize, usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let exp_scores = x.clone().map(|x| x.exp()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | exp_scores.clone() / exp_scores.sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/flatten.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 24 | let mut flatten_input = Array::from_iter(input.iter().cloned()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let flatten_input_size = flatten_input.shape()[0]; [INFO] [stdout] 26 | Ok(flatten_input.to_shape((1, flatten_input_size, 1)).unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:28 [INFO] [stdout] | [INFO] [stdout] 110 | let y = x.map(|xx| nn.predict(&array![[[xx.clone()]]])[[0, 0, 0]]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `carnaval_rust` (lib test) due to 4 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ddc591d705a6a93f0fbe048137d86af0864f44899aafd3f1c8d31b130c1825b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddc591d705a6a93f0fbe048137d86af0864f44899aafd3f1c8d31b130c1825b9", kill_on_drop: false }` [INFO] [stdout] ddc591d705a6a93f0fbe048137d86af0864f44899aafd3f1c8d31b130c1825b9