[INFO] cloning repository https://github.com/aMytho/osse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/aMytho/osse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FaMytho%2Fosse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FaMytho%2Fosse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 85c425affb1026cd6017fcceb276453a33969d19 [INFO] checking aMytho/osse/85c425affb1026cd6017fcceb276453a33969d19 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FaMytho%2Fosse" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/aMytho/osse on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/aMytho/osse [INFO] finished tweaking git repo https://github.com/aMytho/osse [INFO] tweaked toml for git repo https://github.com/aMytho/osse written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/aMytho/osse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c16baebc531b838692b5b90fe678d9ad794466cf8f1fe1ec02b20d8d8775cf9b [INFO] running `Command { std: "docker" "start" "-a" "c16baebc531b838692b5b90fe678d9ad794466cf8f1fe1ec02b20d8d8775cf9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c16baebc531b838692b5b90fe678d9ad794466cf8f1fe1ec02b20d8d8775cf9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c16baebc531b838692b5b90fe678d9ad794466cf8f1fe1ec02b20d8d8775cf9b", kill_on_drop: false }` [INFO] [stdout] c16baebc531b838692b5b90fe678d9ad794466cf8f1fe1ec02b20d8d8775cf9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0e3c2c5214a8eef9c6e5d5f3e537a6e7b3629751e31959fe62f9f1c0d11893b [INFO] running `Command { std: "docker" "start" "-a" "c0e3c2c5214a8eef9c6e5d5f3e537a6e7b3629751e31959fe62f9f1c0d11893b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.207 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking wildmatch v2.3.4 [INFO] [stderr] Checking rfc7239 v0.1.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking ogg_pager v0.6.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Compiling libsqlite3-sys v0.25.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling poem-derive v3.0.4 [INFO] [stderr] Compiling lofty_attr v0.11.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking lofty v0.21.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling dsl_auto_type v0.1.2 [INFO] [stderr] Compiling diesel_derives v2.2.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking diesel v2.2.2 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking poem v3.0.4 [INFO] [stderr] Checking osse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `pagination` [INFO] [stdout] --> src/api/albums/album_service.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn get_album_tracks(&self, album_id: i32, pagination: Pagination) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pagination` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `limit` and `offset` are never used [INFO] [stdout] --> src/entities/util.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 4 | impl Pagination { [INFO] [stdout] | --------------- associated functions in this implementation [INFO] [stdout] 5 | pub fn limit(limit: i64) -> Self {Pagination(0, limit)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub fn offset(offset: i64) -> Self {Pagination(offset, -1)} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_album_tracks` is never used [INFO] [stdout] --> src/api/albums/album_service.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl AlbumService { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn get_album_tracks(&self, album_id: i32, pagination: Pagination) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:10 [INFO] [stdout] | [INFO] [stdout] 47 | let db = match Pool::builder().test_on_check_out(true).build(pool) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cors = Cors::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let app = Route::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(val) => val, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | match serde_json::from_str(&contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 10 | let files = match fs::read_dir(&dir) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(files) => files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Err(_err) => return Err(FileError::DirectoryError) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(get_files_in_dir(files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pagination` [INFO] [stdout] --> src/api/albums/album_service.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn get_album_tracks(&self, album_id: i32, pagination: Pagination) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pagination` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osse` (bin "osse") due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated functions `limit` and `offset` are never used [INFO] [stdout] --> src/entities/util.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 4 | impl Pagination { [INFO] [stdout] | --------------- associated functions in this implementation [INFO] [stdout] 5 | pub fn limit(limit: i64) -> Self {Pagination(0, limit)} [INFO] [stdout] | ^^^^^ [INFO] [stdout] 6 | pub fn offset(offset: i64) -> Self {Pagination(offset, -1)} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_album_tracks` is never used [INFO] [stdout] --> src/api/albums/album_service.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl AlbumService { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn get_album_tracks(&self, album_id: i32, pagination: Pagination) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:10 [INFO] [stdout] | [INFO] [stdout] 47 | let db = match Pool::builder().test_on_check_out(true).build(pool) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(c) => c, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cors = Cors::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let app = Route::new() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 20 | let file = File::open(path); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut file = match file { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(val) => val, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | match serde_json::from_str(&contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files/mod.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 10 | let files = match fs::read_dir(&dir) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Ok(files) => files, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Err(_err) => return Err(FileError::DirectoryError) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(get_files_in_dir(files)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osse` (bin "osse" test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c0e3c2c5214a8eef9c6e5d5f3e537a6e7b3629751e31959fe62f9f1c0d11893b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0e3c2c5214a8eef9c6e5d5f3e537a6e7b3629751e31959fe62f9f1c0d11893b", kill_on_drop: false }` [INFO] [stdout] c0e3c2c5214a8eef9c6e5d5f3e537a6e7b3629751e31959fe62f9f1c0d11893b