[INFO] cloning repository https://github.com/ZixuanSong/zsonkorp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZixuanSong/zsonkorp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZixuanSong%2Fzsonkorp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZixuanSong%2Fzsonkorp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3356fd98aacd51b6410022f14771c4991fd4818a [INFO] checking ZixuanSong/zsonkorp/3356fd98aacd51b6410022f14771c4991fd4818a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZixuanSong%2Fzsonkorp" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ZixuanSong/zsonkorp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ZixuanSong/zsonkorp [INFO] finished tweaking git repo https://github.com/ZixuanSong/zsonkorp [INFO] tweaked toml for git repo https://github.com/ZixuanSong/zsonkorp written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ZixuanSong/zsonkorp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62d4deff242cdb453d8f5fdd8f194de9ec0797bf84d16134e08807d1df3c2941 [INFO] running `Command { std: "docker" "start" "-a" "62d4deff242cdb453d8f5fdd8f194de9ec0797bf84d16134e08807d1df3c2941", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62d4deff242cdb453d8f5fdd8f194de9ec0797bf84d16134e08807d1df3c2941", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62d4deff242cdb453d8f5fdd8f194de9ec0797bf84d16134e08807d1df3c2941", kill_on_drop: false }` [INFO] [stdout] 62d4deff242cdb453d8f5fdd8f194de9ec0797bf84d16134e08807d1df3c2941 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dac0f9fa330d9e1799d3ac6c12500acdac8711edc6202c1b14984c0405fa2615 [INFO] running `Command { std: "docker" "start" "-a" "dac0f9fa330d9e1799d3ac6c12500acdac8711edc6202c1b14984c0405fa2615", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling axum-core v0.4.0 [INFO] [stderr] Compiling axum v0.7.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking tokio v1.34.0 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.0 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v1.0.1 [INFO] [stderr] Checking hyper-util v0.1.1 [INFO] [stderr] Checking zsonkorp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `axum::response::IntoResponse` [INFO] [stdout] --> src/game.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::response::IntoResponse; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/game/fts.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/game/fts.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/player.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Deserializer, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/handlers.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::{anyhow, Error}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `GameTransition` and `Transition` [INFO] [stdout] --> src/transition/cta.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::transition::{GameTransition, Transition}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::response::IntoResponse` [INFO] [stdout] --> src/game.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::response::IntoResponse; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/game/fts.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/player.rs:3:40 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{Deserialize, Deserializer, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/handlers.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::{anyhow, Error}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `GameTransition` and `Transition` [INFO] [stdout] --> src/transition/cta.rs:2:25 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::transition::{GameTransition, Transition}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `transition` [INFO] [stdout] --> src/game/cta.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | fn transition(&mut self, transition: Transition) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_transition` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game_storage.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | let mut game = self.map.get_mut(id)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `transition` [INFO] [stdout] --> src/game/cta.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | fn transition(&mut self, transition: Transition) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_transition` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `split`, `deal`, and `get_dealt_cards` are never used [INFO] [stdout] --> src/deck.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Deck { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 17 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn split(&mut self, index: usize) -> Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn deal(&mut self) -> Option<&Card> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn get_dealt_cards(&self) -> &[Card] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Generic` is never constructed [INFO] [stdout] --> src/game.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 18 | #[error("Generic game error")] [INFO] [stdout] 19 | Generic, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cta` is never constructed [INFO] [stdout] --> src/game/cta.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Cta { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `apply_config` are never used [INFO] [stdout] --> src/game/cta.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Cta { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(config: config::Cta) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | fn apply_config(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cta` is never constructed [INFO] [stdout] --> src/config/cta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Cta { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get_base_config` are never used [INFO] [stdout] --> src/config/cta.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Cta { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(wagers: HashMap>>, house_id: String) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn get_base_config(&self) -> &Config { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Started` is never constructed [INFO] [stdout] --> src/state.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum GameState { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 7 | Setup, [INFO] [stdout] 8 | Started, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Cta` is never constructed [INFO] [stdout] --> src/state.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum State { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 15 | Game(GameState), [INFO] [stdout] 16 | Cta(CtaState) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `AwaitCut` is never constructed [INFO] [stdout] --> src/state/cta.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum CtaState { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 3 | AwaitCut [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CtaState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `remove_game` is never used [INFO] [stdout] --> src/game_storage.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl GameStorage { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn remove_game(&mut self, id: &str) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get_amount` are never used [INFO] [stdout] --> src/wager.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Wager { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] 12 | pub fn new(id: u32, wager_type: T, amount: i32) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn get_amount(&self) -> &i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LossExceedsWagerAmount` is never constructed [INFO] [stdout] --> src/payout.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 11 | LossExceedsWagerAmount(String, i32, i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `endInc` should have a snake case name [INFO] [stdout] --> src/game/fts.rs:45:48 [INFO] [stdout] | [INFO] [stdout] 45 | FtsWagerType::FlopRange(_, endInc) => *endInc [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `end_inc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(wagers: HashMap>>, house_id: String) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Config { wagers, house_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 27 | fn from(value: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wager.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(id: u32, wager_type: T, amount: i32) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Wager { id, wager_type, amount }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zsonkorp` (bin "zsonkorp") due to 4 previous errors; 21 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game_storage.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | let mut game = self.map.get_mut(id)?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_card_rank_suit_mix` is never used [INFO] [stdout] --> src/card.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 172 | fn create_card_rank_suit_mix() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `deal` and `get_dealt_cards` are never used [INFO] [stdout] --> src/deck.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl Deck { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn deal(&mut self) -> Option<&Card> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | pub fn get_dealt_cards(&self) -> &[Card] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Generic` is never constructed [INFO] [stdout] --> src/game.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 18 | #[error("Generic game error")] [INFO] [stdout] 19 | Generic, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cta` is never constructed [INFO] [stdout] --> src/game/cta.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Cta { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `apply_config` are never used [INFO] [stdout] --> src/game/cta.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Cta { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(config: config::Cta) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | fn apply_config(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cta` is never constructed [INFO] [stdout] --> src/config/cta.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Cta { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `get_base_config` are never used [INFO] [stdout] --> src/config/cta.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Cta { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 19 | pub fn new(wagers: HashMap>>, house_id: String) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn get_base_config(&self) -> &Config { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Started` is never constructed [INFO] [stdout] --> src/state.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum GameState { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 7 | Setup, [INFO] [stdout] 8 | Started, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Cta` is never constructed [INFO] [stdout] --> src/state.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum State { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 15 | Game(GameState), [INFO] [stdout] 16 | Cta(CtaState) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `AwaitCut` is never constructed [INFO] [stdout] --> src/state/cta.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub enum CtaState { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 3 | AwaitCut [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CtaState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `remove_game` is never used [INFO] [stdout] --> src/game_storage.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl GameStorage { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 27 | pub fn remove_game(&mut self, id: &str) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_amount` is never used [INFO] [stdout] --> src/wager.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Wager { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 32 | pub fn get_amount(&self) -> &i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LossExceedsWagerAmount` is never constructed [INFO] [stdout] --> src/payout.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 7 | enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 11 | LossExceedsWagerAmount(String, i32, i32), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `endInc` should have a snake case name [INFO] [stdout] --> src/game/fts.rs:45:48 [INFO] [stdout] | [INFO] [stdout] 45 | FtsWagerType::FlopRange(_, endInc) => *endInc [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `end_inc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(wagers: HashMap>>, house_id: String) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Config { wagers, house_id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 27 | fn from(value: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wager.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(id: u32, wager_type: T, amount: i32) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Wager { id, wager_type, amount }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zsonkorp` (bin "zsonkorp" test) due to 4 previous errors; 21 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dac0f9fa330d9e1799d3ac6c12500acdac8711edc6202c1b14984c0405fa2615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dac0f9fa330d9e1799d3ac6c12500acdac8711edc6202c1b14984c0405fa2615", kill_on_drop: false }` [INFO] [stdout] dac0f9fa330d9e1799d3ac6c12500acdac8711edc6202c1b14984c0405fa2615