[INFO] cloning repository https://github.com/ZhiXiao-Lin/rust-kvm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZhiXiao-Lin/rust-kvm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhiXiao-Lin%2Frust-kvm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhiXiao-Lin%2Frust-kvm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a6d45fef927d1a513af05d0d082010c8a9c62d47 [INFO] checking ZhiXiao-Lin/rust-kvm/a6d45fef927d1a513af05d0d082010c8a9c62d47 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZhiXiao-Lin%2Frust-kvm" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ZhiXiao-Lin/rust-kvm on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ZhiXiao-Lin/rust-kvm [INFO] finished tweaking git repo https://github.com/ZhiXiao-Lin/rust-kvm [INFO] tweaked toml for git repo https://github.com/ZhiXiao-Lin/rust-kvm written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ZhiXiao-Lin/rust-kvm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-1-tc2/source/crates/kvm/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /workspace/builds/worker-1-tc2/source/crates/kvm-ioctls/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /workspace/builds/worker-1-tc2/source/crates/kvm-bindings/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4c598164d6cc24a9332dd482724138f12c3b4dafa042f0ec632fb8a41c348ce [INFO] running `Command { std: "docker" "start" "-a" "d4c598164d6cc24a9332dd482724138f12c3b4dafa042f0ec632fb8a41c348ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4c598164d6cc24a9332dd482724138f12c3b4dafa042f0ec632fb8a41c348ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4c598164d6cc24a9332dd482724138f12c3b4dafa042f0ec632fb8a41c348ce", kill_on_drop: false }` [INFO] [stdout] d4c598164d6cc24a9332dd482724138f12c3b4dafa042f0ec632fb8a41c348ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e8124e41333e078047a4c374e7e533e3ac0440910646d1d949d575716639713 [INFO] running `Command { std: "docker" "start" "-a" "1e8124e41333e078047a4c374e7e533e3ac0440910646d1d949d575716639713", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/crates/kvm-bindings/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /opt/rustwide/workdir/crates/kvm-ioctls/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] warning: /opt/rustwide/workdir/crates/kvm/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling kvm-ioctls v0.11.0 (/opt/rustwide/workdir/crates/kvm-ioctls) [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling serde_json v1.0.78 [INFO] [stderr] Checking vmm-sys-util v0.9.0 (/opt/rustwide/workdir/crates/vmm-sys-util) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> crates/vmm-sys-util/src/linux/sock_ctrl_msg.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_ptr_alignment))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `serde`, `serde_derive`, and `with-serde` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> crates/vmm-sys-util/src/linux/sock_ctrl_msg.rs:445:16 [INFO] [stdout] | [INFO] [stdout] 445 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::useless_asref))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `serde`, `serde_derive`, and `with-serde` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/linux/epoll.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 209 | Ok(Epoll { epoll_fd }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/linux/sock_ctrl_msg.rs:345:29 [INFO] [stdout] | [INFO] [stdout] 344 | fn send_with_fd(&self, buf: D, fd: RawFd) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | self.send_with_fds(&[buf], &[fd]) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/linux/sock_ctrl_msg.rs:384:12 [INFO] [stdout] | [INFO] [stdout] 377 | let file = if fd_count == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | Ok((read_count, file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/unix/tempdir.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new_with_prefix>(prefix: P) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let dir_name = CString::new(dir_string.into_vec()).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(TempDir { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | path: PathBuf::from(OsString::from_vec(dir_bytes)), [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/fam.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 202 | let mut mem_allocator = Vec::with_capacity(required_mem_allocator_capacity); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(FamStructWrapper { mem_allocator }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/tempfile.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new_with_prefix>(prefix: P) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(TempFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | path: file_path_buf, [INFO] [stdout] 71 | | file: Some(file), [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/vmm-sys-util/src/tempfile.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn into_file(mut self) -> File { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | self.file.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vmm-sys-util` (lib) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1e8124e41333e078047a4c374e7e533e3ac0440910646d1d949d575716639713", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e8124e41333e078047a4c374e7e533e3ac0440910646d1d949d575716639713", kill_on_drop: false }` [INFO] [stdout] 1e8124e41333e078047a4c374e7e533e3ac0440910646d1d949d575716639713