[INFO] cloning repository https://github.com/ZetaNumbers/rust-psvita [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZetaNumbers/rust-psvita" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZetaNumbers%2Frust-psvita", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZetaNumbers%2Frust-psvita'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f431608b3dee5b864467a3fb12ed086388799b8 [INFO] checking ZetaNumbers/rust-psvita/5f431608b3dee5b864467a3fb12ed086388799b8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZetaNumbers%2Frust-psvita" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ZetaNumbers/rust-psvita on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ZetaNumbers/rust-psvita [INFO] finished tweaking git repo https://github.com/ZetaNumbers/rust-psvita [INFO] tweaked toml for git repo https://github.com/ZetaNumbers/rust-psvita written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ZetaNumbers/rust-psvita already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcece2ae868c5bbecc2a6f2233f7edab2107e07961fabad8c6d9d6d99648b3e9 [INFO] running `Command { std: "docker" "start" "-a" "dcece2ae868c5bbecc2a6f2233f7edab2107e07961fabad8c6d9d6d99648b3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcece2ae868c5bbecc2a6f2233f7edab2107e07961fabad8c6d9d6d99648b3e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcece2ae868c5bbecc2a6f2233f7edab2107e07961fabad8c6d9d6d99648b3e9", kill_on_drop: false }` [INFO] [stdout] dcece2ae868c5bbecc2a6f2233f7edab2107e07961fabad8c6d9d6d99648b3e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ae167e81ed7fe0ba184105f094277670f963c1892206b49d70e28558f7a622d [INFO] running `Command { std: "docker" "start" "-a" "6ae167e81ed7fe0ba184105f094277670f963c1892206b49d70e28558f7a622d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling beef v0.5.1 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling utf8-ranges v1.0.4 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking ucd-trie v0.1.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking pest v2.1.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling camino v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking semver-parser v0.10.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling logos-derive v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling remain v0.2.2 [INFO] [stderr] Compiling structopt-derive v0.4.16 [INFO] [stderr] Compiling bytemuck_derive v1.0.1 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking psvita-sce-types v0.1.0 (/opt/rustwide/workdir/psvita-sce-types) [INFO] [stderr] Checking structopt v0.3.23 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking compat-args v0.1.0 (/opt/rustwide/workdir/psvita-linker/compat-args) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/lib.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn map_iter<'a, I>(&'a self, iter: I) -> impl Iterator + 'a [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: iter.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/flag.rs:47:46 [INFO] [stdout] | [INFO] [stdout] 47 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(producer))), [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/long.rs:47:55 [INFO] [stdout] | [INFO] [stdout] 41 | parser: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let parser = Box::new(move |s: String| parser(s.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/long.rs:49:46 [INFO] [stdout] | [INFO] [stdout] 49 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(parser))), [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/short.rs:71:55 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn try_insert(&mut self, name: [u8; 2], parser: F) -> Result<(), DuplicateShortError> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let parser = Box::new(move |s: String| parser(s.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/short.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(parser))), [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/lib.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn map_iter<'a, I>(&'a self, iter: I) -> impl Iterator + 'a [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | inner: iter.peekable(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compat-args` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/flag.rs:47:46 [INFO] [stdout] | [INFO] [stdout] 47 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(producer))), [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/long.rs:47:55 [INFO] [stdout] | [INFO] [stdout] 41 | parser: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let parser = Box::new(move |s: String| parser(s.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/long.rs:49:46 [INFO] [stdout] | [INFO] [stdout] 49 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(parser))), [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> psvita-linker/compat-args/src/short.rs:71:55 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn try_insert(&mut self, name: [u8; 2], parser: F) -> Result<(), DuplicateShortError> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let parser = Box::new(move |s: String| parser(s.into())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> psvita-linker/compat-args/src/short.rs:73:46 [INFO] [stdout] | [INFO] [stdout] 73 | hash_map::Entry::Vacant(e) => Ok(drop(e.insert(parser))), [INFO] [stdout] | ^^^^^----------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Box A>` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compat-args` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6ae167e81ed7fe0ba184105f094277670f963c1892206b49d70e28558f7a622d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ae167e81ed7fe0ba184105f094277670f963c1892206b49d70e28558f7a622d", kill_on_drop: false }` [INFO] [stdout] 6ae167e81ed7fe0ba184105f094277670f963c1892206b49d70e28558f7a622d