[INFO] cloning repository https://github.com/Zerthox/finite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Zerthox/finite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZerthox%2Ffinite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZerthox%2Ffinite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aa3b738716c462ac11daa4fad9bf4c2140649c69 [INFO] checking Zerthox/finite/aa3b738716c462ac11daa4fad9bf4c2140649c69 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZerthox%2Ffinite" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Zerthox/finite on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Zerthox/finite [INFO] finished tweaking git repo https://github.com/Zerthox/finite [INFO] tweaked toml for git repo https://github.com/Zerthox/finite written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Zerthox/finite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24a64676b246d303d7d4f7b9e96685ece9b55198950d1b9b796f01e3b8592765 [INFO] running `Command { std: "docker" "start" "-a" "24a64676b246d303d7d4f7b9e96685ece9b55198950d1b9b796f01e3b8592765", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24a64676b246d303d7d4f7b9e96685ece9b55198950d1b9b796f01e3b8592765", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24a64676b246d303d7d4f7b9e96685ece9b55198950d1b9b796f01e3b8592765", kill_on_drop: false }` [INFO] [stdout] 24a64676b246d303d7d4f7b9e96685ece9b55198950d1b9b796f01e3b8592765 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8305385240e3224562544bf0832e674a6d74c0147ccdab6f0b0b3d7ce1920bcf [INFO] running `Command { std: "docker" "start" "-a" "8305385240e3224562544bf0832e674a6d74c0147ccdab6f0b0b3d7ce1920bcf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking dtoa v0.4.6 [INFO] [stderr] Checking yaml-rust v0.4.4 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking serde_yaml v0.8.13 [INFO] [stderr] Checking finite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_map(initial: S, states: M) -> Self [INFO] [stdout] | ---------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let map = states.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Self { [INFO] [stdout] 55 | current: if map.contains_key(&initial) { [INFO] [stdout] | ______________________^ [INFO] [stdout] 56 | | Some(initial) [INFO] [stdout] 57 | | } else { [INFO] [stdout] 58 | | None [INFO] [stdout] 59 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_map(initial: S, states: M) -> Self [INFO] [stdout] | ---------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let map = states.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | states: map [INFO] [stdout] | _____________________^ [INFO] [stdout] 61 | | .into_iter() [INFO] [stdout] 62 | | .map(|(state, (accepts, transitions))| (state, State::new(accepts, transitions))) [INFO] [stdout] 63 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:62:52 [INFO] [stdout] | [INFO] [stdout] 62 | .map(|(state, (accepts, transitions))| (state, State::new(accepts, transitions))) [INFO] [stdout] | ------------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:71:51 [INFO] [stdout] | [INFO] [stdout] 71 | .ok_or_else(|| AutomatonError::InexistentState(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | .ok_or_else(|| AutomatonError::InexistentState(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:150:4 [INFO] [stdout] | [INFO] [stdout] 143 | fn into(self) -> NFA { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | let mut set = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / self.states [INFO] [stdout] 151 | | .into_iter() [INFO] [stdout] 152 | | .map(|(id, state)| { [INFO] [stdout] 153 | | ( [INFO] [stdout] ... | [INFO] [stdout] 168 | | }) [INFO] [stdout] 169 | | .collect::>)>>(), [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dfa.rs:155:7 [INFO] [stdout] | [INFO] [stdout] 152 | .map(|(id, state)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | / ( [INFO] [stdout] 156 | | state.accepts, [INFO] [stdout] 157 | | state [INFO] [stdout] 158 | | .transitions [INFO] [stdout] ... | [INFO] [stdout] 165 | | .collect(), [INFO] [stdout] 166 | | ), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn from_map(initial: HashSet, states: M) -> Self [INFO] [stdout] | ------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let map = states.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | states: map [INFO] [stdout] | _____________________^ [INFO] [stdout] 58 | | .into_iter() [INFO] [stdout] 59 | | .map(|(state, (accepts, transitions))| (state, State::new(accepts, transitions))) [INFO] [stdout] 60 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | .map(|(state, (accepts, transitions))| (state, State::new(accepts, transitions))) [INFO] [stdout] | ------------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | .ok_or_else(|| AutomatonError::InexistentState(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:75:51 [INFO] [stdout] | [INFO] [stdout] 75 | .ok_or_else(|| AutomatonError::InexistentState(id.clone())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:135:14 [INFO] [stdout] | [INFO] [stdout] 135 | .any(|el| self.get_state(el).unwrap().accepts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nfa.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 155 | fn into(self) -> DFA, I> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let size = 1 << self.states.len(); [INFO] [stdout] 157 | let mut states = HashMap::with_capacity(size - 1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | DFA::from_map(self.current.into_iter().collect(), states) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `finite` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8305385240e3224562544bf0832e674a6d74c0147ccdab6f0b0b3d7ce1920bcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8305385240e3224562544bf0832e674a6d74c0147ccdab6f0b0b3d7ce1920bcf", kill_on_drop: false }` [INFO] [stdout] 8305385240e3224562544bf0832e674a6d74c0147ccdab6f0b0b3d7ce1920bcf