[INFO] cloning repository https://github.com/Zengor/chat_np1 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Zengor/chat_np1" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZengor%2Fchat_np1", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZengor%2Fchat_np1'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 74c8d54daffea6d844cea979c4e61f916ecd9954 [INFO] checking Zengor/chat_np1/74c8d54daffea6d844cea979c4e61f916ecd9954 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZengor%2Fchat_np1" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Zengor/chat_np1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Zengor/chat_np1 [INFO] finished tweaking git repo https://github.com/Zengor/chat_np1 [INFO] tweaked toml for git repo https://github.com/Zengor/chat_np1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Zengor/chat_np1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77faca4d2cbd6f998e70c2aa3aa6cb867864e31f5918990647b550e964912c68 [INFO] running `Command { std: "docker" "start" "-a" "77faca4d2cbd6f998e70c2aa3aa6cb867864e31f5918990647b550e964912c68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77faca4d2cbd6f998e70c2aa3aa6cb867864e31f5918990647b550e964912c68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77faca4d2cbd6f998e70c2aa3aa6cb867864e31f5918990647b550e964912c68", kill_on_drop: false }` [INFO] [stdout] 77faca4d2cbd6f998e70c2aa3aa6cb867864e31f5918990647b550e964912c68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b053076454961e89ab139645d15c13a8ec8dd5b87db2c95d63c6ee4310cafcf9 [INFO] running `Command { std: "docker" "start" "-a" "b053076454961e89ab139645d15c13a8ec8dd5b87db2c95d63c6ee4310cafcf9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking lazy_static v0.2.8 [INFO] [stderr] Checking chat_np1 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/chatserver.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / lazy_static! { [INFO] [stdout] 15 | | static ref CONNECTIONS: Connections = Default::default(); [INFO] [stdout] 16 | | static ref GROUPS: Groups = Default::default(); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let mut group = match groups.get_mut(&group_name) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut group = match groups.get_mut(&chat_name) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | let mut group = groups.get_mut(&chat_name).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/chatserver.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 241 | struct UserConnection { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 244 | thread: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UserConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/chatclient.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct ChatConnection { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | thread: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ChatConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatserver.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 225 | fn send_chat_message_to_user>(username: String, contents: S) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | CONNECTIONS.lock().expect("send chat lock").get_mut(&username).expect("send chat get") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatserver.rs:269:10 [INFO] [stdout] | [INFO] [stdout] 264 | fn start_listening(sender: Sender, socket: TcpStream) [INFO] [stdout] | -------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | -> (thread::JoinHandle<()>, mpsc::Sender<()>) { [INFO] [stdout] 266 | let sender = sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | let (snd, rcv) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let snd_clone = snd.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | (thread::spawn(move || { [INFO] [stdout] | __________^ [INFO] [stdout] 270 | | let mut buf = Vec::new(); [INFO] [stdout] 271 | | let mut reader = BufReader::new(socket); [INFO] [stdout] 272 | | let mut read_bytes = 0; [INFO] [stdout] ... | [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | }), snd_clone) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatclient.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn start_listening(sender: mpsc::Sender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | socket:TcpStream, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | terminate: Arc) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let sender = sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 42 | | let mut buf = Vec::new(); [INFO] [stdout] 43 | | let mut reader = BufReader::new(socket); [INFO] [stdout] 44 | | let mut read_bytes = 0; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chat_np1` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | let mut group = match groups.get_mut(&group_name) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut group = match groups.get_mut(&chat_name) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/chatserver.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | let mut group = groups.get_mut(&chat_name).unwrap(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/chatserver.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 241 | struct UserConnection { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 244 | thread: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UserConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `thread` is never read [INFO] [stdout] --> src/chatclient.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct ChatConnection { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | thread: thread::JoinHandle<()> [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ChatConnection` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatserver.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 225 | fn send_chat_message_to_user>(username: String, contents: S) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | CONNECTIONS.lock().expect("send chat lock").get_mut(&username).expect("send chat get") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatserver.rs:269:10 [INFO] [stdout] | [INFO] [stdout] 264 | fn start_listening(sender: Sender, socket: TcpStream) [INFO] [stdout] | -------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | -> (thread::JoinHandle<()>, mpsc::Sender<()>) { [INFO] [stdout] 266 | let sender = sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 267 | let (snd, rcv) = mpsc::channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let snd_clone = snd.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | (thread::spawn(move || { [INFO] [stdout] | __________^ [INFO] [stdout] 270 | | let mut buf = Vec::new(); [INFO] [stdout] 271 | | let mut reader = BufReader::new(socket); [INFO] [stdout] 272 | | let mut read_bytes = 0; [INFO] [stdout] ... | [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | }), snd_clone) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chatclient.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn start_listening(sender: mpsc::Sender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | socket:TcpStream, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | terminate: Arc) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let sender = sender.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 42 | | let mut buf = Vec::new(); [INFO] [stdout] 43 | | let mut reader = BufReader::new(socket); [INFO] [stdout] 44 | | let mut read_bytes = 0; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chat_np1` (lib) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b053076454961e89ab139645d15c13a8ec8dd5b87db2c95d63c6ee4310cafcf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b053076454961e89ab139645d15c13a8ec8dd5b87db2c95d63c6ee4310cafcf9", kill_on_drop: false }` [INFO] [stdout] b053076454961e89ab139645d15c13a8ec8dd5b87db2c95d63c6ee4310cafcf9