[INFO] cloning repository https://github.com/ZenDarva/Webserver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ZenDarva/Webserver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZenDarva%2FWebserver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZenDarva%2FWebserver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 379495aa1c2258e27e0270cb81ffdae46b06a09c [INFO] checking ZenDarva/Webserver/379495aa1c2258e27e0270cb81ffdae46b06a09c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FZenDarva%2FWebserver" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ZenDarva/Webserver on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ZenDarva/Webserver [INFO] finished tweaking git repo https://github.com/ZenDarva/Webserver [INFO] tweaked toml for git repo https://github.com/ZenDarva/Webserver written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ZenDarva/Webserver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf7508546bf31fb7af09aa4ba162f38116d51e78f0939ff0705b382294718e5a [INFO] running `Command { std: "docker" "start" "-a" "bf7508546bf31fb7af09aa4ba162f38116d51e78f0939ff0705b382294718e5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf7508546bf31fb7af09aa4ba162f38116d51e78f0939ff0705b382294718e5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf7508546bf31fb7af09aa4ba162f38116d51e78f0939ff0705b382294718e5a", kill_on_drop: false }` [INFO] [stdout] bf7508546bf31fb7af09aa4ba162f38116d51e78f0939ff0705b382294718e5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f61725f5f0d881c2f7466fc80c87c22eb218319328a5877c5c19de140697c45 [INFO] running `Command { std: "docker" "start" "-a" "0f61725f5f0d881c2f7466fc80c87c22eb218319328a5877c5c19de140697c45", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking webserver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufRead`, `BufReader`, and `Write` [INFO] [stdout] --> src/main.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{BufRead, BufReader, Error, ErrorKind, Read, Write}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IpAddr` and `Shutdown` [INFO] [stdout] --> src/main.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | use std::net::{IpAddr, Shutdown, SocketAddr, TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/HttpRequest.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, BufReader, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/HttpRequest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/HttpRequest.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null` [INFO] [stdout] --> src/HttpRequest.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ptr::null; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/Configuration.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead`, `BufReader`, and `Write` [INFO] [stdout] --> src/main.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::{BufRead, BufReader, Error, ErrorKind, Read, Write}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IpAddr` and `Shutdown` [INFO] [stdout] --> src/main.rs:8:16 [INFO] [stdout] | [INFO] [stdout] 8 | use std::net::{IpAddr, Shutdown, SocketAddr, TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/HttpRequest.rs:3:35 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, BufReader, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Borrow` [INFO] [stdout] --> src/HttpRequest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/HttpRequest.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ptr::null` [INFO] [stdout] --> src/HttpRequest.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::ptr::null; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/Configuration.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/main.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | fn handle_request(stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `request_type` and `headers` are never read [INFO] [stdout] --> src/HttpRequest.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 10 | pub request_type: HttpRequestType, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | headers: HashMap, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `HttpRequest` should have a snake case name [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | mod HttpRequest; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `http_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Configuration` should have a snake case name [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | mod Configuration; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `configuration` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:15 [INFO] [stdout] | [INFO] [stdout] 29 | fn handle_request(stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut request = HttpRequest::HttpRequest::new(stream); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | match get_file_by_path(&request.path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webserver` (bin "webserver") due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/main.rs:29:42 [INFO] [stdout] | [INFO] [stdout] 29 | fn handle_request(stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `request_type` and `headers` are never read [INFO] [stdout] --> src/HttpRequest.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 10 | pub request_type: HttpRequestType, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | headers: HashMap, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `HttpRequest` should have a snake case name [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | mod HttpRequest; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `http_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Configuration` should have a snake case name [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | mod Configuration; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `configuration` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:31:15 [INFO] [stdout] | [INFO] [stdout] 29 | fn handle_request(stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let mut request = HttpRequest::HttpRequest::new(stream); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | match get_file_by_path(&request.path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webserver` (bin "webserver" test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f61725f5f0d881c2f7466fc80c87c22eb218319328a5877c5c19de140697c45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f61725f5f0d881c2f7466fc80c87c22eb218319328a5877c5c19de140697c45", kill_on_drop: false }` [INFO] [stdout] 0f61725f5f0d881c2f7466fc80c87c22eb218319328a5877c5c19de140697c45