[INFO] cloning repository https://github.com/Yuki-iso/dragonprint [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Yuki-iso/dragonprint" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuki-iso%2Fdragonprint", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuki-iso%2Fdragonprint'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 297de14f4ec8ab70be6569a789df3ffeb8ef713d [INFO] checking Yuki-iso/dragonprint/297de14f4ec8ab70be6569a789df3ffeb8ef713d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuki-iso%2Fdragonprint" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Yuki-iso/dragonprint on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Yuki-iso/dragonprint [INFO] finished tweaking git repo https://github.com/Yuki-iso/dragonprint [INFO] tweaked toml for git repo https://github.com/Yuki-iso/dragonprint written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Yuki-iso/dragonprint already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed759f3c73b83e944b10e248df872231bdcea48a52cc80a859d7e35a9d1e4fc5 [INFO] running `Command { std: "docker" "start" "-a" "ed759f3c73b83e944b10e248df872231bdcea48a52cc80a859d7e35a9d1e4fc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed759f3c73b83e944b10e248df872231bdcea48a52cc80a859d7e35a9d1e4fc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed759f3c73b83e944b10e248df872231bdcea48a52cc80a859d7e35a9d1e4fc5", kill_on_drop: false }` [INFO] [stdout] ed759f3c73b83e944b10e248df872231bdcea48a52cc80a859d7e35a9d1e4fc5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7df31baaf7a60221e4573661fe95bc41c5b7dba3200e4e9e40c041a03b2940e6 [INFO] running `Command { std: "docker" "start" "-a" "7df31baaf7a60221e4573661fe95bc41c5b7dba3200e4e9e40c041a03b2940e6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling substring v1.4.5 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dragonprint v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/main.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | if let Some((w, h)) = term_size::dimensions() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `text` is never read [INFO] [stdout] --> src/main.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut text = Vec::::new(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `finalstr` [INFO] [stdout] --> src/main.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let mut finalstr = String::from("Hello, world!"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_finalstr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | fn sayy(mut inp: String) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut signpre = r"| | "; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | let mut finalstr = String::from("Hello, world!"); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/main.rs:33:4 [INFO] [stdout] | [INFO] [stdout] 33 | fn print_type_of(_: &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generateString` should have a snake case name [INFO] [stdout] --> src/main.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn generateString() -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `generate_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:90:4 [INFO] [stdout] | [INFO] [stdout] 90 | fn formatString(mut input: String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 118 | fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let file = File::open(filename).expect("no such file (please put it in home)"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / buf.lines() [INFO] [stdout] 122 | | .map(|l| l.expect("Could not parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dragonprint` (bin "dragonprint" test) due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/main.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | if let Some((w, h)) = term_size::dimensions() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `text` is never read [INFO] [stdout] --> src/main.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | let mut text = Vec::::new(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `finalstr` [INFO] [stdout] --> src/main.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let mut finalstr = String::from("Hello, world!"); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_finalstr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | fn sayy(mut inp: String) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | let mut signpre = r"| | "; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | let mut finalstr = String::from("Hello, world!"); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_type_of` is never used [INFO] [stdout] --> src/main.rs:33:4 [INFO] [stdout] | [INFO] [stdout] 33 | fn print_type_of(_: &T) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `generateString` should have a snake case name [INFO] [stdout] --> src/main.rs:81:4 [INFO] [stdout] | [INFO] [stdout] 81 | fn generateString() -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `generate_string` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `formatString` should have a snake case name [INFO] [stdout] --> src/main.rs:90:4 [INFO] [stdout] | [INFO] [stdout] 90 | fn formatString(mut input: String) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `format_string` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 118 | fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let file = File::open(filename).expect("no such file (please put it in home)"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / buf.lines() [INFO] [stdout] 122 | | .map(|l| l.expect("Could not parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dragonprint` (bin "dragonprint") due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7df31baaf7a60221e4573661fe95bc41c5b7dba3200e4e9e40c041a03b2940e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7df31baaf7a60221e4573661fe95bc41c5b7dba3200e4e9e40c041a03b2940e6", kill_on_drop: false }` [INFO] [stdout] 7df31baaf7a60221e4573661fe95bc41c5b7dba3200e4e9e40c041a03b2940e6