[INFO] cloning repository https://github.com/Yuhanun/trilion_poker_server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Yuhanun/trilion_poker_server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuhanun%2Ftrilion_poker_server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuhanun%2Ftrilion_poker_server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3597b681ea98cab97d4dfe625c428de26479713e [INFO] checking Yuhanun/trilion_poker_server/3597b681ea98cab97d4dfe625c428de26479713e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYuhanun%2Ftrilion_poker_server" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Yuhanun/trilion_poker_server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Yuhanun/trilion_poker_server [INFO] finished tweaking git repo https://github.com/Yuhanun/trilion_poker_server [INFO] tweaked toml for git repo https://github.com/Yuhanun/trilion_poker_server written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Yuhanun/trilion_poker_server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3e65ea8adac7690c5d3e1aface00b2edb774f844ece83d5b92135b9d6ecf2b9 [INFO] running `Command { std: "docker" "start" "-a" "e3e65ea8adac7690c5d3e1aface00b2edb774f844ece83d5b92135b9d6ecf2b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3e65ea8adac7690c5d3e1aface00b2edb774f844ece83d5b92135b9d6ecf2b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3e65ea8adac7690c5d3e1aface00b2edb774f844ece83d5b92135b9d6ecf2b9", kill_on_drop: false }` [INFO] [stdout] e3e65ea8adac7690c5d3e1aface00b2edb774f844ece83d5b92135b9d6ecf2b9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] acb48690aaea38f61130d5ab6359055514e63ec8e1eae16af2a109c1a73e321c [INFO] running `Command { std: "docker" "start" "-a" "acb48690aaea38f61130d5ab6359055514e63ec8e1eae16af2a109c1a73e321c", kill_on_drop: false }` [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking trilion_poker_server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `reader` and `writer` are never read [INFO] [stdout] --> src/connectioninfo.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct ConnectionInfo { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 7 | reader: std::io::BufReader, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | writer: std::io::BufWriter, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectionInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `send`, `send_str`, and `try_read` are never used [INFO] [stdout] --> src/connectioninfo.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl ConnectionInfo { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn send(&mut self, data: T) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn send_str(&mut self, data: &[u8]) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn try_read(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `games` is never read [INFO] [stdout] --> src/server.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Server { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | games: Arc>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck` and `players` are never read [INFO] [stdout] --> src/game.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Game { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | deck: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | players: Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn from(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | reader: std::io::BufReader::new(stream.try_clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `reader` and `writer` are never read [INFO] [stdout] --> src/connectioninfo.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct ConnectionInfo { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 7 | reader: std::io::BufReader, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | writer: std::io::BufWriter, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectionInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `send`, `send_str`, and `try_read` are never used [INFO] [stdout] --> src/connectioninfo.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl ConnectionInfo { [INFO] [stdout] | ------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn send(&mut self, data: T) -> bool [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn send_str(&mut self, data: &[u8]) -> std::io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub fn try_read(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `games` is never read [INFO] [stdout] --> src/server.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Server { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | games: Arc>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck` and `players` are never read [INFO] [stdout] --> src/game.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Game { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 6 | deck: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | players: Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn from(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | reader: std::io::BufReader::new(stream.try_clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn from(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | writer: std::io::BufWriter::new(stream.try_clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn send(&mut self, data: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let res = self.send_str(data.as_bytes()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match res.unwrap_err().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 46 | let res = self.reader.read_to_string(&mut data); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | res.map(|_| Some(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn from(stream: TcpStream) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | writer: std::io::BufWriter::new(stream.try_clone().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn send(&mut self, data: T) -> bool [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let res = self.send_str(data.as_bytes()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | match res.unwrap_err().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connectioninfo.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 46 | let res = self.reader.read_to_string(&mut data); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | res.map(|_| Some(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trilion_poker_server` (bin "trilion_poker_server" test) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trilion_poker_server` (bin "trilion_poker_server") due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "acb48690aaea38f61130d5ab6359055514e63ec8e1eae16af2a109c1a73e321c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acb48690aaea38f61130d5ab6359055514e63ec8e1eae16af2a109c1a73e321c", kill_on_drop: false }` [INFO] [stdout] acb48690aaea38f61130d5ab6359055514e63ec8e1eae16af2a109c1a73e321c