[INFO] cloning repository https://github.com/YouKnow-sys/saamt-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YouKnow-sys/saamt-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouKnow-sys%2Fsaamt-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouKnow-sys%2Fsaamt-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c24da70b83ec38557e2e0ba73e41738767991d4d [INFO] checking YouKnow-sys/saamt-rs/c24da70b83ec38557e2e0ba73e41738767991d4d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYouKnow-sys%2Fsaamt-rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YouKnow-sys/saamt-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YouKnow-sys/saamt-rs [INFO] finished tweaking git repo https://github.com/YouKnow-sys/saamt-rs [INFO] tweaked toml for git repo https://github.com/YouKnow-sys/saamt-rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YouKnow-sys/saamt-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0079e86fa15f9717b79d27ede7966eb8e735d67cd5e3ced31723d717523d81a [INFO] running `Command { std: "docker" "start" "-a" "e0079e86fa15f9717b79d27ede7966eb8e735d67cd5e3ced31723d717523d81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0079e86fa15f9717b79d27ede7966eb8e735d67cd5e3ced31723d717523d81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0079e86fa15f9717b79d27ede7966eb8e735d67cd5e3ced31723d717523d81a", kill_on_drop: false }` [INFO] [stdout] e0079e86fa15f9717b79d27ede7966eb8e735d67cd5e3ced31723d717523d81a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42e8c7d643fec5f5593424991c18eba2c0e97f42e241bb427a6164957aeac507 [INFO] running `Command { std: "docker" "start" "-a" "42e8c7d643fec5f5593424991c18eba2c0e97f42e241bb427a6164957aeac507", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.73 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling binrw_derive v0.13.3 [INFO] [stderr] Compiling thiserror v1.0.53 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling binrw v0.13.3 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Compiling anyhow v1.0.78 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Compiling quote v1.0.34 [INFO] [stderr] Compiling syn v2.0.44 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.53 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.12 [INFO] [stderr] Checking saamt-core v0.1.4 (/opt/rustwide/workdir/saamt-core) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/sfx/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn load(&self, sfx_pak: impl AsRef, logger: &mut impl Logger) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let reader = BufReader::new(File::open(sfx_pak)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(SfxArchive::new(reader, lookup, indexes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/sfx/mod.rs:189:20 [INFO] [stdout] | [INFO] [stdout] 184 | reader: BufReader, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | banks: Banks::new(reader, lookup), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 27 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / WalkDir::new(path) [INFO] [stdout] 32 | | .max_depth(depth) [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] 34 | | .filter_map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 46 | | None [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) fn generate_folder_list(path: impl AsRef, depth: usize) -> Vec { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | / WalkDir::new(path) [INFO] [stdout] 54 | | .max_depth(depth) [INFO] [stdout] 55 | | .into_iter() [INFO] [stdout] 56 | | .filter_map(|f| { [INFO] [stdout] 57 | | let f = f.ok()?; [INFO] [stdout] 58 | | f.path().is_dir().then(|| f.path().to_path_buf()) [INFO] [stdout] 59 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/vag/mod.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn from_wav(wav_path: impl AsRef, loop_mode: LoopMode) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | WAV2VAGEncoder::new(wav_path.as_ref(), loop_mode).map(|w2v| w2v.generate_vag()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `saamt-core` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/sfx/mod.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn load(&self, sfx_pak: impl AsRef, logger: &mut impl Logger) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let reader = BufReader::new(File::open(sfx_pak)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(SfxArchive::new(reader, lookup, indexes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/sfx/mod.rs:189:20 [INFO] [stdout] | [INFO] [stdout] 184 | reader: BufReader, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | banks: Banks::new(reader, lookup), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 27 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | / WalkDir::new(path) [INFO] [stdout] 32 | | .max_depth(depth) [INFO] [stdout] 33 | | .into_iter() [INFO] [stdout] 34 | | .filter_map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 46 | | None [INFO] [stdout] 47 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) fn generate_folder_list(path: impl AsRef, depth: usize) -> Vec { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | / WalkDir::new(path) [INFO] [stdout] 54 | | .max_depth(depth) [INFO] [stdout] 55 | | .into_iter() [INFO] [stdout] 56 | | .filter_map(|f| { [INFO] [stdout] 57 | | let f = f.ok()?; [INFO] [stdout] 58 | | f.path().is_dir().then(|| f.path().to_path_buf()) [INFO] [stdout] 59 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> saamt-core/src/utils/vag/mod.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn from_wav(wav_path: impl AsRef, loop_mode: LoopMode) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | WAV2VAGEncoder::new(wav_path.as_ref(), loop_mode).map(|w2v| w2v.generate_vag()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `saamt-core` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "42e8c7d643fec5f5593424991c18eba2c0e97f42e241bb427a6164957aeac507", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42e8c7d643fec5f5593424991c18eba2c0e97f42e241bb427a6164957aeac507", kill_on_drop: false }` [INFO] [stdout] 42e8c7d643fec5f5593424991c18eba2c0e97f42e241bb427a6164957aeac507