[INFO] updating cached repository https://github.com/Yoga07/sorts [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 39c1dd4a1e8b0db68f9a3d6629527b523ab10ef5 [INFO] checking Yoga07/sorts/39c1dd4a1e8b0db68f9a3d6629527b523ab10ef5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYoga07%2Fsorts" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Yoga07/sorts on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Yoga07/sorts [INFO] finished tweaking git repo https://github.com/Yoga07/sorts [INFO] tweaked toml for git repo https://github.com/Yoga07/sorts written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Yoga07/sorts already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `sorts` library target) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 471b1d4bbce9eb2ac323bc59903e0a16bf28522f71cf88d83c20ce0de81439a2 [INFO] running `Command { std: "docker" "start" "-a" "471b1d4bbce9eb2ac323bc59903e0a16bf28522f71cf88d83c20ce0de81439a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "471b1d4bbce9eb2ac323bc59903e0a16bf28522f71cf88d83c20ce0de81439a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "471b1d4bbce9eb2ac323bc59903e0a16bf28522f71cf88d83c20ce0de81439a2", kill_on_drop: false }` [INFO] [stdout] 471b1d4bbce9eb2ac323bc59903e0a16bf28522f71cf88d83c20ce0de81439a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aab0cb1af5f243911d48b3b5058832126dbbd251cad1bb03b27d65dc397bea08 [INFO] running `Command { std: "docker" "start" "-a" "aab0cb1af5f243911d48b3b5058832126dbbd251cad1bb03b27d65dc397bea08", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `sorts` library target) [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling autocfg v0.1.1 [INFO] [stderr] Compiling same-file v1.0.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.11 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking ascii v0.9.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling walkdir v2.2.7 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Compiling jni v0.10.2 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking combine v3.6.3 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking sorts v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/lib.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `JClass`, `JObject`, and `JValue` [INFO] [stdout] --> src/lib.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | use jni::objects::{JClass,JObject,JValue}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `_jobject`, `jarray`, `jobject`, and `jsize` [INFO] [stdout] --> src/lib.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | use jni::sys::{jint,jintArray,jsize,_jobject,jarray,jobject,jclass}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/lib.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `JClass`, `JObject`, and `JValue` [INFO] [stdout] --> src/lib.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | use jni::objects::{JClass,JObject,JValue}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `_jobject`, `jarray`, `jobject`, and `jsize` [INFO] [stdout] --> src/lib.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | use jni::sys::{jint,jintArray,jsize,_jobject,jarray,jobject,jclass}; [INFO] [stdout] | ^^^^^ ^^^^^^^^ ^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut x = env.get_array_length(array).unwrap() as usize; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | 1 => {&quicksort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 28 | 1 => {let _ = &quicksort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | 2 => {&selcsort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 29 | 2 => {let _ = &selcsort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn bucketsort(values: Vec, hasher: F) -> Vec [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut buckets: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / buckets.into_iter().flat_map(|mut bucket| { [INFO] [stdout] 31 | | bucket.values.sort(); [INFO] [stdout] 32 | | bucket.values [INFO] [stdout] 33 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let mut x = env.get_array_length(array).unwrap() as usize; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | 1 => {&quicksort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 28 | 1 => {let _ = &quicksort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | 2 => {&selcsort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 29 | 2 => {let _ = &selcsort(buf.as_mut_slice()); println!("Sorted:{:?}",&buf);}, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bucket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn bucketsort(values: Vec, hasher: F) -> Vec [INFO] [stdout] | -------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut buckets: Vec> = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / buckets.into_iter().flat_map(|mut bucket| { [INFO] [stdout] 31 | | bucket.values.sort(); [INFO] [stdout] 32 | | bucket.values [INFO] [stdout] 33 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sorts` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sorts` (lib) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aab0cb1af5f243911d48b3b5058832126dbbd251cad1bb03b27d65dc397bea08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aab0cb1af5f243911d48b3b5058832126dbbd251cad1bb03b27d65dc397bea08", kill_on_drop: false }` [INFO] [stdout] aab0cb1af5f243911d48b3b5058832126dbbd251cad1bb03b27d65dc397bea08