[INFO] updating cached repository https://github.com/Yatekii/reactor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 69903568cf5f360161f1b23e37d929e54a4885c0 [INFO] checking Yatekii/reactor/69903568cf5f360161f1b23e37d929e54a4885c0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYatekii%2Freactor" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Yatekii/reactor on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Yatekii/reactor [INFO] finished tweaking git repo https://github.com/Yatekii/reactor [INFO] tweaked toml for git repo https://github.com/Yatekii/reactor written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Yatekii/reactor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5a7b944cc5d114a6ddde8fd1f2c6f8842cd56eb594152f1eb17a0bd97b7f57bd [INFO] running `Command { std: "docker" "start" "-a" "5a7b944cc5d114a6ddde8fd1f2c6f8842cd56eb594152f1eb17a0bd97b7f57bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5a7b944cc5d114a6ddde8fd1f2c6f8842cd56eb594152f1eb17a0bd97b7f57bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a7b944cc5d114a6ddde8fd1f2c6f8842cd56eb594152f1eb17a0bd97b7f57bd", kill_on_drop: false }` [INFO] [stdout] 5a7b944cc5d114a6ddde8fd1f2c6f8842cd56eb594152f1eb17a0bd97b7f57bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5ed4aadab8c5d7957879c8fe55537a3217bd0810633863c04f67e169d6e9d4e [INFO] running `Command { std: "docker" "start" "-a" "f5ed4aadab8c5d7957879c8fe55537a3217bd0810633863c04f67e169d6e9d4e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.27 [INFO] [stderr] Compiling syn v0.15.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking reactor v0.1.0 (/opt/rustwide/workdir/reactor) [INFO] [stderr] Checking quote v0.6.11 [INFO] [stderr] Checking reactor-derive v0.1.0 (/opt/rustwide/workdir/reactor-derive) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> reactor-derive/src/lib.rs:70:109 [INFO] [stdout] | [INFO] [stdout] 70 | let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] 70 + let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> reactor-derive/src/lib.rs:70:109 [INFO] [stdout] | [INFO] [stdout] 70 | let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 70 - let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] 70 + let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::>(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> reactor-derive/src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 70 | let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let num_levels = t.iter().map(|v| v.1).fold(0, usize::max) + 1; [INFO] [stdout] 72 | let sub_state_definitions = t.into_iter().map(|v| v.0).collect::>(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | let sub_state_variants = generate_enum_variants(sub_state); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | [INFO] [stdout] 76 | let super_trait_impl = impl_state(root, sub_state); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / if sub_state_variants.is_empty() { [INFO] [stdout] 80 | | quote! { [INFO] [stdout] 81 | | #[derive(Copy, Clone, Debug)] [INFO] [stdout] 82 | | struct #sub_state_name(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reactor-derive` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> reactor-derive/src/lib.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 70 | let t = sub_state.sub_states.iter().map(|sub_state| assemble_from_sub_state(root, sub_state)).collect::<(Vec<_>)>(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let num_levels = t.iter().map(|v| v.1).fold(0, usize::max) + 1; [INFO] [stdout] 72 | let sub_state_definitions = t.into_iter().map(|v| v.0).collect::>(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | [INFO] [stdout] 74 | let sub_state_variants = generate_enum_variants(sub_state); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | [INFO] [stdout] 76 | let super_trait_impl = impl_state(root, sub_state); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / if sub_state_variants.is_empty() { [INFO] [stdout] 80 | | quote! { [INFO] [stdout] 81 | | #[derive(Copy, Clone, Debug)] [INFO] [stdout] 82 | | struct #sub_state_name(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reactor-derive` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f5ed4aadab8c5d7957879c8fe55537a3217bd0810633863c04f67e169d6e9d4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ed4aadab8c5d7957879c8fe55537a3217bd0810633863c04f67e169d6e9d4e", kill_on_drop: false }` [INFO] [stdout] f5ed4aadab8c5d7957879c8fe55537a3217bd0810633863c04f67e169d6e9d4e