[INFO] cloning repository https://github.com/YankAlex/cui [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YankAlex/cui" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYankAlex%2Fcui", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYankAlex%2Fcui'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f0bc7965a442f45dffd97c8aac1e453503f769fa [INFO] checking YankAlex/cui/f0bc7965a442f45dffd97c8aac1e453503f769fa against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYankAlex%2Fcui" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YankAlex/cui on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YankAlex/cui [INFO] finished tweaking git repo https://github.com/YankAlex/cui [INFO] tweaked toml for git repo https://github.com/YankAlex/cui written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YankAlex/cui already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec387171ea0255a822c46ec79df08397ec76621ed9f4df13af50a6a1ad366378 [INFO] running `Command { std: "docker" "start" "-a" "ec387171ea0255a822c46ec79df08397ec76621ed9f4df13af50a6a1ad366378", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec387171ea0255a822c46ec79df08397ec76621ed9f4df13af50a6a1ad366378", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec387171ea0255a822c46ec79df08397ec76621ed9f4df13af50a6a1ad366378", kill_on_drop: false }` [INFO] [stdout] ec387171ea0255a822c46ec79df08397ec76621ed9f4df13af50a6a1ad366378 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aec1c4d73a5fd6e66c4fcb07ff471e3383f1e2424f46e5611d64b19bb82f602b [INFO] running `Command { std: "docker" "start" "-a" "aec1c4d73a5fd6e66c4fcb07ff471e3383f1e2424f46e5611d64b19bb82f602b", kill_on_drop: false }` [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking cui v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/app/elements.rs:221:19 [INFO] [stdout] | [INFO] [stdout] 221 | elements: Vec<(Box)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 221 - elements: Vec<(Box)>, [INFO] [stdout] 221 + elements: Vec>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/app/elements.rs:221:19 [INFO] [stdout] | [INFO] [stdout] 221 | elements: Vec<(Box)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 221 - elements: Vec<(Box)>, [INFO] [stdout] 221 + elements: Vec>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/app/elements.rs:12:41 [INFO] [stdout] | [INFO] [stdout] 12 | fn command_controller(self: & Self, text: &String, app: AppRef) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_text` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/app/elements.rs:12:56 [INFO] [stdout] | [INFO] [stdout] 12 | fn command_controller(self: & Self, text: &String, app: AppRef) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `text` [INFO] [stdout] --> src/app/elements.rs:12:41 [INFO] [stdout] | [INFO] [stdout] 12 | fn command_controller(self: & Self, text: &String, app: AppRef) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_text` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `app` [INFO] [stdout] --> src/app/elements.rs:12:56 [INFO] [stdout] | [INFO] [stdout] 12 | fn command_controller(self: & Self, text: &String, app: AppRef) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_app` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut app = [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | let mut app = [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `modifiers` [INFO] [stdout] --> src/clickable_text.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | modifiers, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `modifiers: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/clickable_text.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | if let Event::Key(KeyEvent { code, modifiers, kind, state}) = event { [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/clickable_text.rs:42:61 [INFO] [stdout] | [INFO] [stdout] 42 | if let Event::Key(KeyEvent { code, modifiers, kind, state}) = event { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `state: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/mod.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn ininityloop(app: Arc>) -> JoinHandle<()>{ [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | thread::spawn(move || while app.lock().unwrap().state == 1 { [INFO] [stdout] | _______________________^ [INFO] [stdout] 122 | | [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/elements.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn inbox(command: String, on_click: Arc, text: &str, border: Border, padding: usize, id: ... [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Box::new(Self::new(command, on_click, text, border, padding, id, r, c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `modifiers` [INFO] [stdout] --> src/clickable_text.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | modifiers, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `modifiers: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/clickable_text.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | if let Event::Key(KeyEvent { code, modifiers, kind, state}) = event { [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/clickable_text.rs:42:61 [INFO] [stdout] | [INFO] [stdout] 42 | if let Event::Key(KeyEvent { code, modifiers, kind, state}) = event { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `state: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/mod.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn ininityloop(app: Arc>) -> JoinHandle<()>{ [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | thread::spawn(move || while app.lock().unwrap().state == 1 { [INFO] [stdout] | _______________________^ [INFO] [stdout] 122 | | [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/elements.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn inbox(command: String, on_click: Arc, text: &str, border: Border, padding: usize, id: ... [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Box::new(Self::new(command, on_click, text, border, padding, id, r, c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/clickable_text.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | stdout().execute(EnableMouseCapture); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = stdout().execute(EnableMouseCapture); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/clickable_text.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | stdout().execute(DisableMouseCapture); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = stdout().execute(DisableMouseCapture); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/clickable_text.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | stdout().execute(EnableMouseCapture); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 16 | let _ = stdout().execute(EnableMouseCapture); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/clickable_text.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | stdout().execute(DisableMouseCapture); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = stdout().execute(DisableMouseCapture); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cui` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cui` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aec1c4d73a5fd6e66c4fcb07ff471e3383f1e2424f46e5611d64b19bb82f602b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aec1c4d73a5fd6e66c4fcb07ff471e3383f1e2424f46e5611d64b19bb82f602b", kill_on_drop: false }` [INFO] [stdout] aec1c4d73a5fd6e66c4fcb07ff471e3383f1e2424f46e5611d64b19bb82f602b