[INFO] cloning repository https://github.com/YanagiEiichi/neck [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YanagiEiichi/neck" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYanagiEiichi%2Fneck", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYanagiEiichi%2Fneck'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5cd7389b71fd1b314d525492f1b6b02f53bdbcf1 [INFO] checking YanagiEiichi/neck/5cd7389b71fd1b314d525492f1b6b02f53bdbcf1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYanagiEiichi%2Fneck" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YanagiEiichi/neck on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YanagiEiichi/neck [INFO] finished tweaking git repo https://github.com/YanagiEiichi/neck [INFO] tweaked toml for git repo https://github.com/YanagiEiichi/neck written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YanagiEiichi/neck already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f49c9e93f88ffb142cb5c43b5b0100a43332c18efe2e1c866106e53884ddf5ff [INFO] running `Command { std: "docker" "start" "-a" "f49c9e93f88ffb142cb5c43b5b0100a43332c18efe2e1c866106e53884ddf5ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f49c9e93f88ffb142cb5c43b5b0100a43332c18efe2e1c866106e53884ddf5ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f49c9e93f88ffb142cb5c43b5b0100a43332c18efe2e1c866106e53884ddf5ff", kill_on_drop: false }` [INFO] [stdout] f49c9e93f88ffb142cb5c43b5b0100a43332c18efe2e1c866106e53884ddf5ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af107b26fcb30d96e8a50f1e9c9cec2b68c7993839ab4aa6d6b1e19405daaa16 [INFO] running `Command { std: "docker" "start" "-a" "af107b26fcb30d96e8a50f1e9c9cec2b68c7993839ab4aa6d6b1e19405daaa16", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling serde v1.0.186 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking clap_builder v4.3.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl-src v111.27.0+1.1.1v [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.186 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking clap v4.3.23 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking neck v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `string_writter::*` [INFO] [stdout] --> src/http/tests/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use string_writter::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `auth_list` is never read [INFO] [stdout] --> src/socks5/greeting.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ClientGreeting { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 5 | pub ver: u8, [INFO] [stdout] 6 | pub auth_list: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClientGreeting` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/connector/connector_tls.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 30 | let tcp_stream = connect(&self.addr).await?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let tls_stream = self.connector.connect(&self.domain, tcp_stream).await?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(tls_stream.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/neck_client.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 45 | let (sender, receiver) = mpsc::channel::(32); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let connector = create_connector(&a, tls_domain); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | receiver: Mutex::new(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/neck_client.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 45 | let (sender, receiver) = mpsc::channel::(32); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let connector = create_connector(&a, tls_domain); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | bucket: TokenBucket::new(connections.unwrap_or(200) as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/headers.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/direct.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 18 | fn join(&self, _stream: NeckStream) -> PBF<()> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Box::pin(async move {}) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/pool.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 126 | fn join(&self, stream: NeckStream) -> PBF<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Box::pin(async { [INFO] [stdout] | __________________^ [INFO] [stdout] 128 | | // The NeckStream will be moved later, so we need to clone necessary properties before moving. [INFO] [stdout] 129 | | let addr = stream.peer_addr; [INFO] [stdout] ... | [INFO] [stdout] 138 | | self.wait_close_or_use(addr).await; [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/pool.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 144 | let ss = Arc::new(session); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 146 | | let stream = match self.take_and_send_connect(&ss.host).await { [INFO] [stdout] 147 | | Some(it) => it, [INFO] [stdout] 148 | | None => return ConnectingResult::BadGateway(), [INFO] [stdout] ... | [INFO] [stdout] 172 | | return ConnectingResult::Ok(stream); [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/neck_server.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 88 | fn start<'a>(self) -> PBF<'a, ()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Box::pin(NeckServer::start(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn wrap(message: impl ToString) -> NeckResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Err(Box::new(NeckError::new(message))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn enable_keepalive(stream: TcpStream) -> TcpStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let socket = Socket::from(stream.into_std().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | TcpStream::from_std(socket.into()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/stream.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut buss = Box::new(stream.into()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (reader, writer) = SupportedStream::split(unsafe { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | writer: Mutex::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/stream.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut buss = Box::new(stream.into()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (reader, writer) = SupportedStream::split(unsafe { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | reader: Mutex::new(BufReader::with_capacity(10240, reader)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `auth_list` is never read [INFO] [stdout] --> src/socks5/greeting.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ClientGreeting { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 5 | pub ver: u8, [INFO] [stdout] 6 | pub auth_list: Vec, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClientGreeting` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/connector/connector_tls.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 30 | let tcp_stream = connect(&self.addr).await?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let tls_stream = self.connector.connect(&self.domain, tcp_stream).await?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(tls_stream.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/neck_client.rs:58:23 [INFO] [stdout] | [INFO] [stdout] 45 | let (sender, receiver) = mpsc::channel::(32); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let connector = create_connector(&a, tls_domain); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | receiver: Mutex::new(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/neck_client.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 45 | let (sender, receiver) = mpsc::channel::(32); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let connector = create_connector(&a, tls_domain); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | bucket: TokenBucket::new(connections.unwrap_or(200) as usize), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/headers.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/direct.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 18 | fn join(&self, _stream: NeckStream) -> PBF<()> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Box::pin(async move {}) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/pool.rs:127:18 [INFO] [stdout] | [INFO] [stdout] 126 | fn join(&self, stream: NeckStream) -> PBF<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Box::pin(async { [INFO] [stdout] | __________________^ [INFO] [stdout] 128 | | // The NeckStream will be moved later, so we need to clone necessary properties before moving. [INFO] [stdout] 129 | | let addr = stream.peer_addr; [INFO] [stdout] ... | [INFO] [stdout] 138 | | self.wait_close_or_use(addr).await; [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/manager/pool.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 144 | let ss = Arc::new(session); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 146 | | let stream = match self.take_and_send_connect(&ss.host).await { [INFO] [stdout] 147 | | Some(it) => it, [INFO] [stdout] 148 | | None => return ConnectingResult::BadGateway(), [INFO] [stdout] ... | [INFO] [stdout] 172 | | return ConnectingResult::Ok(stream); [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/neck_server.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 88 | fn start<'a>(self) -> PBF<'a, ()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Box::pin(NeckServer::start(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn wrap(message: impl ToString) -> NeckResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Err(Box::new(NeckError::new(message))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn enable_keepalive(stream: TcpStream) -> TcpStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let socket = Socket::from(stream.into_std().unwrap()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | TcpStream::from_std(socket.into()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/stream.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut buss = Box::new(stream.into()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (reader, writer) = SupportedStream::split(unsafe { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | writer: Mutex::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/stream.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(stream: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut buss = Box::new(stream.into()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | let (reader, writer) = SupportedStream::split(unsafe { [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | reader: Mutex::new(BufReader::with_capacity(10240, reader)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neck` (bin "neck") due to 13 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neck` (bin "neck" test) due to 13 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "af107b26fcb30d96e8a50f1e9c9cec2b68c7993839ab4aa6d6b1e19405daaa16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af107b26fcb30d96e8a50f1e9c9cec2b68c7993839ab4aa6d6b1e19405daaa16", kill_on_drop: false }` [INFO] [stdout] af107b26fcb30d96e8a50f1e9c9cec2b68c7993839ab4aa6d6b1e19405daaa16