[INFO] cloning repository https://github.com/YagerICS/remote-drop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YagerICS/remote-drop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYagerICS%2Fremote-drop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYagerICS%2Fremote-drop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d195409baa5749cce3543e46470824bf258bb9c9 [INFO] checking YagerICS/remote-drop/d195409baa5749cce3543e46470824bf258bb9c9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYagerICS%2Fremote-drop" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YagerICS/remote-drop on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YagerICS/remote-drop [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/YagerICS/remote-drop [INFO] tweaked toml for git repo https://github.com/YagerICS/remote-drop written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YagerICS/remote-drop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: example.0.default-features [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13a76fc3d31bc5f89cae2e1c99595b4dd61b74562199b560ce2b3f89a2acc3cb [INFO] running `Command { std: "docker" "start" "-a" "13a76fc3d31bc5f89cae2e1c99595b4dd61b74562199b560ce2b3f89a2acc3cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13a76fc3d31bc5f89cae2e1c99595b4dd61b74562199b560ce2b3f89a2acc3cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13a76fc3d31bc5f89cae2e1c99595b4dd61b74562199b560ce2b3f89a2acc3cb", kill_on_drop: false }` [INFO] [stdout] 13a76fc3d31bc5f89cae2e1c99595b4dd61b74562199b560ce2b3f89a2acc3cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e039296db8dab196cf25f8972b42d9cfa0f09d1a22b73af487769e857b449cc [INFO] running `Command { std: "docker" "start" "-a" "0e039296db8dab196cf25f8972b42d9cfa0f09d1a22b73af487769e857b449cc", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: example.0.default-features [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling defmt v0.3.8 [INFO] [stderr] Compiling defmt-macros v0.3.9 [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Compiling embassy-sync v0.6.0 (https://github.com/embassy-rs/embassy#e61136fa) [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking critical-section v1.1.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking talc v4.4.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling defmt-parser v0.3.4 [INFO] [stderr] Checking remote-drop v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/remote_drop.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 205 | use std::{alloc::Global, collections::HashMap, sync::Mutex}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::BorrowMut` [INFO] [stdout] --> src/remote_drop.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use core::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DerefNode` is more private than the item `ToDeallocate::::extract_one` [INFO] [stdout] --> src/remote_drop.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn extract_one(&mut self) -> Option, A>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ToDeallocate::::extract_one` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `DerefNode` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/remote_drop.rs:136:1 [INFO] [stdout] | [INFO] [stdout] 136 | trait DerefNode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::BorrowMut` [INFO] [stdout] --> src/remote_drop.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use core::borrow::BorrowMut; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DerefNode` is more private than the item `ToDeallocate::::extract_several` [INFO] [stdout] --> src/remote_drop.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | / pub fn extract_several( [INFO] [stdout] 189 | | &mut self, [INFO] [stdout] 190 | | ) -> heapless::Vec, A>, N> { [INFO] [stdout] | |___________________________________________________^ method `ToDeallocate::::extract_several` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `DerefNode` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/remote_drop.rs:136:1 [INFO] [stdout] | [INFO] [stdout] 136 | trait DerefNode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | self.head.lock(|q| q.borrow_mut().extract_one()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:41:63 [INFO] [stdout] | [INFO] [stdout] 41 | let garbage: heapless::Vec<_, N> = self.head.lock(|q| q.borrow_mut().extract_several()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 89 | let item = unsafe { ManuallyDrop::take(&mut self.item) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | // We'll put it back in a `ManuallyDrop` in here [INFO] [stdout] 91 | self.queue.head.lock(|q| q.borrow_mut().add_item(item)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn try_new(item: T, alloc: A, queue: &'static Queue) -> Result { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Ok(RBox { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | item: ManuallyDrop::new(Box::try_new_in( [INFO] [stdout] 99 | | DN { [INFO] [stdout] 100 | | t: item, [INFO] [stdout] ... | [INFO] [stdout] 105 | | queue, [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `remote-drop` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `DerefNode` is more private than the item `ToDeallocate::::extract_one` [INFO] [stdout] --> src/remote_drop.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | pub fn extract_one(&mut self) -> Option, A>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `ToDeallocate::::extract_one` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `DerefNode` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/remote_drop.rs:136:1 [INFO] [stdout] | [INFO] [stdout] 136 | trait DerefNode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DerefNode` is more private than the item `ToDeallocate::::extract_several` [INFO] [stdout] --> src/remote_drop.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 188 | / pub fn extract_several( [INFO] [stdout] 189 | | &mut self, [INFO] [stdout] 190 | | ) -> heapless::Vec, A>, N> { [INFO] [stdout] | |___________________________________________________^ method `ToDeallocate::::extract_several` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `DerefNode` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/remote_drop.rs:136:1 [INFO] [stdout] | [INFO] [stdout] 136 | trait DerefNode { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:36:32 [INFO] [stdout] | [INFO] [stdout] 36 | self.head.lock(|q| q.borrow_mut().extract_one()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:41:63 [INFO] [stdout] | [INFO] [stdout] 41 | let garbage: heapless::Vec<_, N> = self.head.lock(|q| q.borrow_mut().extract_several()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:91:34 [INFO] [stdout] | [INFO] [stdout] 89 | let item = unsafe { ManuallyDrop::take(&mut self.item) }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | // We'll put it back in a `ManuallyDrop` in here [INFO] [stdout] 91 | self.queue.head.lock(|q| q.borrow_mut().add_item(item)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remote_drop.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn try_new(item: T, alloc: A, queue: &'static Queue) -> Result { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Ok(RBox { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | item: ManuallyDrop::new(Box::try_new_in( [INFO] [stdout] 99 | | DN { [INFO] [stdout] 100 | | t: item, [INFO] [stdout] ... | [INFO] [stdout] 105 | | queue, [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `remote-drop` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0e039296db8dab196cf25f8972b42d9cfa0f09d1a22b73af487769e857b449cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e039296db8dab196cf25f8972b42d9cfa0f09d1a22b73af487769e857b449cc", kill_on_drop: false }` [INFO] [stdout] 0e039296db8dab196cf25f8972b42d9cfa0f09d1a22b73af487769e857b449cc