[INFO] cloning repository https://github.com/YKiselev/rustground [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YKiselev/rustground" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYKiselev%2Frustground", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYKiselev%2Frustground'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dfb8871a9956a26955d1b10242a082ac8c25eb33 [INFO] checking YKiselev/rustground/dfb8871a9956a26955d1b10242a082ac8c25eb33 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYKiselev%2Frustground" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YKiselev/rustground on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/YKiselev/rustground [INFO] finished tweaking git repo https://github.com/YKiselev/rustground [INFO] tweaked toml for git repo https://github.com/YKiselev/rustground written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YKiselev/rustground already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7f1179241e836a00e68e200cdde511a85f7de8d07764f76b65ddf9ec38dc43f [INFO] running `Command { std: "docker" "start" "-a" "e7f1179241e836a00e68e200cdde511a85f7de8d07764f76b65ddf9ec38dc43f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7f1179241e836a00e68e200cdde511a85f7de8d07764f76b65ddf9ec38dc43f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7f1179241e836a00e68e200cdde511a85f7de8d07764f76b65ddf9ec38dc43f", kill_on_drop: false }` [INFO] [stdout] e7f1179241e836a00e68e200cdde511a85f7de8d07764f76b65ddf9ec38dc43f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f44f25a6bd232e554d8ad2ed2e4dd16f1cbe222ab877d03973072bc8dae19b0 [INFO] running `Command { std: "docker" "start" "-a" "6f44f25a6bd232e554d8ad2ed2e4dd16f1cbe222ab877d03973072bc8dae19b0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking rg_ecs v0.1.0 (/opt/rustwide/workdir/rg_ecs) [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> rg_ecs/src/entity.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct EntityId(usize); [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `archetypes` is never read [INFO] [stdout] --> rg_ecs/src/entity.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Entities { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 9 | archetypes: HashMap> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ComponentStorageFactory` is never constructed [INFO] [stdout] --> rg_ecs/src/component.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) struct ComponentStorageFactory { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `create` are never used [INFO] [stdout] --> rg_ecs/src/component.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl ComponentStorageFactory { [INFO] [stdout] | ---------------------------- associated items in this implementation [INFO] [stdout] 24 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn create(&self) -> Box { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypedComponentStorage` is never constructed [INFO] [stdout] --> rg_ecs/src/component.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) struct TypedComponentStorage { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypedComponentStorage` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `push`, `get`, and `get_mut` are never used [INFO] [stdout] --> rg_ecs/src/component.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl TypedComponentStorage { [INFO] [stdout] | ----------------------------------------- methods in this implementation [INFO] [stdout] 48 | fn push(&mut self, value: T) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | fn get(&self, index: usize) -> Option<&T> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | fn get_mut(&mut self, index: usize) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ArchetypeBuilder` is never constructed [INFO] [stdout] --> rg_ecs/src/archetype.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct ArchetypeBuilder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ArchetypeBuilder` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add` and `build` are never used [INFO] [stdout] --> rg_ecs/src/archetype.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | impl ArchetypeBuilder { [INFO] [stdout] | --------------------- methods in this implementation [INFO] [stdout] 13 | fn add(mut self) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 18 | fn build(self) -> Archetype { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Archetype` is never constructed [INFO] [stdout] --> rg_ecs/src/archetype.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub(crate) struct Archetype { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `create_storage` is never used [INFO] [stdout] --> rg_ecs/src/archetype.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | impl Archetype { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 36 | fn create_storage(&self) -> ArchetypeStorage { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `data` are never read [INFO] [stdout] --> rg_ecs/src/archetype.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) struct ArchetypeStorage { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | pub id: ArchetypeId, [INFO] [stdout] | ^^ [INFO] [stdout] 49 | data: Vec<(ComponentId, Box)>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rg_ecs/src/component.rs:27:42 [INFO] [stdout] | [INFO] [stdout] 27 | create: Box::new(|| Box::new(TypedComponentStorage::::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rg_ecs/src/archetype.rs:39:56 [INFO] [stdout] | [INFO] [stdout] 39 | data: self.factories.iter().map(|f| (f.id, f.create())).collect(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rg_ecs` (lib) due to 3 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `storage` [INFO] [stdout] --> rg_ecs/src/archetype.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | let storage = archetype.create_storage(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_storage` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> rg_ecs/src/entity.rs:6:21 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct EntityId(usize); [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `archetypes` is never read [INFO] [stdout] --> rg_ecs/src/entity.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Entities { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 9 | archetypes: HashMap> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_mut` is never used [INFO] [stdout] --> rg_ecs/src/component.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 47 | impl TypedComponentStorage { [INFO] [stdout] | ----------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 56 | fn get_mut(&mut self, index: usize) -> Option<&mut T> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `data` are never read [INFO] [stdout] --> rg_ecs/src/archetype.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) struct ArchetypeStorage { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 48 | pub id: ArchetypeId, [INFO] [stdout] | ^^ [INFO] [stdout] 49 | data: Vec<(ComponentId, Box)>, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rg_ecs/src/component.rs:27:42 [INFO] [stdout] | [INFO] [stdout] 27 | create: Box::new(|| Box::new(TypedComponentStorage::::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rg_ecs/src/component.rs:88:47 [INFO] [stdout] | [INFO] [stdout] 88 | factory: Box::new(|| Box::new(TypedComponentStorage::::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rg_ecs/src/archetype.rs:39:56 [INFO] [stdout] | [INFO] [stdout] 39 | data: self.factories.iter().map(|f| (f.id, f.create())).collect(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rg_ecs` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6f44f25a6bd232e554d8ad2ed2e4dd16f1cbe222ab877d03973072bc8dae19b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f44f25a6bd232e554d8ad2ed2e4dd16f1cbe222ab877d03973072bc8dae19b0", kill_on_drop: false }` [INFO] [stdout] 6f44f25a6bd232e554d8ad2ed2e4dd16f1cbe222ab877d03973072bc8dae19b0