[INFO] cloning repository https://github.com/YAtOff/simple-rsync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/YAtOff/simple-rsync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYAtOff%2Fsimple-rsync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYAtOff%2Fsimple-rsync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f072b27d77ffbe95b53e7c2f3dc426a780a058b4 [INFO] checking YAtOff/simple-rsync/f072b27d77ffbe95b53e7c2f3dc426a780a058b4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FYAtOff%2Fsimple-rsync" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/YAtOff/simple-rsync on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config [INFO] started tweaking git repo https://github.com/YAtOff/simple-rsync [INFO] finished tweaking git repo https://github.com/YAtOff/simple-rsync [INFO] tweaked toml for git repo https://github.com/YAtOff/simple-rsync written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/YAtOff/simple-rsync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding librsync v0.2.3 [INFO] [stderr] Adding librsync-sys v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 02e543bab490afb2f559a46d78f2a5ad779e8d741311572ee98757ded603e7ed [INFO] running `Command { std: "docker" "start" "-a" "02e543bab490afb2f559a46d78f2a5ad779e8d741311572ee98757ded603e7ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "02e543bab490afb2f559a46d78f2a5ad779e8d741311572ee98757ded603e7ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02e543bab490afb2f559a46d78f2a5ad779e8d741311572ee98757ded603e7ed", kill_on_drop: false }` [INFO] [stdout] 02e543bab490afb2f559a46d78f2a5ad779e8d741311572ee98757ded603e7ed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96f5f5d9acea52c0e3b2979d8d30a89d88f8b46a54f9233bdd496597087e42d1 [INFO] running `Command { std: "docker" "start" "-a" "96f5f5d9acea52c0e3b2979d8d30a89d88f8b46a54f9233bdd496597087e42d1", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.6 [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling once_cell v1.17.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking smallvec v1.5.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking unindent v0.1.7 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling pyo3-build-config v0.18.1 [INFO] [stderr] Checking parking_lot_core v0.8.1 [INFO] [stderr] Compiling librsync-sys v0.1.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling pyo3-ffi v0.18.1 [INFO] [stderr] Compiling pyo3 v0.18.1 [INFO] [stderr] Checking librsync v0.2.3 [INFO] [stderr] Compiling pyo3-macros-backend v0.18.1 [INFO] [stderr] Compiling pyo3-macros v0.18.1 [INFO] [stderr] Checking simple-rsync v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `py` [INFO] [stdout] --> src/lib.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | fn simple_rsync(py: Python, m: &PyModule) -> PyResult<()> { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_py` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `py` [INFO] [stdout] --> src/lib.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | fn simple_rsync(py: Python, m: &PyModule) -> PyResult<()> { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_py` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 22 | let data_file = File::open(data_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut data_file = BufReader::new(data_file); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut signature_file = File::create(signature_file_path)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / librsync_signature( [INFO] [stdout] 26 | | &mut data_file, [INFO] [stdout] 27 | | &mut signature_file, [INFO] [stdout] 28 | | block_len, [INFO] [stdout] 29 | | strong_len, [INFO] [stdout] 30 | | SignatureType::MD4 [INFO] [stdout] 31 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut data_file = File::open(data_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut signature_file = File::open(signature_file_path)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut delta_file = File::create(delta_file_path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / librsync_delta( [INFO] [stdout] 40 | | &mut data_file, [INFO] [stdout] 41 | | &mut signature_file, [INFO] [stdout] 42 | | &mut delta_file [INFO] [stdout] 43 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | let mut base_file = File::open(base_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut delta_file = File::open(delta_file_path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut result_file = File::create(result_file_path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | / librsync_patch( [INFO] [stdout] 53 | | &mut base_file, [INFO] [stdout] 54 | | &mut delta_file, [INFO] [stdout] 55 | | &mut result_file [INFO] [stdout] 56 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 22 | let data_file = File::open(data_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut data_file = BufReader::new(data_file); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let mut signature_file = File::create(signature_file_path)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | / librsync_signature( [INFO] [stdout] 26 | | &mut data_file, [INFO] [stdout] 27 | | &mut signature_file, [INFO] [stdout] 28 | | block_len, [INFO] [stdout] 29 | | strong_len, [INFO] [stdout] 30 | | SignatureType::MD4 [INFO] [stdout] 31 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut data_file = File::open(data_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let mut signature_file = File::open(signature_file_path)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let mut delta_file = File::create(delta_file_path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | / librsync_delta( [INFO] [stdout] 40 | | &mut data_file, [INFO] [stdout] 41 | | &mut signature_file, [INFO] [stdout] 42 | | &mut delta_file [INFO] [stdout] 43 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | let mut base_file = File::open(base_file_path)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut delta_file = File::open(delta_file_path)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let mut result_file = File::create(result_file_path)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | / librsync_patch( [INFO] [stdout] 53 | | &mut base_file, [INFO] [stdout] 54 | | &mut delta_file, [INFO] [stdout] 55 | | &mut result_file [INFO] [stdout] 56 | | ).map_err(librsync_to_py_error) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-rsync` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple-rsync` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "96f5f5d9acea52c0e3b2979d8d30a89d88f8b46a54f9233bdd496597087e42d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96f5f5d9acea52c0e3b2979d8d30a89d88f8b46a54f9233bdd496597087e42d1", kill_on_drop: false }` [INFO] [stdout] 96f5f5d9acea52c0e3b2979d8d30a89d88f8b46a54f9233bdd496597087e42d1