[INFO] cloning repository https://github.com/Xiphoseer/sysdiagram [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Xiphoseer/sysdiagram" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXiphoseer%2Fsysdiagram", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXiphoseer%2Fsysdiagram'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8326a74a7c1f59d5ff8612a20e6e2ece561ebf7c [INFO] checking Xiphoseer/sysdiagram/8326a74a7c1f59d5ff8612a20e6e2ece561ebf7c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXiphoseer%2Fsysdiagram" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Xiphoseer/sysdiagram on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Xiphoseer/sysdiagram [INFO] finished tweaking git repo https://github.com/Xiphoseer/sysdiagram [INFO] tweaked toml for git repo https://github.com/Xiphoseer/sysdiagram written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Xiphoseer/sysdiagram already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f7fea58d149559a2e237a18304ab4b79f19c14a788a6f8a892ff1981fc6bf6e [INFO] running `Command { std: "docker" "start" "-a" "7f7fea58d149559a2e237a18304ab4b79f19c14a788a6f8a892ff1981fc6bf6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f7fea58d149559a2e237a18304ab4b79f19c14a788a6f8a892ff1981fc6bf6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f7fea58d149559a2e237a18304ab4b79f19c14a788a6f8a892ff1981fc6bf6e", kill_on_drop: false }` [INFO] [stdout] 7f7fea58d149559a2e237a18304ab4b79f19c14a788a6f8a892ff1981fc6bf6e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06dff1230fd87356bed38a7ca2e3174a76baa75d79dbb1f8c9aa1f627fcafae3 [INFO] running `Command { std: "docker" "start" "-a" "06dff1230fd87356bed38a7ca2e3174a76baa75d79dbb1f8c9aa1f627fcafae3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking uuid v1.5.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking cfb v0.9.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking bstr v1.7.0 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling num-derive v0.4.1 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling displaydoc v0.1.7 [INFO] [stderr] Checking ms-oforms v0.3.0-alpha2 (https://github.com/Xiphoseer/rust-ms-oforms.git?rev=21cda4c#21cda4ca) [INFO] [stderr] Checking sysdiagram v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn open(inner: T) -> std::io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let inner = OFormsFile::open(inner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut form = self.root_form().map_err(Error::Cfb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut controls = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let mut dds_stream = self.open_stream("\x03DdsStream")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok((form_control, controls, diagram)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 67 | fn from(value: VerboseError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Error::ParseFailureVerbose( [INFO] [stdout] 69 | / value [INFO] [stdout] 70 | | .errors [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] 72 | | .map(|e| (e.1, e.0.input_len())) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mdtdb.rs:246:8 [INFO] [stdout] | [INFO] [stdout] 243 | let (input, frame) = parse_grid_frame_wnd(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 247 | | input, [INFO] [stdout] 248 | | SchGrid { [INFO] [stdout] 249 | | extent, [INFO] [stdout] ... | [INFO] [stdout] 252 | | }, [INFO] [stdout] 253 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | map_opt(take((len as usize) << 1), decode_utf16)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sysdiagram` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn open(inner: T) -> std::io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let inner = OFormsFile::open(inner)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 156 | let mut form = self.root_form().map_err(Error::Cfb)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut controls = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let mut dds_stream = self.open_stream("\x03DdsStream")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | Ok((form_control, controls, diagram)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 67 | fn from(value: VerboseError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Error::ParseFailureVerbose( [INFO] [stdout] 69 | / value [INFO] [stdout] 70 | | .errors [INFO] [stdout] 71 | | .into_iter() [INFO] [stdout] 72 | | .map(|e| (e.1, e.0.input_len())) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mdtdb.rs:246:8 [INFO] [stdout] | [INFO] [stdout] 243 | let (input, frame) = parse_grid_frame_wnd(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 247 | | input, [INFO] [stdout] 248 | | SchGrid { [INFO] [stdout] 249 | | extent, [INFO] [stdout] ... | [INFO] [stdout] 252 | | }, [INFO] [stdout] 253 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | map_opt(take((len as usize) << 1), decode_utf16)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sysdiagram` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "06dff1230fd87356bed38a7ca2e3174a76baa75d79dbb1f8c9aa1f627fcafae3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06dff1230fd87356bed38a7ca2e3174a76baa75d79dbb1f8c9aa1f627fcafae3", kill_on_drop: false }` [INFO] [stdout] 06dff1230fd87356bed38a7ca2e3174a76baa75d79dbb1f8c9aa1f627fcafae3