[INFO] cloning repository https://github.com/XavierT/errand [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/XavierT/errand" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXavierT%2Ferrand", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXavierT%2Ferrand'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0cdabe1a173121bad2dd93ff8cbf81fd139641db [INFO] checking XavierT/errand/0cdabe1a173121bad2dd93ff8cbf81fd139641db against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXavierT%2Ferrand" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/XavierT/errand on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/XavierT/errand [INFO] finished tweaking git repo https://github.com/XavierT/errand [INFO] tweaked toml for git repo https://github.com/XavierT/errand written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/XavierT/errand already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1dd2cd1ad66b13573acf3d9abf6515ed965b7677fb1eb75421593f84188dea26 [INFO] running `Command { std: "docker" "start" "-a" "1dd2cd1ad66b13573acf3d9abf6515ed965b7677fb1eb75421593f84188dea26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1dd2cd1ad66b13573acf3d9abf6515ed965b7677fb1eb75421593f84188dea26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dd2cd1ad66b13573acf3d9abf6515ed965b7677fb1eb75421593f84188dea26", kill_on_drop: false }` [INFO] [stdout] 1dd2cd1ad66b13573acf3d9abf6515ed965b7677fb1eb75421593f84188dea26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54ec657bbe03ecd3d21bc42695c33acf7962be8f67aab0179d2fa6eff219ffc8 [INFO] running `Command { std: "docker" "start" "-a" "54ec657bbe03ecd3d21bc42695c33acf7962be8f67aab0179d2fa6eff219ffc8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking libc v0.2.6 [INFO] [stderr] Checking winapi v0.2.6 [INFO] [stderr] Compiling kernel32-sys v0.2.1 [INFO] [stderr] Checking log v0.3.5 [INFO] [stderr] Checking ncurses v5.80.0 [INFO] [stderr] Checking time v0.1.34 [INFO] [stderr] Checking errand v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/util/file_logger.rs:51:73 [INFO] [stdout] | [INFO] [stdout] 51 | Err(why) => panic!("couldn't write: {}", Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/util/file_logger.rs:69:74 [INFO] [stdout] | [INFO] [stdout] 69 | Err(why) => panic!("couldn't create {}: {}", display, Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/util/file_logger.rs:51:73 [INFO] [stdout] | [INFO] [stdout] 51 | Err(why) => panic!("couldn't write: {}", Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/util/file_logger.rs:69:74 [INFO] [stdout] | [INFO] [stdout] 69 | Err(why) => panic!("couldn't create {}: {}", display, Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / &self.book.history.push(Log { [INFO] [stdout] 42 | | level: Level::Normal, [INFO] [stdout] 43 | | msg: msg, [INFO] [stdout] 44 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / &self.book.history.push(Log { [INFO] [stdout] 49 | | level: Level::Warning, [INFO] [stdout] 50 | | msg: msg, [INFO] [stdout] 51 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / &self.book.history.push(Log { [INFO] [stdout] 56 | | level: Level::Danger, [INFO] [stdout] 57 | | msg: msg, [INFO] [stdout] 58 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file_logger.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 68 | let file = match File::create(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Err(why) => panic!("couldn't create {}: {}", display, Error::description(&why)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | log::set_logger(|max_log_level| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 75 | | max_log_level.set(LogLevelFilter::Info); [INFO] [stdout] 76 | | Box::new(SimpleFileLogger { logfile: Mutex::new(Some(file)) }) [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file_logger.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 68 | let file = match File::create(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Box::new(SimpleFileLogger { logfile: Mutex::new(Some(file)) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `errand` (bin "errand" test) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / &self.book.history.push(Log { [INFO] [stdout] 42 | | level: Level::Normal, [INFO] [stdout] 43 | | msg: msg, [INFO] [stdout] 44 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / &self.book.history.push(Log { [INFO] [stdout] 49 | | level: Level::Warning, [INFO] [stdout] 50 | | msg: msg, [INFO] [stdout] 51 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/ui/player_log.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / &self.book.history.push(Log { [INFO] [stdout] 56 | | level: Level::Danger, [INFO] [stdout] 57 | | msg: msg, [INFO] [stdout] 58 | | }); [INFO] [stdout] | |__________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = &self.book.history.push(Log { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file_logger.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 68 | let file = match File::create(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Err(why) => panic!("couldn't create {}: {}", display, Error::description(&why)), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | log::set_logger(|max_log_level| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 75 | | max_log_level.set(LogLevelFilter::Info); [INFO] [stdout] 76 | | Box::new(SimpleFileLogger { logfile: Mutex::new(Some(file)) }) [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file_logger.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 68 | let file = match File::create(&path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Box::new(SimpleFileLogger { logfile: Mutex::new(Some(file)) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `errand` (bin "errand") due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "54ec657bbe03ecd3d21bc42695c33acf7962be8f67aab0179d2fa6eff219ffc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54ec657bbe03ecd3d21bc42695c33acf7962be8f67aab0179d2fa6eff219ffc8", kill_on_drop: false }` [INFO] [stdout] 54ec657bbe03ecd3d21bc42695c33acf7962be8f67aab0179d2fa6eff219ffc8