[INFO] cloning repository https://github.com/XBagon/hsbgsim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/XBagon/hsbgsim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXBagon%2Fhsbgsim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXBagon%2Fhsbgsim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ceb078d6309d3b130b4578c65fb56720764a15a7 [INFO] checking XBagon/hsbgsim/ceb078d6309d3b130b4578c65fb56720764a15a7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FXBagon%2Fhsbgsim" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/XBagon/hsbgsim on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/XBagon/hsbgsim [INFO] finished tweaking git repo https://github.com/XBagon/hsbgsim [INFO] tweaked toml for git repo https://github.com/XBagon/hsbgsim written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/XBagon/hsbgsim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6813586ef5c20040a12c3fa289cc041e9932901398243137ad734bf78db61bac [INFO] running `Command { std: "docker" "start" "-a" "6813586ef5c20040a12c3fa289cc041e9932901398243137ad734bf78db61bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6813586ef5c20040a12c3fa289cc041e9932901398243137ad734bf78db61bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6813586ef5c20040a12c3fa289cc041e9932901398243137ad734bf78db61bac", kill_on_drop: false }` [INFO] [stdout] 6813586ef5c20040a12c3fa289cc041e9932901398243137ad734bf78db61bac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] caf16452fb64456b220e427a3922312b541b43100e8ddca3287bd416369c2b33 [INFO] running `Command { std: "docker" "start" "-a" "caf16452fb64456b220e427a3922312b541b43100e8ddca3287bd416369c2b33", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking bitmaps v3.2.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking pre_commit_checks v0.1.0 (/opt/rustwide/workdir/pre_commit_checks) [INFO] [stderr] Checking quote v1.0.33 [INFO] [stderr] Checking syn v2.0.37 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling test-case-core v3.2.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Compiling strum_macros v0.25.2 [INFO] [stderr] Compiling automod v1.0.12 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling test-case-macros v3.2.1 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking test-case v3.2.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking insta v1.31.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hsbgsim v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking reqwest v0.11.20 [INFO] [stderr] Checking hsbgsim_codegen v0.1.0 (/opt/rustwide/workdir/hsbgsim_codegen) [INFO] [stdout] warning: struct `GameBuilder` is never constructed [INFO] [stdout] --> src/game.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | struct GameBuilder {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/game.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl GameBuilder { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 51 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minions` is never read [INFO] [stdout] --> src/hand.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Hand { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 7 | minions: ArrayVec<[MinionInstance; 10]>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hand` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `health` and `armor` are never read [INFO] [stdout] --> src/hero.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Hero { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 3 | health: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 4 | armor: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hero` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hero` and `hand` are never read [INFO] [stdout] --> src/player.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | hero: Hero, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | hand: Hand, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Player` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/mod.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(minion: MinionInstanceId, handler: Ev::Handler) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | handler: Some(handler), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/activate_effect.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 20 | event: Ev, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | ass_handler: AssociatedEventHandler, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Self::new(EventHandling::new(event, ass_handler).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/activate_effect.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 31 | fn from(value: ActivateEffect) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Event::ActivateEffect(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn from_replay(mut replay: Replay) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | replay.events.reverse(); [INFO] [stdout] 74 | let queue = replay.events; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | events: Events { [INFO] [stdout] | _____________________^ [INFO] [stdout] 83 | | queue, [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GameBuilder` is never constructed [INFO] [stdout] --> src/game.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | struct GameBuilder {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/game.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 50 | impl GameBuilder { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 51 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minions` is never read [INFO] [stdout] --> src/hand.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Hand { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 7 | minions: ArrayVec<[MinionInstance; 10]>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hand` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `health` and `armor` are never read [INFO] [stdout] --> src/hero.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Hero { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 3 | health: u16, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 4 | armor: u16, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hero` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `hero` and `hand` are never read [INFO] [stdout] --> src/player.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 6 | hero: Hero, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | hand: Hand, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Player` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/mod.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn new(minion: MinionInstanceId, handler: Ev::Handler) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | handler: Some(handler), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/activate_effect.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 20 | event: Ev, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | ass_handler: AssociatedEventHandler, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Self::new(EventHandling::new(event, ass_handler).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events/activate_effect.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 31 | fn from(value: ActivateEffect) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Event::ActivateEffect(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn from_replay(mut replay: Replay) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | replay.events.reverse(); [INFO] [stdout] 74 | let queue = replay.events; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | events: Events { [INFO] [stdout] | _____________________^ [INFO] [stdout] 83 | | queue, [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hsbgsim` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hsbgsim` (lib test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "caf16452fb64456b220e427a3922312b541b43100e8ddca3287bd416369c2b33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "caf16452fb64456b220e427a3922312b541b43100e8ddca3287bd416369c2b33", kill_on_drop: false }` [INFO] [stdout] caf16452fb64456b220e427a3922312b541b43100e8ddca3287bd416369c2b33