[INFO] cloning repository https://github.com/WonkySpecs/vocabulearn [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WonkySpecs/vocabulearn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWonkySpecs%2Fvocabulearn", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWonkySpecs%2Fvocabulearn'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 435e355071c8d736b8b5f57716cc890d01e3aea2 [INFO] checking WonkySpecs/vocabulearn/435e355071c8d736b8b5f57716cc890d01e3aea2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWonkySpecs%2Fvocabulearn" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/WonkySpecs/vocabulearn on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/WonkySpecs/vocabulearn [INFO] finished tweaking git repo https://github.com/WonkySpecs/vocabulearn [INFO] tweaked toml for git repo https://github.com/WonkySpecs/vocabulearn written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/WonkySpecs/vocabulearn already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8735ebbc9e58eae26f26d127fe37fe78956cbe5bc7abf4e960918d494df2b88e [INFO] running `Command { std: "docker" "start" "-a" "8735ebbc9e58eae26f26d127fe37fe78956cbe5bc7abf4e960918d494df2b88e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8735ebbc9e58eae26f26d127fe37fe78956cbe5bc7abf4e960918d494df2b88e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8735ebbc9e58eae26f26d127fe37fe78956cbe5bc7abf4e960918d494df2b88e", kill_on_drop: false }` [INFO] [stdout] 8735ebbc9e58eae26f26d127fe37fe78956cbe5bc7abf4e960918d494df2b88e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5fe02f4f7a0fc469d5a785abe7ad7a8fe0ca4ad2c121c13aadafabf57f26a3d [INFO] running `Command { std: "docker" "start" "-a" "e5fe02f4f7a0fc469d5a785abe7ad7a8fe0ca4ad2c121c13aadafabf57f26a3d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling serde v1.0.101 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Compiling serde_derive v1.0.101 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking vocabulearn v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/data.rs:109:57 [INFO] [stdout] | [INFO] [stdout] 109 | fn save_vocab(&self) -> std::result::Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 109 | fn save_vocab(&self) -> std::result::Result<(), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/data.rs:109:57 [INFO] [stdout] | [INFO] [stdout] 109 | fn save_vocab(&self) -> std::result::Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 109 | fn save_vocab(&self) -> std::result::Result<(), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `labels`, `label_mapping`, `labels_file`, and `map_file` are never read [INFO] [stdout] --> src/data.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Vocab { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 45 | vocab: HashMap, [INFO] [stdout] 46 | labels: HashMap, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 47 | label_mapping: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 48 | vocab_file: String, [INFO] [stdout] 49 | labels_file: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 50 | map_file: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `correct` and `wrong` are never read [INFO] [stdout] --> src/data.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct QuizResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 126 | pub correct: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 127 | pub wrong: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuizResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:24:10 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Deserialize, Serialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | self.save_vocab(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = self.save_vocab(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | fs::rename(&self.vocab_file, archive_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 118 | let _ = fs::rename(&self.vocab_file, archive_file); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | fs::rename(new_file, &self.vocab_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::rename(new_file, &self.vocab_file); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 160 | let mut rdr = csv::Reader::from_path(filename)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(rdr.deserialize() [INFO] [stdout] | ________^ [INFO] [stdout] 162 | | .map(|r| r.unwrap()) [INFO] [stdout] 163 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 166 | fn to_id_map(items: Vec) -> HashMap { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / items.into_iter() [INFO] [stdout] 168 | | .map(|i| (i.id(), i)) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vocabulearn` (bin "vocabulearn" test) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `labels`, `label_mapping`, `labels_file`, and `map_file` are never read [INFO] [stdout] --> src/data.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct Vocab { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 45 | vocab: HashMap, [INFO] [stdout] 46 | labels: HashMap, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 47 | label_mapping: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 48 | vocab_file: String, [INFO] [stdout] 49 | labels_file: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 50 | map_file: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `correct` and `wrong` are never read [INFO] [stdout] --> src/data.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct QuizResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 126 | pub correct: usize, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 127 | pub wrong: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuizResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:24:10 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Deserialize, Serialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | self.save_vocab(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 106 | let _ = self.save_vocab(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | fs::rename(&self.vocab_file, archive_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 118 | let _ = fs::rename(&self.vocab_file, archive_file); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | fs::rename(new_file, &self.vocab_file); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 119 | let _ = fs::rename(new_file, &self.vocab_file); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 160 | let mut rdr = csv::Reader::from_path(filename)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Ok(rdr.deserialize() [INFO] [stdout] | ________^ [INFO] [stdout] 162 | | .map(|r| r.unwrap()) [INFO] [stdout] 163 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 166 | fn to_id_map(items: Vec) -> HashMap { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | / items.into_iter() [INFO] [stdout] 168 | | .map(|i| (i.id(), i)) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vocabulearn` (bin "vocabulearn") due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e5fe02f4f7a0fc469d5a785abe7ad7a8fe0ca4ad2c121c13aadafabf57f26a3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5fe02f4f7a0fc469d5a785abe7ad7a8fe0ca4ad2c121c13aadafabf57f26a3d", kill_on_drop: false }` [INFO] [stdout] e5fe02f4f7a0fc469d5a785abe7ad7a8fe0ca4ad2c121c13aadafabf57f26a3d