[INFO] cloning repository https://github.com/WolfeCub/goto [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WolfeCub/goto" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWolfeCub%2Fgoto", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWolfeCub%2Fgoto'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5be464e1b9b29e72504c8f277dbba0984195ad62 [INFO] checking WolfeCub/goto/5be464e1b9b29e72504c8f277dbba0984195ad62 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWolfeCub%2Fgoto" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/WolfeCub/goto on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/WolfeCub/goto [INFO] finished tweaking git repo https://github.com/WolfeCub/goto [INFO] tweaked toml for git repo https://github.com/WolfeCub/goto written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/WolfeCub/goto already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27d4a53b0bcb747a7bdbf4f6e6aba79b74e21c8f46da702a2fd69c6a298fe31c [INFO] running `Command { std: "docker" "start" "-a" "27d4a53b0bcb747a7bdbf4f6e6aba79b74e21c8f46da702a2fd69c6a298fe31c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27d4a53b0bcb747a7bdbf4f6e6aba79b74e21c8f46da702a2fd69c6a298fe31c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27d4a53b0bcb747a7bdbf4f6e6aba79b74e21c8f46da702a2fd69c6a298fe31c", kill_on_drop: false }` [INFO] [stdout] 27d4a53b0bcb747a7bdbf4f6e6aba79b74e21c8f46da702a2fd69c6a298fe31c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2bbd10048161c00e90bc632205f588651213a7242de1f476c76aa2ab92b33c5 [INFO] running `Command { std: "docker" "start" "-a" "d2bbd10048161c00e90bc632205f588651213a7242de1f476c76aa2ab92b33c5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking deranged v0.3.8 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Checking defer-drop v1.3.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Compiling syn v2.0.31 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking shlex v1.2.0 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking chrono v0.4.30 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking time v0.3.28 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking tuikit v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking skim v0.10.4 [INFO] [stderr] Checking serde_yaml v0.9.25 [INFO] [stderr] Checking goto v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `serialize_goto_file` is never used [INFO] [stdout] --> src/file.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn serialize_goto_file(goto_file: GotoFile) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 59 | .map(|f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | f.expect("Unable to read file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn add_option(&self, item: T) -> anyhow::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / self.tx_item [INFO] [stdout] 90 | | .send(Arc::new(item)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn run(self, initial_input: &str) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let options = SkimOptionsBuilder::default() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let selected_items = Skim::run_with(&options, Some(self.rx_item)) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok((*selected_dir).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 26 | let f = File::open(path.as_path()).with_context(|| "File `{path}` does not exist")?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | serde_yaml::from_reader::<_, GotoFile>(io::BufReader::new(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `serialize_goto_file` is never used [INFO] [stdout] --> src/file.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn serialize_goto_file(goto_file: GotoFile) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 59 | .map(|f| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | f.expect("Unable to read file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn add_option(&self, item: T) -> anyhow::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | / self.tx_item [INFO] [stdout] 90 | | .send(Arc::new(item)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuzzy.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn run(self, initial_input: &str) -> anyhow::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let options = SkimOptionsBuilder::default() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let selected_items = Skim::run_with(&options, Some(self.rx_item)) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok((*selected_dir).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 26 | let f = File::open(path.as_path()).with_context(|| "File `{path}` does not exist")?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | serde_yaml::from_reader::<_, GotoFile>(io::BufReader::new(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goto` (bin "goto_rs") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goto` (bin "goto_rs" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d2bbd10048161c00e90bc632205f588651213a7242de1f476c76aa2ab92b33c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2bbd10048161c00e90bc632205f588651213a7242de1f476c76aa2ab92b33c5", kill_on_drop: false }` [INFO] [stdout] d2bbd10048161c00e90bc632205f588651213a7242de1f476c76aa2ab92b33c5