[INFO] cloning repository https://github.com/WindSoilder/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WindSoilder/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWindSoilder%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWindSoilder%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4f88e74bbe8e22eb5d0f3a3891cf77c380d39ec2 [INFO] checking WindSoilder/kvs/4f88e74bbe8e22eb5d0f3a3891cf77c380d39ec2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWindSoilder%2Fkvs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/WindSoilder/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/WindSoilder/kvs [INFO] finished tweaking git repo https://github.com/WindSoilder/kvs [INFO] tweaked toml for git repo https://github.com/WindSoilder/kvs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/WindSoilder/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 323e21e40da07c819185d34bd4f9241d2423f87896b7fd60be900a158558125f [INFO] running `Command { std: "docker" "start" "-a" "323e21e40da07c819185d34bd4f9241d2423f87896b7fd60be900a158558125f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "323e21e40da07c819185d34bd4f9241d2423f87896b7fd60be900a158558125f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "323e21e40da07c819185d34bd4f9241d2423f87896b7fd60be900a158558125f", kill_on_drop: false }` [INFO] [stdout] 323e21e40da07c819185d34bd4f9241d2423f87896b7fd60be900a158558125f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af1fd145e825965858a22242c4dc184c17da92a80f297d46500b8aa9941c42a6 [INFO] running `Command { std: "docker" "start" "-a" "af1fd145e825965858a22242c4dc184c17da92a80f297d46500b8aa9941c42a6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling proc-macro2 v1.0.2 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling serde v1.0.100 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling bincode v1.1.4 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking itertools v0.8.1 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking panic-control v0.1.4 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rand v0.7.1 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking serde_bytes v0.11.2 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking sled v0.29.1 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let db_writer: BufWriterSeekable = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | BufWriterSeekable::new(OpenOptions::new().write(true).create(true).open(&f_path)?); [INFO] [stdout] 103 | let mut db_reader: BufReaderSeekable = BufReaderSeekable::new(File::open(&f_path)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(KvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | inner: Arc::new(Mutex::new(InnerStore { [INFO] [stdout] 108 | | reader: db_reader, [INFO] [stdout] 109 | | writer: db_writer, [INFO] [stdout] ... | [INFO] [stdout] 113 | | })), [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 206 | fn new(reader: T) -> BufReaderSeekable { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | BufReaderSeekable { [INFO] [stdout] 208 | inner: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:247:20 [INFO] [stdout] | [INFO] [stdout] 245 | fn new(writer: T) -> BufWriterSeekable { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | BufWriterSeekable { [INFO] [stdout] 247 | inner: BufWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 52 | fn from(error: SledError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | KvsError { [INFO] [stdout] 54 | repr: Repr::SledError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(error: io::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | KvsError { [INFO] [stdout] 62 | repr: Repr::IOError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(error: BincodeError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | KvsError { [INFO] [stdout] 70 | repr: Repr::BinCodeError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(error: JsonError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | KvsError { [INFO] [stdout] 78 | repr: Repr::JsonError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | let stream: TcpStream = TcpStream::connect(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Client { inner: stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(addr: T, engine: E, thread_pool: P) -> Result> [INFO] [stdout] | ------- --------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | listener: TcpListener::bind(addr)?, [INFO] [stdout] 23 | | engine, [INFO] [stdout] 24 | | thread_pool, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/response.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared_queue.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 53 | let (sender, receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let receiver: Mutex> = Mutex::new(receiver); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let shared_data = Arc::new(SharedData { receiver }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(SharedQueueThreadPool { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | sender, [INFO] [stdout] 63 | | max_threads, [INFO] [stdout] 64 | | _shared_data: shared_data, [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:5:28 [INFO] [stdout] | [INFO] [stdout] 5 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let db_writer: BufWriterSeekable = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | BufWriterSeekable::new(OpenOptions::new().write(true).create(true).open(&f_path)?); [INFO] [stdout] 103 | let mut db_reader: BufReaderSeekable = BufReaderSeekable::new(File::open(&f_path)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(KvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | inner: Arc::new(Mutex::new(InnerStore { [INFO] [stdout] 108 | | reader: db_reader, [INFO] [stdout] 109 | | writer: db_writer, [INFO] [stdout] ... | [INFO] [stdout] 113 | | })), [INFO] [stdout] 114 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 206 | fn new(reader: T) -> BufReaderSeekable { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | BufReaderSeekable { [INFO] [stdout] 208 | inner: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/kvs.rs:247:20 [INFO] [stdout] | [INFO] [stdout] 245 | fn new(writer: T) -> BufWriterSeekable { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | BufWriterSeekable { [INFO] [stdout] 247 | inner: BufWriter::new(writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 13 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 52 | fn from(error: SledError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | KvsError { [INFO] [stdout] 54 | repr: Repr::SledError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(error: io::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | KvsError { [INFO] [stdout] 62 | repr: Repr::IOError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(error: BincodeError) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | KvsError { [INFO] [stdout] 70 | repr: Repr::BinCodeError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 76 | fn from(error: JsonError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | KvsError { [INFO] [stdout] 78 | repr: Repr::JsonError(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | let stream: TcpStream = TcpStream::connect(addr)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Client { inner: stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(addr: T, engine: E, thread_pool: P) -> Result> [INFO] [stdout] | ------- --------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | listener: TcpListener::bind(addr)?, [INFO] [stdout] 23 | | engine, [INFO] [stdout] 24 | | thread_pool, [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/response.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared_queue.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 53 | let (sender, receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let receiver: Mutex> = Mutex::new(receiver); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let shared_data = Arc::new(SharedData { receiver }); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(SharedQueueThreadPool { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | sender, [INFO] [stdout] 63 | | max_threads, [INFO] [stdout] 64 | | _shared_data: shared_data, [INFO] [stdout] 65 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "af1fd145e825965858a22242c4dc184c17da92a80f297d46500b8aa9941c42a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af1fd145e825965858a22242c4dc184c17da92a80f297d46500b8aa9941c42a6", kill_on_drop: false }` [INFO] [stdout] af1fd145e825965858a22242c4dc184c17da92a80f297d46500b8aa9941c42a6