[INFO] cloning repository https://github.com/Wesley-Arizio/rust-design-pattern-implementations [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Wesley-Arizio/rust-design-pattern-implementations" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWesley-Arizio%2Frust-design-pattern-implementations", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWesley-Arizio%2Frust-design-pattern-implementations'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f7b96a6cc9cb6bc4caf4e866a3f93ee21ee2eba [INFO] checking Wesley-Arizio/rust-design-pattern-implementations/1f7b96a6cc9cb6bc4caf4e866a3f93ee21ee2eba against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWesley-Arizio%2Frust-design-pattern-implementations" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Wesley-Arizio/rust-design-pattern-implementations on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Wesley-Arizio/rust-design-pattern-implementations [INFO] finished tweaking git repo https://github.com/Wesley-Arizio/rust-design-pattern-implementations [INFO] tweaked toml for git repo https://github.com/Wesley-Arizio/rust-design-pattern-implementations written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Wesley-Arizio/rust-design-pattern-implementations already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8dc7af3dd9617bcad00be3d570ec4f928b8e006641bfff176cfb19b8c4448a48 [INFO] running `Command { std: "docker" "start" "-a" "8dc7af3dd9617bcad00be3d570ec4f928b8e006641bfff176cfb19b8c4448a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8dc7af3dd9617bcad00be3d570ec4f928b8e006641bfff176cfb19b8c4448a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8dc7af3dd9617bcad00be3d570ec4f928b8e006641bfff176cfb19b8c4448a48", kill_on_drop: false }` [INFO] [stdout] 8dc7af3dd9617bcad00be3d570ec4f928b8e006641bfff176cfb19b8c4448a48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ecb1e0d45732343db196d7024ac95b153d1dfb970dd537a0bfbf497aa9d87f13 [INFO] running `Command { std: "docker" "start" "-a" "ecb1e0d45732343db196d7024ac95b153d1dfb970dd537a0bfbf497aa9d87f13", kill_on_drop: false }` [INFO] [stderr] Checking rust-design-pattern-implementations v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `disconnect` is never used [INFO] [stdout] --> src/impls/creational/abstract_factory/traits.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait Controller { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 14 | fn disconnect(&mut self) -> (); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `status` is never used [INFO] [stdout] --> src/impls/creational/abstract_factory/traits.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub trait Console { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 19 | fn power(&mut self) -> (); [INFO] [stdout] 20 | fn status(&self) -> &ConsoleStatus; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls/creational/factory_method/person.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: &str, age: u8, factory: Box>) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | tool: factory.create_tool(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-design-pattern-implementations` (bin "rust-design-pattern-implementations") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `disconnect` is never used [INFO] [stdout] --> src/impls/creational/abstract_factory/traits.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait Controller { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 14 | fn disconnect(&mut self) -> (); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `status` is never used [INFO] [stdout] --> src/impls/creational/abstract_factory/traits.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 18 | pub trait Console { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 19 | fn power(&mut self) -> (); [INFO] [stdout] 20 | fn status(&self) -> &ConsoleStatus; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/impls/creational/factory_method/person.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(name: &str, age: u8, factory: Box>) -> Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | tool: factory.create_tool(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-design-pattern-implementations` (bin "rust-design-pattern-implementations" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ecb1e0d45732343db196d7024ac95b153d1dfb970dd537a0bfbf497aa9d87f13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecb1e0d45732343db196d7024ac95b153d1dfb970dd537a0bfbf497aa9d87f13", kill_on_drop: false }` [INFO] [stdout] ecb1e0d45732343db196d7024ac95b153d1dfb970dd537a0bfbf497aa9d87f13