[INFO] cloning repository https://github.com/Wcubed/dungeondraft-asset-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Wcubed/dungeondraft-asset-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWcubed%2Fdungeondraft-asset-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWcubed%2Fdungeondraft-asset-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6b0ffde87bb09b08b58dbc4b4d7b2dc91217f8b8 [INFO] checking Wcubed/dungeondraft-asset-tools/6b0ffde87bb09b08b58dbc4b4d7b2dc91217f8b8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWcubed%2Fdungeondraft-asset-tools" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Wcubed/dungeondraft-asset-tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Wcubed/dungeondraft-asset-tools [INFO] finished tweaking git repo https://github.com/Wcubed/dungeondraft-asset-tools [INFO] tweaked toml for git repo https://github.com/Wcubed/dungeondraft-asset-tools written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Wcubed/dungeondraft-asset-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a1b7524c319ba328711225331dee9d91c4e8a5f13e7944b8e5c3d997d60f2d3 [INFO] running `Command { std: "docker" "start" "-a" "6a1b7524c319ba328711225331dee9d91c4e8a5f13e7944b8e5c3d997d60f2d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a1b7524c319ba328711225331dee9d91c4e8a5f13e7944b8e5c3d997d60f2d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a1b7524c319ba328711225331dee9d91c4e8a5f13e7944b8e5c3d997d60f2d3", kill_on_drop: false }` [INFO] [stdout] 6a1b7524c319ba328711225331dee9d91c4e8a5f13e7944b8e5c3d997d60f2d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8e7b45530938e73fce82466c2d8f1b939746da3aac8ef00dcb595b964740815b [INFO] running `Command { std: "docker" "start" "-a" "8e7b45530938e73fce82466c2d8f1b939746da3aac8ef00dcb595b964740815b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking simplelog v0.10.2 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking dd_asset_tools v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `get_files_in_tag` is never used [INFO] [stdout] --> src/asset_pack/asset_pack.rs:257:8 [INFO] [stdout] | [INFO] [stdout] 25 | impl AssetPack { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 257 | fn get_files_in_tag(&self, tag: &str) -> Option<&HashSet> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `md5` is never read [INFO] [stdout] --> src/asset_pack/file_meta_data.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct FileMetaData { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub md5: [u8; MD5_BYTES], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileMetaData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/asset_pack/godot_version.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl GodotVersion { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 18 | pub fn new(version: i32, major: i32, minor: i32, revision: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut file = match File::create(&output_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | match pack.to_write(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset_pack/asset_pack.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 62 | let mut maybe_tags = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let tags = maybe_tags.unwrap_or(Tags::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | Ok(AssetPack { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | godot_version, [INFO] [stdout] 106 | | meta: maybe_meta.unwrap(), [INFO] [stdout] 107 | | tags, [INFO] [stdout] 108 | | object_files, [INFO] [stdout] 109 | | other_files, [INFO] [stdout] 110 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd_asset_tools` (bin "dd_asset_tools") due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 183 | let mut file = match File::create(&output_path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Ok(f) => f, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | match pack.to_write(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset_pack/asset_pack.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 62 | let mut maybe_tags = None; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let tags = maybe_tags.unwrap_or(Tags::new()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | Ok(AssetPack { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | godot_version, [INFO] [stdout] 106 | | meta: maybe_meta.unwrap(), [INFO] [stdout] 107 | | tags, [INFO] [stdout] 108 | | object_files, [INFO] [stdout] 109 | | other_files, [INFO] [stdout] 110 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd_asset_tools` (bin "dd_asset_tools" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "8e7b45530938e73fce82466c2d8f1b939746da3aac8ef00dcb595b964740815b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e7b45530938e73fce82466c2d8f1b939746da3aac8ef00dcb595b964740815b", kill_on_drop: false }` [INFO] [stdout] 8e7b45530938e73fce82466c2d8f1b939746da3aac8ef00dcb595b964740815b