[INFO] cloning repository https://github.com/WalrusGumboot/schaak [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WalrusGumboot/schaak" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWalrusGumboot%2Fschaak", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWalrusGumboot%2Fschaak'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 85e57e085a763b3b019ef8f0c74e2179b23f4b5c [INFO] checking WalrusGumboot/schaak/85e57e085a763b3b019ef8f0c74e2179b23f4b5c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWalrusGumboot%2Fschaak" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/WalrusGumboot/schaak on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/WalrusGumboot/schaak [INFO] finished tweaking git repo https://github.com/WalrusGumboot/schaak [INFO] tweaked toml for git repo https://github.com/WalrusGumboot/schaak written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/WalrusGumboot/schaak already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aa33d2448434d0074aa0cb8826e73fdfad9f953d950d98e1d21f295a2f36827 [INFO] running `Command { std: "docker" "start" "-a" "6aa33d2448434d0074aa0cb8826e73fdfad9f953d950d98e1d21f295a2f36827", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aa33d2448434d0074aa0cb8826e73fdfad9f953d950d98e1d21f295a2f36827", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aa33d2448434d0074aa0cb8826e73fdfad9f953d950d98e1d21f295a2f36827", kill_on_drop: false }` [INFO] [stdout] 6aa33d2448434d0074aa0cb8826e73fdfad9f953d950d98e1d21f295a2f36827 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ebde2eb6d52ef896c41d30119634c22735957f2596feae4d8faec3e3d8b806c5 [INFO] running `Command { std: "docker" "start" "-a" "ebde2eb6d52ef896c41d30119634c22735957f2596feae4d8faec3e3d8b806c5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.142 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking schaak v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/state.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn get_all_moves_for_colour(&self, col: ChessColour) -> Vec<((u8, u8), ChessMove)> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `coord` [INFO] [stdout] --> src/state.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | .filter(|(coord, content)| content.is_some()) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_coord` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/state.rs:143:27 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|(coord, content)| { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `col` [INFO] [stdout] --> src/state.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn get_all_moves_for_colour(&self, col: ChessColour) -> Vec<((u8, u8), ChessMove)> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_col` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `coord` [INFO] [stdout] --> src/state.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | .filter(|(coord, content)| content.is_some()) [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_coord` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `content` [INFO] [stdout] --> src/state.rs:143:27 [INFO] [stdout] | [INFO] [stdout] 143 | .map(|(coord, content)| { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `attempt_move` is never used [INFO] [stdout] --> src/state.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 155 | pub fn attempt_move(&mut self, target_coordinate: (u8, u8)) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:364:41 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|s| (s.coords, state.get_moves(s.coords, true))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:367:25 [INFO] [stdout] | [INFO] [stdout] 365 | .map(|(square, moves)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | // we will test if making the move still leaves the king in check [INFO] [stdout] 367 | moves.into_iter().all(|m| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `attempt_move` is never used [INFO] [stdout] --> src/state.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 155 | pub fn attempt_move(&mut self, target_coordinate: (u8, u8)) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:364:41 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|s| (s.coords, state.get_moves(s.coords, true))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:367:25 [INFO] [stdout] | [INFO] [stdout] 365 | .map(|(square, moves)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | // we will test if making the move still leaves the king in check [INFO] [stdout] 367 | moves.into_iter().all(|m| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 458 | tx_to_white_player.send(new_white_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 458 | let _ = tx_to_white_player.send(new_white_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:459:21 [INFO] [stdout] | [INFO] [stdout] 459 | tx_to_black_player.send(new_white_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 459 | let _ = tx_to_black_player.send(new_white_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:468:21 [INFO] [stdout] | [INFO] [stdout] 468 | tx_to_white_player.send(new_black_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 468 | let _ = tx_to_white_player.send(new_black_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 469 | tx_to_black_player.send(new_black_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 469 | let _ = tx_to_black_player.send(new_black_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 77 | rx_from_main: Receiver, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let (own_tx, own_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / RandomPlayer { [INFO] [stdout] 85 | | rx_from_main, [INFO] [stdout] 86 | | tx_to_main: own_tx, [INFO] [stdout] 87 | | internal_state: state_to_clone.clone(), [INFO] [stdout] ... | [INFO] [stdout] 90 | | colour, [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 458 | tx_to_white_player.send(new_white_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 458 | let _ = tx_to_white_player.send(new_white_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:459:21 [INFO] [stdout] | [INFO] [stdout] 459 | tx_to_black_player.send(new_white_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 459 | let _ = tx_to_black_player.send(new_white_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:468:21 [INFO] [stdout] | [INFO] [stdout] 468 | tx_to_white_player.send(new_black_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 468 | let _ = tx_to_white_player.send(new_black_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 469 | tx_to_black_player.send(new_black_move.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 469 | let _ = tx_to_black_player.send(new_black_move.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 77 | rx_from_main: Receiver, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let (own_tx, own_rx) = mpsc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / RandomPlayer { [INFO] [stdout] 85 | | rx_from_main, [INFO] [stdout] 86 | | tx_to_main: own_tx, [INFO] [stdout] 87 | | internal_state: state_to_clone.clone(), [INFO] [stdout] ... | [INFO] [stdout] 90 | | colour, [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `schaak` (bin "schaak") due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `schaak` (bin "schaak" test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ebde2eb6d52ef896c41d30119634c22735957f2596feae4d8faec3e3d8b806c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebde2eb6d52ef896c41d30119634c22735957f2596feae4d8faec3e3d8b806c5", kill_on_drop: false }` [INFO] [stdout] ebde2eb6d52ef896c41d30119634c22735957f2596feae4d8faec3e3d8b806c5