[INFO] cloning repository https://github.com/Wafelack/raytracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Wafelack/raytracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWafelack%2Fraytracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWafelack%2Fraytracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f40c6a9ede0b44af85ba6e3a56c21368154c727 [INFO] checking Wafelack/raytracer/5f40c6a9ede0b44af85ba6e3a56c21368154c727 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWafelack%2Fraytracer" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Wafelack/raytracer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Wafelack/raytracer [INFO] finished tweaking git repo https://github.com/Wafelack/raytracer [INFO] tweaked toml for git repo https://github.com/Wafelack/raytracer written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Wafelack/raytracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c74c3d861f328efd502ff8b61981e5983f64d6081a657d988f7f105e5ee51bf7 [INFO] running `Command { std: "docker" "start" "-a" "c74c3d861f328efd502ff8b61981e5983f64d6081a657d988f7f105e5ee51bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c74c3d861f328efd502ff8b61981e5983f64d6081a657d988f7f105e5ee51bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c74c3d861f328efd502ff8b61981e5983f64d6081a657d988f7f105e5ee51bf7", kill_on_drop: false }` [INFO] [stdout] c74c3d861f328efd502ff8b61981e5983f64d6081a657d988f7f105e5ee51bf7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc6e0bee0335fe1233a3097677dc877247e621b1c3cdfdd9a12a1f3af9dd79e0 [INFO] running `Command { std: "docker" "start" "-a" "fc6e0bee0335fe1233a3097677dc877247e621b1c3cdfdd9a12a1f3af9dd79e0", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling const_fn v0.4.4 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling stb_image v0.2.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `point3` should have an upper camel case name [INFO] [stdout] --> src/vec3.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 188 | pub type point3 = Vec3; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Point3` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `color` should have an upper camel case name [INFO] [stdout] --> src/vec3.rs:189:10 [INFO] [stdout] | [INFO] [stdout] 189 | pub type color = Vec3; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `point3` should have an upper camel case name [INFO] [stdout] --> src/vec3.rs:188:10 [INFO] [stdout] | [INFO] [stdout] 188 | pub type point3 = Vec3; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Point3` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `color` should have an upper camel case name [INFO] [stdout] --> src/vec3.rs:189:10 [INFO] [stdout] | [INFO] [stdout] 189 | pub type color = Vec3; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:167:26 [INFO] [stdout] | [INFO] [stdout] 167 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:167:38 [INFO] [stdout] | [INFO] [stdout] 167 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/bvh.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/bvh.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `focal_length` [INFO] [stdout] --> src/camera.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let focal_length = 1.; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_focal_length` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/aarect.rs:167:26 [INFO] [stdout] | [INFO] [stdout] 167 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/aarect.rs:167:38 [INFO] [stdout] | [INFO] [stdout] 167 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/material/material.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/material/material.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/material/material.rs:12:39 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/bvh.rs:79:33 [INFO] [stdout] | [INFO] [stdout] 79 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/bvh.rs:79:45 [INFO] [stdout] | [INFO] [stdout] 79 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material/material.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | r_in: Ray, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material/material.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | rec: HitRecord, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `focal_length` [INFO] [stdout] --> src/camera.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let focal_length = 1.; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_focal_length` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `attenuation` [INFO] [stdout] --> src/material/material.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | attenuation: &mut color, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_attenuation` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material/material.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | scattered: &mut Ray, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/objects/hittable.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t_min` [INFO] [stdout] --> src/objects/hittable.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_t_min` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t_max` [INFO] [stdout] --> src/objects/hittable.rs:44:47 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_t_max` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/objects/hittable.rs:44:59 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/hittable.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/hittable.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_box` [INFO] [stdout] --> src/objects/hittable.rs:47:59 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_box` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/hittable.rs:140:28 [INFO] [stdout] | [INFO] [stdout] 140 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/hittable.rs:140:40 [INFO] [stdout] | [INFO] [stdout] 140 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `front_face` [INFO] [stdout] --> src/objects/moving_sphere.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut front_face = false; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_front_face` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/moving_sphere.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut front_face = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `front_face` [INFO] [stdout] --> src/objects/sphere.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | let mut front_face = false; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_front_face` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/sphere.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut front_face = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/sphere.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/sphere.rs:62:47 [INFO] [stdout] | [INFO] [stdout] 62 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/material/material.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/material/material.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/material/material.rs:12:39 [INFO] [stdout] | [INFO] [stdout] 12 | fn emitted(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/texture.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/texture.rs:30:27 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/texture.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r_in` [INFO] [stdout] --> src/material/material.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | r_in: Ray, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_r_in` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/material/material.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | rec: HitRecord, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `attenuation` [INFO] [stdout] --> src/material/material.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | attenuation: &mut color, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_attenuation` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `scattered` [INFO] [stdout] --> src/material/material.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | scattered: &mut Ray, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scattered` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/texture.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/texture.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/objects/hittable.rs:44:26 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t_min` [INFO] [stdout] --> src/objects/hittable.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_t_min` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t_max` [INFO] [stdout] --> src/objects/hittable.rs:44:47 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_t_max` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rec` [INFO] [stdout] --> src/objects/hittable.rs:44:59 [INFO] [stdout] | [INFO] [stdout] 44 | fn hit<'a>(&'a self, r: &Ray, t_min: f32, t_max: f32, rec: &mut HitRecord<'a>) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rec` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/hittable.rs:47:35 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/hittable.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_box` [INFO] [stdout] --> src/objects/hittable.rs:47:59 [INFO] [stdout] | [INFO] [stdout] 47 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_box` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/texture.rs:141:35 [INFO] [stdout] | [INFO] [stdout] 141 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/hittable.rs:140:28 [INFO] [stdout] | [INFO] [stdout] 140 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/hittable.rs:140:40 [INFO] [stdout] | [INFO] [stdout] 140 | fn bounding_box(&self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/main.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | for j in 0..ns { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `front_face` [INFO] [stdout] --> src/objects/moving_sphere.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut front_face = false; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_front_face` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/moving_sphere.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut front_face = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `front_face` [INFO] [stdout] --> src/objects/sphere.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | let mut front_face = false; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_front_face` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/sphere.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let mut front_face = false; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time0` [INFO] [stdout] --> src/objects/sphere.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time0` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time1` [INFO] [stdout] --> src/objects/sphere.rs:62:47 [INFO] [stdout] | [INFO] [stdout] 62 | fn bounding_box<'a>(&'a self, time0: f32, time1: f32, output_box: &mut Aabb) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_time1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `sphere_material` is never read [INFO] [stdout] --> src/main.rs:386:25 [INFO] [stdout] | [INFO] [stdout] 386 | let mut sphere_material: Arc = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/texture.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/texture.rs:30:27 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/texture.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `u` [INFO] [stdout] --> src/texture.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/texture.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 457 | let mut vup = Vec3::from(0., 1., 0.); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | let mut dist_to_focus: f32 = 10.0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | let mut aperture: f32 = 0.0; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/texture.rs:141:35 [INFO] [stdout] | [INFO] [stdout] 141 | fn value(&self, u: f32, v: f32, p: &point3) -> color { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_color` is never used [INFO] [stdout] --> src/colors.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn write_color(pixel_color: color, samples_per_pixel: i32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `box_min` and `box_max` are never read [INFO] [stdout] --> src/material/boxx.rs:8:3 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Boxx { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 8 | box_min: point3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 9 | box_max: point3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `point_count` is never read [INFO] [stdout] --> src/perlin.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Perlin { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 4 | point_count: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bvh.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 26 | let mut left: Arc = objects[start].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut right: Arc = objects[start].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | left: left.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bvh.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 26 | let mut left: Arc = objects[start].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut right: Arc = objects[start].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | right: right.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/bvh.rs:48:7 [INFO] [stdout] | [INFO] [stdout] 48 | / &objects[start..end].sort_unstable_by(|a, b| { [INFO] [stdout] 49 | | if comparator(&**a, &**b) { [INFO] [stdout] 50 | | std::cmp::Ordering::Greater [INFO] [stdout] 51 | | } else { [INFO] [stdout] 52 | | std::cmp::Ordering::Less [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | }); [INFO] [stdout] | |________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &objects[start..end].sort_unstable_by(|a, b| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 55 | func: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | mut progress: P, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let notify = Arc::new((Mutex::new(()) , Condvar::new() , AtomicUsize::new(0_usize))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let nt = Arc::clone(¬ify); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let notify_thread = std::thread::spawn(move ||{ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | pixels: pixels.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn from_texture(b: Arc, d: f32, a: Arc) -> Self { [INFO] [stdout] | -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | phase_function: Arc::new(Isotropic::from_texture(a)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn from_color(b: Arc, d: f32, c: color) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | phase_function: Arc::new(Isotropic::from_color(c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/main.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | for j in 0..ns { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 49 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `sphere_material` is never read [INFO] [stdout] --> src/main.rs:386:25 [INFO] [stdout] | [INFO] [stdout] 386 | let mut sphere_material: Arc = [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:457:9 [INFO] [stdout] | [INFO] [stdout] 457 | let mut vup = Vec3::from(0., 1., 0.); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:458:9 [INFO] [stdout] | [INFO] [stdout] 458 | let mut dist_to_focus: f32 = 10.0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | let mut aperture: f32 = 0.0; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w` is never read [INFO] [stdout] --> src/camera.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Camera { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | w: Vec3, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_color` is never used [INFO] [stdout] --> src/colors.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn write_color(pixel_color: color, samples_per_pixel: i32) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `box_min` and `box_max` are never read [INFO] [stdout] --> src/material/boxx.rs:8:3 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Boxx { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 8 | box_min: point3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 9 | box_max: point3, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `point_count` is never read [INFO] [stdout] --> src/perlin.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Perlin { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 4 | point_count: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer") due to 6 previous errors; 49 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bvh.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 26 | let mut left: Arc = objects[start].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut right: Arc = objects[start].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | left: left.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bvh.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 26 | let mut left: Arc = objects[start].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut right: Arc = objects[start].clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | right: right.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/bvh.rs:48:7 [INFO] [stdout] | [INFO] [stdout] 48 | / &objects[start..end].sort_unstable_by(|a, b| { [INFO] [stdout] 49 | | if comparator(&**a, &**b) { [INFO] [stdout] 50 | | std::cmp::Ordering::Greater [INFO] [stdout] 51 | | } else { [INFO] [stdout] 52 | | std::cmp::Ordering::Less [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | }); [INFO] [stdout] | |________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &objects[start..end].sort_unstable_by(|a, b| { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 55 | func: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | mut progress: P, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let notify = Arc::new((Mutex::new(()) , Condvar::new() , AtomicUsize::new(0_usize))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let nt = Arc::clone(¬ify); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let notify_thread = std::thread::spawn(move ||{ [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | pixels: pixels.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn from_texture(b: Arc, d: f32, a: Arc) -> Self { [INFO] [stdout] | -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | phase_function: Arc::new(Isotropic::from_texture(a)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/constant_medium.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn from_color(b: Arc, d: f32, c: color) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | phase_function: Arc::new(Isotropic::from_color(c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 49 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer" test) due to 6 previous errors; 49 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fc6e0bee0335fe1233a3097677dc877247e621b1c3cdfdd9a12a1f3af9dd79e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc6e0bee0335fe1233a3097677dc877247e621b1c3cdfdd9a12a1f3af9dd79e0", kill_on_drop: false }` [INFO] [stdout] fc6e0bee0335fe1233a3097677dc877247e621b1c3cdfdd9a12a1f3af9dd79e0