[INFO] cloning repository https://github.com/WToma/missingparts [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/WToma/missingparts" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWToma%2Fmissingparts", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWToma%2Fmissingparts'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 82255bef746971ff86b145d4425793dd0fdb43b2 [INFO] checking WToma/missingparts/82255bef746971ff86b145d4425793dd0fdb43b2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FWToma%2Fmissingparts" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/WToma/missingparts on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/WToma/missingparts [INFO] finished tweaking git repo https://github.com/WToma/missingparts [INFO] tweaked toml for git repo https://github.com/WToma/missingparts written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/WToma/missingparts already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa35165bab5dc9ed29dc9b621fabff2171cfb0ac855107539e1bb0c67567c004 [INFO] running `Command { std: "docker" "start" "-a" "aa35165bab5dc9ed29dc9b621fabff2171cfb0ac855107539e1bb0c67567c004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa35165bab5dc9ed29dc9b621fabff2171cfb0ac855107539e1bb0c67567c004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa35165bab5dc9ed29dc9b621fabff2171cfb0ac855107539e1bb0c67567c004", kill_on_drop: false }` [INFO] [stdout] aa35165bab5dc9ed29dc9b621fabff2171cfb0ac855107539e1bb0c67567c004 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8bfe0b88ed8a99f02e8d95302b54a6de30da41d30d1635860f95ae00f987318 [INFO] running `Command { std: "docker" "start" "-a" "d8bfe0b88ed8a99f02e8d95302b54a6de30da41d30d1635860f95ae00f987318", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking futures-core v0.3.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking futures-task v0.3.2 [INFO] [stderr] Checking futures-sink v0.3.2 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking futures-util v0.3.2 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking futures-channel v0.3.2 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Compiling indexmap v1.3.1 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking http v0.2.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Compiling pest_generator v2.1.2 [INFO] [stderr] Compiling tokio-macros v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling pin-project-internal v0.4.8 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking tokio v0.2.11 [INFO] [stderr] Checking pin-project v0.4.8 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking h2 v0.2.1 [INFO] [stderr] Checking hyper v0.13.2 [INFO] [stderr] Checking json5 v0.2.5 [INFO] [stderr] Checking serde_json v1.0.46 [INFO] [stderr] Checking missingparts v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cards.rs:12:62 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cards.rs:68:62 [INFO] [stdout] | [INFO] [stdout] 68 | #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_manager.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn with_game(&self, game_id: GameId, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let game = self.games.get(&game_id); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | game.map(|g| f(&g)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playeraction.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Debug, PartialEq, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_utils.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 87 | fn into(self) -> Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | JsonError(e) => ( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | / Response::builder() [INFO] [stdout] 139 | | .status(code) [INFO] [stdout] 140 | | .body(Body::from(message)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `missingparts` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | |mut g| g.state = state_scavenged(0, &["q c"]), // but it's player 0's turn to finish the scavenge [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | |mut g| g.state = state_scavenged(0, &["k c"]), // but the scavenge only contained King of Clubs [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:111:10 [INFO] [stdout] | [INFO] [stdout] 111 | |mut g| g.state = state_trading(1, 0, "3 h", "2 h"), // that they started themselves [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:126:10 [INFO] [stdout] | [INFO] [stdout] 126 | |mut g| g.state = state_trading(1, 0, "3 h", "2 h"), // that they started themselves [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:598:10 [INFO] [stdout] | [INFO] [stdout] 598 | |mut g| g.state = GameState::WaitingForPlayerAction { player: 1 }, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:607:10 [INFO] [stdout] | [INFO] [stdout] 607 | |mut g| { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./gameplay_test.rs:621:10 [INFO] [stdout] | [INFO] [stdout] 621 | |mut g| g.draw = empty_deck(), [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actionerror.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 18 | #[cfg_attr(test, derive(Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cards.rs:12:62 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cards.rs:68:62 [INFO] [stdout] | [INFO] [stdout] 68 | #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_manager.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn with_game(&self, game_id: GameId, f: F) -> Option [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let game = self.games.get(&game_id); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | game.map(|g| f(&g)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gameplay.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | #[cfg_attr(test, derive(Deserialize))] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:791:9 [INFO] [stdout] | [INFO] [stdout] 782 | lobby: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 783 | game_manager: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 784 | ) -> Response { [INFO] [stdout] 785 | let req_builder = Request::get(uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 786 | let req_builder = match token { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 790 | let req = req_builder.body(Body::empty()).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 791 | / Runtime::new() [INFO] [stdout] 792 | | .unwrap() [INFO] [stdout] 793 | | .block_on(missingparts_service(lobby, game_manager, req)) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:811:9 [INFO] [stdout] | [INFO] [stdout] 801 | lobby: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | game_manager: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 803 | ) -> Response { [INFO] [stdout] 804 | let req_builder = Request::post(uri); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 805 | let req_builder = match token { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 809 | let req_builder = req_builder.header("Content-Length", &format!("{:?}", body.len())); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 810 | let req = req_builder.body(Body::from(body)).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 811 | / Runtime::new() [INFO] [stdout] 812 | | .unwrap() [INFO] [stdout] 813 | | .block_on(missingparts_service(lobby, game_manager, req)) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:829:9 [INFO] [stdout] | [INFO] [stdout] 827 | fn parse_response(r: Response) -> T { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 828 | let full_body_str = &get_response_text(r); [INFO] [stdout] 829 | serde_json::from_str(full_body_str) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lobby.rs:462:24 [INFO] [stdout] | [INFO] [stdout] 462 | panic!(format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 463 | | "num_players expected={}, actual={}", [INFO] [stdout] 464 | | self.expected_game_size.unwrap(), [INFO] [stdout] 465 | | tokens.len() [INFO] [stdout] 466 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 462 ~ panic!( [INFO] [stdout] 463 | "num_players expected={}, actual={}", [INFO] [stdout] 464 | self.expected_game_size.unwrap(), [INFO] [stdout] 465 | tokens.len() [INFO] [stdout] 466 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playeraction.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | #[derive(Debug, PartialEq, Deserialize, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_utils.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 87 | fn into(self) -> Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | JsonError(e) => ( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | / Response::builder() [INFO] [stdout] 139 | | .status(code) [INFO] [stdout] 140 | | .body(Body::from(message)) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `missingparts` (lib test) due to 11 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d8bfe0b88ed8a99f02e8d95302b54a6de30da41d30d1635860f95ae00f987318", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8bfe0b88ed8a99f02e8d95302b54a6de30da41d30d1635860f95ae00f987318", kill_on_drop: false }` [INFO] [stdout] d8bfe0b88ed8a99f02e8d95302b54a6de30da41d30d1635860f95ae00f987318