[INFO] cloning repository https://github.com/Vzaa/yuvdiff [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Vzaa/yuvdiff" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVzaa%2Fyuvdiff", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVzaa%2Fyuvdiff'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f0965391f2eb8e8c4a9424f298f346e36f2c21a1 [INFO] checking Vzaa/yuvdiff/f0965391f2eb8e8c4a9424f298f346e36f2c21a1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVzaa%2Fyuvdiff" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Vzaa/yuvdiff on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Vzaa/yuvdiff [INFO] finished tweaking git repo https://github.com/Vzaa/yuvdiff [INFO] tweaked toml for git repo https://github.com/Vzaa/yuvdiff written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Vzaa/yuvdiff already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aac0c717709ba74b3002101481aa1e4588290b80755b046fc2ad4a3eb0dcdd7 [INFO] running `Command { std: "docker" "start" "-a" "6aac0c717709ba74b3002101481aa1e4588290b80755b046fc2ad4a3eb0dcdd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aac0c717709ba74b3002101481aa1e4588290b80755b046fc2ad4a3eb0dcdd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aac0c717709ba74b3002101481aa1e4588290b80755b046fc2ad4a3eb0dcdd7", kill_on_drop: false }` [INFO] [stdout] 6aac0c717709ba74b3002101481aa1e4588290b80755b046fc2ad4a3eb0dcdd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69276bcdd3ef0aec0a4170c9877ff94c2acdc1a083fed2e1a1a95b345655c5ce [INFO] running `Command { std: "docker" "start" "-a" "69276bcdd3ef0aec0a4170c9877ff94c2acdc1a083fed2e1a1a95b345655c5ce", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.32 [INFO] [stderr] Checking num-traits v0.1.40 [INFO] [stderr] Compiling sdl2-sys v0.27.3 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking lazy_static v0.2.9 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking rand v0.3.17 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking sdl2 v0.27.3 [INFO] [stderr] Checking yuvdiff v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/yuv.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | (w * h) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - (w * h) [INFO] [stdout] 21 + w * h [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/yuv.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | (w * h) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - (w * h) [INFO] [stdout] 21 + w * h [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sdlui.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | type ButtonHandler = Fn(&mut UiSettings, i32, i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 75 | type ButtonHandler = dyn Fn(&mut UiSettings, i32, i32); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sdlui.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | type ButtonHandler = Fn(&mut UiSettings, i32, i32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 75 | type ButtonHandler = dyn Fn(&mut UiSettings, i32, i32); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yuv.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 178 | let file_in = File::open(filename)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let reader = BufReader::new(file_in); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok(YuvReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 181 | | frame: Yuv::new(w, h), [INFO] [stdout] 182 | | reader: reader, [INFO] [stdout] 183 | | frame_cnt: 0, [INFO] [stdout] 184 | | cursor: 0, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yuv.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 178 | let file_in = File::open(filename)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let reader = BufReader::new(file_in); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok(YuvReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 181 | | frame: Yuv::new(w, h), [INFO] [stdout] 182 | | reader: reader, [INFO] [stdout] 183 | | frame_cnt: 0, [INFO] [stdout] 184 | | cursor: 0, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdlui.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 158 | let sdl_context = sdl2::init().map_err(|e| format!("Can't init SDL: {}", e))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let video_subsystem = sdl_context [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let renderer = window [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let reader_a = YuvReader::new(width_s, height_s, file_a) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | .map_err(|e| format!("Can't open '{}': {}", file_a, e))?; [INFO] [stdout] 179 | let reader_b = YuvReader::new(width_s, height_s, file_b) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | .map_err(|e| format!("Can't open '{}': {}", file_b, e))?; [INFO] [stdout] 181 | let event_pump = sdl_context [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(SdlUi { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | width: width, [INFO] [stdout] 188 | | height: height, [INFO] [stdout] 189 | | event_pump: event_pump, [INFO] [stdout] ... | [INFO] [stdout] 196 | | empty_uv: vec![128; uv_size].into_boxed_slice(), [INFO] [stdout] 197 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdlui.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 158 | let sdl_context = sdl2::init().map_err(|e| format!("Can't init SDL: {}", e))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let video_subsystem = sdl_context [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let renderer = window [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let reader_a = YuvReader::new(width_s, height_s, file_a) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | .map_err(|e| format!("Can't open '{}': {}", file_a, e))?; [INFO] [stdout] 179 | let reader_b = YuvReader::new(width_s, height_s, file_b) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | .map_err(|e| format!("Can't open '{}': {}", file_b, e))?; [INFO] [stdout] 181 | let event_pump = sdl_context [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(SdlUi { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | width: width, [INFO] [stdout] 188 | | height: height, [INFO] [stdout] 189 | | event_pump: event_pump, [INFO] [stdout] ... | [INFO] [stdout] 196 | | empty_uv: vec![128; uv_size].into_boxed_slice(), [INFO] [stdout] 197 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yuvdiff` (bin "yuvdiff") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `yuvdiff` (bin "yuvdiff" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "69276bcdd3ef0aec0a4170c9877ff94c2acdc1a083fed2e1a1a95b345655c5ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69276bcdd3ef0aec0a4170c9877ff94c2acdc1a083fed2e1a1a95b345655c5ce", kill_on_drop: false }` [INFO] [stdout] 69276bcdd3ef0aec0a4170c9877ff94c2acdc1a083fed2e1a1a95b345655c5ce