[INFO] cloning repository https://github.com/VyrCossont/pico8_rom_tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VyrCossont/pico8_rom_tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVyrCossont%2Fpico8_rom_tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVyrCossont%2Fpico8_rom_tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f3b45b418a1ebaf2504e926d1c8172c38a91c443 [INFO] checking VyrCossont/pico8_rom_tool/f3b45b418a1ebaf2504e926d1c8172c38a91c443 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVyrCossont%2Fpico8_rom_tool" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/VyrCossont/pico8_rom_tool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/VyrCossont/pico8_rom_tool [INFO] finished tweaking git repo https://github.com/VyrCossont/pico8_rom_tool [INFO] tweaked toml for git repo https://github.com/VyrCossont/pico8_rom_tool written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/VyrCossont/pico8_rom_tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 113aee0a1cf2abe6ed962621d9734ffb042e5b4be09c86cf918fdca99d030523 [INFO] running `Command { std: "docker" "start" "-a" "113aee0a1cf2abe6ed962621d9734ffb042e5b4be09c86cf918fdca99d030523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "113aee0a1cf2abe6ed962621d9734ffb042e5b4be09c86cf918fdca99d030523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "113aee0a1cf2abe6ed962621d9734ffb042e5b4be09c86cf918fdca99d030523", kill_on_drop: false }` [INFO] [stdout] 113aee0a1cf2abe6ed962621d9734ffb042e5b4be09c86cf918fdca99d030523 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f381f27ea6616dbb7fd00b8a921375d3d6f095b26e713cda0022ec39f2d1eaf4 [INFO] running `Command { std: "docker" "start" "-a" "f381f27ea6616dbb7fd00b8a921375d3d6f095b26e713cda0022ec39f2d1eaf4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.63 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking funty v1.2.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling packed_struct v0.10.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking wyz v0.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking bitvec v0.22.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling packed_struct_codegen v0.10.0 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Checking clap v3.2.19 [INFO] [stderr] Checking pico8_rom_tool v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `set_begin_loop`, `set_end_loop`, and `set_stop_at_end` are never used [INFO] [stdout] --> src/music.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 98 | impl Pattern { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn set_begin_loop(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn set_end_loop(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 119 | pub fn set_stop_at_end(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_enabled` is never used [INFO] [stdout] --> src/music.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 141 | impl Channel { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn set_enabled(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_detune`, `set_reverb`, and `set_dampen` are never used [INFO] [stdout] --> src/sfx.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 126 | impl Switches { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn set_detune(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn set_reverb(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 153 | pub fn set_dampen(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `set_pitch`, `set_volume`, `set_effect`, and `set_instrument` are never used [INFO] [stdout] --> src/sfx.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 169 | impl Note { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 182 | fn write(&mut self, bits: &RangeInclusive, val: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 196 | pub fn set_pitch(&mut self, val: Pitch) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | pub fn set_volume(&mut self, val: Integer>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | pub fn set_effect(&mut self, val: Effect) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 236 | pub fn set_instrument(&mut self, val: Instrument) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/sfx.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | Sfx(Integer>), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Instrument` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 268 | Sfx(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rom.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 18 | let mut rom = File::open(path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | rom.seek(SeekFrom::Start(offset))?; [INFO] [stdout] 20 | let mut buf = T::ByteArray::new(0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | rom.read_exact(buf.as_mut_bytes_slice())?; [INFO] [stdout] 22 | T::unpack(&buf).map_err(|e| anyhow::anyhow!(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pico8_rom_tool` (bin "pico8_rom_tool" test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `set_begin_loop`, `set_end_loop`, and `set_stop_at_end` are never used [INFO] [stdout] --> src/music.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 98 | impl Pattern { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 103 | pub fn set_begin_loop(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | pub fn set_end_loop(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 119 | pub fn set_stop_at_end(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_enabled` is never used [INFO] [stdout] --> src/music.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 141 | impl Channel { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn set_enabled(&mut self, val: bool) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_detune`, `set_reverb`, and `set_dampen` are never used [INFO] [stdout] --> src/sfx.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 126 | impl Switches { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn set_detune(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn set_reverb(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 153 | pub fn set_dampen(&mut self, val: u8) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write`, `set_pitch`, `set_volume`, `set_effect`, and `set_instrument` are never used [INFO] [stdout] --> src/sfx.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 169 | impl Note { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 182 | fn write(&mut self, bits: &RangeInclusive, val: u8) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 196 | pub fn set_pitch(&mut self, val: Pitch) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | pub fn set_volume(&mut self, val: Integer>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 212 | pub fn set_effect(&mut self, val: Effect) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 236 | pub fn set_instrument(&mut self, val: Instrument) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/sfx.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | Sfx(Integer>), [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Instrument` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 268 | Sfx(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rom.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 18 | let mut rom = File::open(path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | rom.seek(SeekFrom::Start(offset))?; [INFO] [stdout] 20 | let mut buf = T::ByteArray::new(0); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | rom.read_exact(buf.as_mut_bytes_slice())?; [INFO] [stdout] 22 | T::unpack(&buf).map_err(|e| anyhow::anyhow!(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pico8_rom_tool` (bin "pico8_rom_tool") due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f381f27ea6616dbb7fd00b8a921375d3d6f095b26e713cda0022ec39f2d1eaf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f381f27ea6616dbb7fd00b8a921375d3d6f095b26e713cda0022ec39f2d1eaf4", kill_on_drop: false }` [INFO] [stdout] f381f27ea6616dbb7fd00b8a921375d3d6f095b26e713cda0022ec39f2d1eaf4